From: Eric Biggers <ebiggers@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Satya Tangirala <satyat@google.com>,
Theodore Ts'o <tytso@mit.edu>,
"Darrick J . Wong" <djwong@kernel.org>,
Dave Chinner <david@fromorbit.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, linux-fscrypt@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v10 1/5] fscrypt: add functions for direct I/O support
Date: Thu, 20 Jan 2022 01:04:17 -0800 [thread overview]
Message-ID: <Yeklkcc7NXKYDHUL@sol.localdomain> (raw)
In-Reply-To: <YekdAa4fCKw7VY3J@infradead.org>
On Thu, Jan 20, 2022 at 12:27:45AM -0800, Christoph Hellwig wrote:
> > +/**
> > + * fscrypt_dio_unsupported() - check whether a DIO (direct I/O) request is
> > + * unsupported due to encryption constraints
> > + * @iocb: the file and position the I/O is targeting
> > + * @iter: the I/O data segment(s)
> > + *
> > + * Return: true if DIO is unsupported
> > + */
> > +bool fscrypt_dio_unsupported(struct kiocb *iocb, struct iov_iter *iter)
>
> I always find non-negated functions easier to follow, i.e. turn this
> into fscrypt_dio_supported().
>
I actually had changed this from v9 because fscrypt_dio_supported() seemed
backwards, given that its purpose is to check whether DIO is unsupported, not
whether it's supported per se (and the function's comment reflected this). What
ext4 and f2fs do is check a list of reasons why DIO would *not* be supported,
and if none apply, then it is supported. This is just one of those reasons.
This is subjective though, so if people prefer the old way, I'll change it back.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-01-20 9:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 7:12 [f2fs-dev] [PATCH v10 0/5] add support for direct I/O with fscrypt using blk-crypto Eric Biggers
2022-01-20 7:12 ` [f2fs-dev] [PATCH v10 1/5] fscrypt: add functions for direct I/O support Eric Biggers
2022-01-20 8:27 ` Christoph Hellwig
2022-01-20 9:04 ` Eric Biggers [this message]
2022-01-21 7:10 ` Christoph Hellwig
2022-01-20 7:12 ` [f2fs-dev] [PATCH v10 2/5] iomap: support direct I/O with fscrypt using blk-crypto Eric Biggers
2022-01-20 8:28 ` Christoph Hellwig
2022-01-20 7:12 ` [f2fs-dev] [PATCH v10 3/5] ext4: " Eric Biggers
2022-01-20 7:12 ` [f2fs-dev] [PATCH v10 4/5] f2fs: " Eric Biggers
2022-01-20 7:12 ` [f2fs-dev] [PATCH v10 5/5] fscrypt: update documentation for direct I/O support Eric Biggers
2022-01-20 8:30 ` [f2fs-dev] [PATCH v10 0/5] add support for direct I/O with fscrypt using blk-crypto Christoph Hellwig
2022-01-20 17:10 ` Darrick J. Wong
2022-01-20 20:39 ` Eric Biggers
2022-01-20 21:00 ` Darrick J. Wong
2022-01-20 22:04 ` Dave Chinner
2022-01-20 22:48 ` Eric Biggers
2022-01-20 23:57 ` Dave Chinner
2022-01-21 2:36 ` Darrick J. Wong
2022-01-21 7:12 ` Christoph Hellwig
2022-01-23 23:03 ` Dave Chinner
2022-02-09 1:10 ` Eric Biggers
2022-02-10 4:03 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yeklkcc7NXKYDHUL@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=satyat@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).