From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F53AC433F5 for ; Wed, 23 Mar 2022 07:33:59 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nWvVF-00041N-Cs; Wed, 23 Mar 2022 07:33:56 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nWvVD-00041G-K0 for linux-f2fs-devel@lists.sourceforge.net; Wed, 23 Mar 2022 07:33:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IL1DTXQ5PLoYDtzOHs2rZCCbl2DebPhnoyDqu6ydMA8=; b=Vc2TfC2OAj4hDDuomRmFbqM7NN DsLxpTyJ+TReDbx6v3AUicEAcCzM+SSVCZLl17xX5PzcIlr2CwNemfrflLUgbSgCp8l+r7yKyna8A WKevspxe93GIOo9j51GjRPVaONRh3mLSMqe7k2lP7KhbnMcveCg7ufcPVzXWFzdRKjZU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=IL1DTXQ5PLoYDtzOHs2rZCCbl2DebPhnoyDqu6ydMA8=; b=BcHy/YRnWHy36+4iH8U9syxbxO 1GTaJW3Yd/JOVRrorZq8wP7fLfNY/TNzhqcSD0Y+j/wX9J6iSVBpcOzxYoqSTbP8Z3pt3bd7JHeEW 9j0xk5D1u39AiNqSgPC/Wo3v+y4hgP2YgtuIbJDl2ZQHXNUqu15YXgD+e/iZkmc+Kevg=; Received: from bombadil.infradead.org ([198.137.202.133]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nWvV4-0004Oo-Ot for linux-f2fs-devel@lists.sourceforge.net; Wed, 23 Mar 2022 07:33:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IL1DTXQ5PLoYDtzOHs2rZCCbl2DebPhnoyDqu6ydMA8=; b=pvTTIq3vz9PCfsGVX4JxViANnB Y2YljE0qJSg5q7PdfzAsI6zEB1NELwqox4PWgEe4k3nyAFrGZ0XU+tWpyCsaWHhz4X2egueJxUbI/ JD9EJSwKZYTBtdgbwK551Bz55MjQmXwcgYEQ2IgI55anLvcR1ESjk4gttuPZl9NbNAD5unn85kGPB o45UVIj5pBYktS2mbU5VGdKHgnnRYK1ztvZsRwxiZ80GciDqwMsICKUBoGjyCr/YaI8118csap9Wm ev8jYlgQDWtgKU/xdpyOmiZOUqzEN4FeI5r0P4CdW99nG+DQqzYCcRQDuyYctVEt9wXTfcwB3qUYy rKjbVFSQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWvUk-00D0Ka-5z; Wed, 23 Mar 2022 07:33:26 +0000 Date: Wed, 23 Mar 2022 00:33:26 -0700 From: Christoph Hellwig To: Linus Torvalds Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Headers-End: 1nWvV4-0004Oo-Ot Subject: Re: [f2fs-dev] [GIT PULL] f2fs for 5.18 X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Jaegeuk Kim , Linux F2FS Dev Mailing List , Linux Kernel Mailing List , Waiman Long Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Mar 22, 2022 at 10:22:50AM -0700, Linus Torvalds wrote: > On Mon, Mar 21, 2022 at 1:39 PM Jaegeuk Kim wrote: > > > > In this cycle, f2fs has some performance improvements for Android workloads such > > as using read-unfair rwsems [...] > > I've pulled this, but that read-unfair rwsem code looks incredibly > dodgy. Doing your own locking is always a bad sign, and it ahs > traditionally come back to bite us pretty much every time. At least it > uses real lock primitives, just in a really odd way. FYI, Peter and I both pointed this out when the patches were posted and NAKed the patch, but the feedback was ignored. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel