From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Waiman Long <longman@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux F2FS Dev Mailing List
<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [GIT PULL] f2fs for 5.18
Date: Wed, 23 Mar 2022 09:48:17 -0700 [thread overview]
Message-ID: <YjtPUec8jiqUXGuf@google.com> (raw)
In-Reply-To: <YjrNRpbo/i3tgbAA@infradead.org>
On 03/23, Christoph Hellwig wrote:
> On Tue, Mar 22, 2022 at 10:22:50AM -0700, Linus Torvalds wrote:
> > On Mon, Mar 21, 2022 at 1:39 PM Jaegeuk Kim <jaegeuk@kernel.org> wrote:
> > >
> > > In this cycle, f2fs has some performance improvements for Android workloads such
> > > as using read-unfair rwsems [...]
> >
> > I've pulled this, but that read-unfair rwsem code looks incredibly
> > dodgy. Doing your own locking is always a bad sign, and it ahs
> > traditionally come back to bite us pretty much every time. At least it
> > uses real lock primitives, just in a really odd way.
>
> FYI, Peter and I both pointed this out when the patches were posted
> and NAKed the patch, but the feedback was ignored.
Christoph, I proposed,
"I've been waiting for a generic solution as suggested here. Until then, I'd like
to keep this in f2fs *only* in order to ship the fix in products. Once there's
a right fix, let me drop or revise this patch again."
https://lore.kernel.org/linux-f2fs-devel/YhZzV11+BlgI1PBd@google.com/
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-03-23 16:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 20:39 [f2fs-dev] [GIT PULL] f2fs for 5.18 Jaegeuk Kim
2022-03-22 17:22 ` Linus Torvalds
2022-03-22 17:37 ` Waiman Long
2022-03-22 17:50 ` Linus Torvalds
2022-03-22 20:58 ` Jaegeuk Kim
2022-06-15 20:13 ` Pavel Machek
2022-06-16 17:02 ` Jaegeuk Kim
2022-03-23 0:34 ` Tim Murray via Linux-f2fs-devel
2022-03-23 2:03 ` Linus Torvalds
2022-03-23 16:26 ` Jaegeuk Kim
2022-03-23 17:06 ` Linus Torvalds
2022-03-23 21:21 ` Jaegeuk Kim
2022-03-23 7:33 ` Christoph Hellwig
2022-03-23 16:48 ` Jaegeuk Kim [this message]
2022-03-23 16:49 ` Christoph Hellwig
2022-03-23 17:00 ` Jaegeuk Kim
2022-03-23 19:28 ` Waiman Long
2022-03-23 21:25 ` Jaegeuk Kim
2022-03-22 18:32 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjtPUec8jiqUXGuf@google.com \
--to=jaegeuk@kernel.org \
--cc=hch@infradead.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).