Re: [f2fs-dev] [PATCH 2/3] libf2fs: add support to report zone size

[Luis Chamberlain <mcgrof@kernel.org>]

On Tue, Apr 12, 2022 at 12:14:13PM +0000, Damien Le Moal wrote:
> On Tue, 2022-04-12 at 13:27 +0200, Pankaj Raghav wrote:
> > From: Luis Chamberlain <mcgrof@kernel.org>
> > 
> > Expand get_device_info() to report the zone size.
> > This is now important give power of 2 zone sizees (PO2)
> 
> s/give/given that
> s/sizees/size
> 
> > can exist, and so can non power of 2 zones sizes (NPO2),
> 
> No they cannot, not yet in Linux.

They *do* exist in the real world, and in Linux they do come up when
users are manually removing the current po2 requirement on Linux
sources [0].

So how about:

This is now important give power of 2 zone sizees (PO2)
do exist and some users are manually forcing to enable these
on Linux [0].

[0] https://lkml.kernel.org/r/CAJjM=8Cap1bwu8cp-mRTsiBmbHH=Ed8pp9vdAsig2o_ZiHTc-g@mail.gmail.com

> Overall, I really do not see the point of this patch.

It makes the subsequent patch easier to read and also makes
the displaying zone support separate easier to review. It can
certainly be merged, but I don't think it makes the last patch
as easier to read. It's subjective and up to the maintainer.

  Luis


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel