From: Eric Biggers <ebiggers@kernel.org>
To: linux-fscrypt@vger.kernel.org
Cc: ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-mtd@lists.infradead.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] fscrypt: split up FS_CRYPTO_BLOCK_SIZE
Date: Wed, 13 Apr 2022 22:31:33 -0700 [thread overview]
Message-ID: <YlextfUbirO97Gl7@sol.localdomain> (raw)
In-Reply-To: <20220405010914.18519-1-ebiggers@kernel.org>
On Mon, Apr 04, 2022 at 06:09:14PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> FS_CRYPTO_BLOCK_SIZE is neither the filesystem block size nor the
> granularity of encryption. Rather, it defines two logically separate
> constraints that both arise from the block size of the AES cipher:
>
> - The alignment required for the lengths of file contents blocks
> - The minimum input/output length for the filenames encryption modes
>
> Since there are way too many things called the "block size", and the
> connection with the AES block size is not easily understood, split
> FS_CRYPTO_BLOCK_SIZE into two constants FSCRYPT_CONTENTS_ALIGNMENT and
> FSCRYPT_FNAME_MIN_MSG_LEN that more clearly describe what they are.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> fs/crypto/crypto.c | 10 +++++-----
> fs/crypto/fname.c | 11 +++++++++--
> fs/ubifs/ubifs.h | 2 +-
> include/linux/fscrypt.h | 12 +++++++++++-
> 4 files changed, 26 insertions(+), 9 deletions(-)
Applied to fscrypt.git#master for 5.19.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2022-04-14 5:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 1:09 [f2fs-dev] [PATCH] fscrypt: split up FS_CRYPTO_BLOCK_SIZE Eric Biggers
2022-04-14 5:31 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlextfUbirO97Gl7@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).