From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39184C433FE for ; Fri, 13 May 2022 17:59:12 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1npZZF-0004Zo-5T; Fri, 13 May 2022 17:59:09 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1npZZ4-0004ZK-Pp for linux-f2fs-devel@lists.sourceforge.net; Fri, 13 May 2022 17:58:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KsAIJrZ6pvlUlG0swjFnjhYnjuZSWYVYyhgoijXKTuw=; b=Z2+bsLG/Djhugl2slyRD/YW0Jm bzSz+5GQNsnSokV9u6LdrSdM2NGODdG5Fx0vQBsLnpK/cPsOsR5htt5xppW6o7B6hRyGuGooZjh1K pLadhLB/fviLKLkrkWGP8O1KiZjRNBNLZ/Mt9Qb1kQBys/zUUuJjnQBTUiqqXC5XCvWA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KsAIJrZ6pvlUlG0swjFnjhYnjuZSWYVYyhgoijXKTuw=; b=PtbrDovEd5dMDvo1W871ME5RlH DU46hu/15xaYZx9pvrLKg5ij0PLKe8FWQ78S8hyPDSY2ClkZChi9MQEFqtfS89CMQxPIGD1TjnvSw YSOTxk7d3Mk7hdxtKpRk4SGwk0lj5C88Alc5+rsEcLGBTAI4/xc6Nsuov7/O03Gj3haA=; Received: from ams.source.kernel.org ([145.40.68.75]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1npZZ3-00B8p0-Mn for linux-f2fs-devel@lists.sourceforge.net; Fri, 13 May 2022 17:58:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6AB64B83113; Fri, 13 May 2022 17:58:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16779C34100; Fri, 13 May 2022 17:58:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652464730; bh=jGfDN22SNm6l9Olp99VGq49P1EF6SURnNx6xntTGmKI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NWnvrBSRuXQJFRMA36dkLiXexzwyIRUSYSyuPDLc3bWltDfPmrJ3iDtFRxAXByhNs Hs9bMe70Ee/OAkY/+ld5m/tvFFzPnEp8m5XVfoadsHA2zw9aJcMN3zJrM0Z/Tef6O5 Qmm2wB22truSuC8WnYQRburiMCPmVT0/n3uS0K2tvOHOwvpGyn+EyxKZqE8iatafjw LPv452tJH6B+ZraHb5zmh5zAmqOj8FJSAYtdYbyIwGG3mbmArJ/Rp0lcgkoHPLx2cG TdlRw6l/IRIdV5Z5qpGHeJzD+U+SkkpV4ZE7pLhOsuaBwc/zSD5xppm/MbX3vxxkTu XRmUyWz4KUNag== Date: Fri, 13 May 2022 10:58:48 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20220512082116.2991611-1-chao@kernel.org> <59d77fcb-bc82-c1d2-0a71-eef3b0140506@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <59d77fcb-bc82-c1d2-0a71-eef3b0140506@kernel.org> X-Headers-End: 1npZZ3-00B8p0-Mn Subject: Re: [f2fs-dev] [PATCH] f2fs: separate NOCoW and pinfile semantics X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 05/13, Chao Yu wrote: > On 2022/5/13 5:57, Jaegeuk Kim wrote: > > On 05/12, Chao Yu wrote: > > > Pinning a file is heavy, because skipping pinned files make GC > > > running with heavy load or no effect. > > > > > > So that this patch proposes to separate nocow and pinfile semantics: > > > - NOCoW flag can only be set on regular file. > > > - NOCoW file will only trigger IPU at common writeback/flush. > > > - NOCow file will do OPU during GC. > > > > > > This flag can satisfying the demand of: > > > 1) avoiding fragment of file's physical block > > > 2) userspace doesn't want to pin file's physical address > > > > > > Signed-off-by: Chao Yu > > > --- > > > fs/f2fs/data.c | 3 ++- > > > fs/f2fs/f2fs.h | 1 + > > > fs/f2fs/file.c | 25 ++++++++++++++++++++++++- > > > 3 files changed, 27 insertions(+), 2 deletions(-) > > > > > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > > > index 54a7a8ad994d..c8eab78f7d89 100644 > > > --- a/fs/f2fs/data.c > > > +++ b/fs/f2fs/data.c > > > @@ -2495,7 +2495,8 @@ bool f2fs_should_update_inplace(struct inode *inode, struct f2fs_io_info *fio) > > > if (is_inode_flag_set(inode, FI_ALIGNED_WRITE)) > > > return false; > > > - if (f2fs_is_pinned_file(inode)) > > > + if (f2fs_is_pinned_file(inode) || > > > + F2FS_I(inode)->i_flags & F2FS_NOCOW_FL) > > > return true; > > > /* if this is cold file, we should overwrite to avoid fragmentation */ > > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > > > index 492af5b96de1..e91ece55f5e8 100644 > > > --- a/fs/f2fs/f2fs.h > > > +++ b/fs/f2fs/f2fs.h > > > @@ -2916,6 +2916,7 @@ static inline void f2fs_change_bit(unsigned int nr, char *addr) > > > #define F2FS_NOCOMP_FL 0x00000400 /* Don't compress */ > > > #define F2FS_INDEX_FL 0x00001000 /* hash-indexed directory */ > > > #define F2FS_DIRSYNC_FL 0x00010000 /* dirsync behaviour (directories only) */ > > > +#define F2FS_NOCOW_FL 0x00800000 /* Do not cow file */ > > > #define F2FS_PROJINHERIT_FL 0x20000000 /* Create with parents projid */ > > > #define F2FS_CASEFOLD_FL 0x40000000 /* Casefolded file */ > > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > > > index 09287876dbb7..7f92a3a157f7 100644 > > > --- a/fs/f2fs/file.c > > > +++ b/fs/f2fs/file.c > > > @@ -1851,6 +1851,20 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask) > > > if (IS_NOQUOTA(inode)) > > > return -EPERM; > > > + if ((iflags ^ masked_flags) & F2FS_NOCOW_FL) { > > > + int ret; > > > + > > > + if (!S_ISREG(inode->i_mode)) > > > + return -EINVAL; > > > + if (f2fs_should_update_outplace(inode, NULL)) > > > + return -EINVAL; > > > + if (f2fs_is_pinned_file(inode)) > > > + return -EINVAL; > > > + ret = f2fs_convert_inline_inode(inode); > > > + if (ret) > > > + return ret; > > > + } > > > + > > > if ((iflags ^ masked_flags) & F2FS_CASEFOLD_FL) { > > > if (!f2fs_sb_has_casefold(F2FS_I_SB(inode))) > > > return -EOPNOTSUPP; > > > @@ -1926,6 +1940,7 @@ static const struct { > > > { F2FS_NOCOMP_FL, FS_NOCOMP_FL }, > > > { F2FS_INDEX_FL, FS_INDEX_FL }, > > > { F2FS_DIRSYNC_FL, FS_DIRSYNC_FL }, > > > + { F2FS_NOCOW_FL, FS_NOCOW_FL }, > > > { F2FS_PROJINHERIT_FL, FS_PROJINHERIT_FL }, > > > { F2FS_CASEFOLD_FL, FS_CASEFOLD_FL }, > > > }; > > > @@ -1957,7 +1972,8 @@ static const struct { > > > FS_NOCOMP_FL | \ > > > FS_DIRSYNC_FL | \ > > > FS_PROJINHERIT_FL | \ > > > - FS_CASEFOLD_FL) > > > + FS_CASEFOLD_FL | \ > > > + FS_NOCOW_FL) > > > /* Convert f2fs on-disk i_flags to FS_IOC_{GET,SET}FLAGS flags */ > > > static inline u32 f2fs_iflags_to_fsflags(u32 iflags) > > > @@ -3081,6 +3097,13 @@ static int f2fs_ioc_set_pin_file(struct file *filp, unsigned long arg) > > > inode_lock(inode); > > > + if (F2FS_I(inode)->i_flags & F2FS_NOCOW_FL) { > > > + f2fs_info(F2FS_I_SB(inode), "inode (%lu) is already NOCOW one", > > > + inode->i_ino); > > > + ret = -EINVAL; > > > > Why rejecting this? We can pin the file to get 2MB-aligned allocation on the > > NOCOW file. > > I try to separate these two flag completely, but, seems it can't, because after > commit 5d539245cb18 ("f2fs: export FS_NOCOW_FL flag to user"), these two flags > have already been twined closely.... > > @@ -1651,6 +1651,8 @@ static int f2fs_ioc_getflags(struct file *filp, unsigned long arg) > flags |= F2FS_ENCRYPT_FL; > if (f2fs_has_inline_data(inode) || f2fs_has_inline_dentry(inode)) > flags |= F2FS_INLINE_DATA_FL; > + if (is_inode_flag_set(inode, FI_PIN_FILE)) > + flags |= F2FS_NOCOW_FL; > > How about: > > f2fs_ioc_set_pin_file/f2fs_fileattr_set logic: > pinfile nocow > set set pinfile | nocow set nocow > clear clear pinfile | nocow clear nocow > > Behaviors: > w/ pinfile, w/ nocow: use pinfile semantics > w/ pinfile, w/o nocow: use pinfile semantics > w/o pinfile, w/ nocow: use nocow semantics > w/o pinfile, w/o nocow: no pinfile or nocow semantics This looks good to me. Thanks, > > Thanks, > > > > > > + goto out; > > > + } > > > + > > > if (!pin) { > > > clear_inode_flag(inode, FI_PIN_FILE); > > > f2fs_i_gc_failures_write(inode, 0); > > > -- > > > 2.25.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel