From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99C00C433F5 for ; Mon, 9 May 2022 16:57:42 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1no6hZ-0004y6-NQ; Mon, 09 May 2022 16:57:40 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1no6hZ-0004y0-36 for linux-f2fs-devel@lists.sourceforge.net; Mon, 09 May 2022 16:57:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MkJQ6qBf4iIPY4C4mrIVAlhnbR5nRduVdUJhWsd24BY=; b=hyevgoZoFHHEx81wHy5RY3Ww7h QSFV88bfR7ySwSCaxaG1hB2S3/Mkjy1yFFXMO4NfZ/gTZEmaGsjgZBuUzZCN2I2DZkUQLBvXjwhjC PZHtP4AcOxW9olr66oFh5q2z7qtvexV4y2QAHUzJusFYaAbbsOK+V7WYDBaimet1UFcg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MkJQ6qBf4iIPY4C4mrIVAlhnbR5nRduVdUJhWsd24BY=; b=GCoKr5Y9Kp4aE2GpBa9SwhwmMU ZAydmR7Y7Dojqfld2j1zmyYKiKqsAGKO2pS90ycpB+NfqRO2C8o65bx70dJrGhqCuF1NEyjjp0STE rXvPpbiCXlYDIHPc/PM+a3BlQFjpa+caF4rFWXrx5/9T8w3FXasMssQgrJqvAI+4VRFo=; Received: from ams.source.kernel.org ([145.40.68.75]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1no6hX-006TI3-0F for linux-f2fs-devel@lists.sourceforge.net; Mon, 09 May 2022 16:57:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 00C04B8180C; Mon, 9 May 2022 16:57:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95B52C385B2; Mon, 9 May 2022 16:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652115449; bh=OaXybH4jCWXEKkCxz9xjsRa7BIfvoYHVfNPxqyV5/94=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RJuMf1panOt4mw/iicfCpg3O5q1+LpvR5dgUX36eHh6ymw2J8oEJm/XBJWo4zWYMg 65WG208cr1xfLdqpe9wBhyt42K8i5l2tm8+i8sLFmIZDrhO+tbV7X5lfCrlX7ircJl +R00oiq9K+1s7SjB0TKqXkgDjsnSFrt0F+fbP+256Wfk5EUjJjytQDMVWKKNcuxuzX mYmCJXdAn9zeS7QTGq6BPC3UyEqJWO/0Md+QNIdj1yqpQ2eqLiHkfnmCbMb372dmzD +bsJ9ZmNjacbiPN8njZICA9SOhg18ljW0Pk4jBLraIazA+9VXCDxdX1unB/mAPLYQa qD9N9Tl9+FzQA== Date: Mon, 9 May 2022 09:57:27 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20220428024940.12102-1-chao@kernel.org> <173c51c2-eff3-8d76-7041-e9c58024a97e@kernel.org> <142acf95-c940-8d4a-7f00-08f1bb816c49@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1no6hX-006TI3-0F Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to do sanity check for inline inode X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ming Yan , linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 05/08, Chao Yu wrote: > Ping, This is in my TODO list, but will take some time. Sorry. > > On 2022/5/5 22:33, Chao Yu wrote: > > On 2022/5/5 11:31, Jaegeuk Kim wrote: > > > On 05/05, Chao Yu wrote: > > > > On 2022/5/5 5:28, Jaegeuk Kim wrote: > > > > > On 04/28, Chao Yu wrote: > > > > > > As Yanming reported in bugzilla: > > > > > > > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=215895 > > > > > > > > > > > > I have encountered a bug in F2FS file system in kernel v5.17. > > > > > > > > > > > > The kernel message is shown below: > > > > > > > > > > > > kernel BUG at fs/inode.c:611! > > > > > > Call Trace: > > > > > > evict+0x282/0x4e0 > > > > > > __dentry_kill+0x2b2/0x4d0 > > > > > > dput+0x2dd/0x720 > > > > > > do_renameat2+0x596/0x970 > > > > > > __x64_sys_rename+0x78/0x90 > > > > > > do_syscall_64+0x3b/0x90 > > > > > > > > > > > > The root cause is: fuzzed inode has both inline_data flag and encrypted > > > > > > flag, so after it was deleted by rename(), during f2fs_evict_inode(), > > > > > > it will cause inline data conversion due to flags confilction, then > > > > > > page cache will be polluted and trigger panic in clear_inode(). > > > > > > > > > > > > This patch tries to fix the issue by do more sanity checks for inline > > > > > > data inode in sanity_check_inode(). > > > > > > > > > > > > Cc: stable@vger.kernel.org > > > > > > Reported-by: Ming Yan > > > > > > Signed-off-by: Chao Yu > > > > > > --- > > > > > > fs/f2fs/f2fs.h | 7 +++++++ > > > > > > fs/f2fs/inode.c | 3 +-- > > > > > > 2 files changed, 8 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > > > > > > index 27aa93caec06..64c511b498cc 100644 > > > > > > --- a/fs/f2fs/f2fs.h > > > > > > +++ b/fs/f2fs/f2fs.h > > > > > > @@ -4173,6 +4173,13 @@ static inline void f2fs_set_encrypted_inode(struct inode *inode) > > > > > > */ > > > > > > static inline bool f2fs_post_read_required(struct inode *inode) > > > > > > { > > > > > > + /* > > > > > > + * used by sanity_check_inode(), when disk layout fields has not > > > > > > + * been synchronized to inmem fields. > > > > > > + */ > > > > > > + if (file_is_encrypt(inode) || file_is_verity(inode) || > > > > > > + F2FS_I(inode)->i_flags & F2FS_COMPR_FL) > > > > > > + return true; > > > > > > return f2fs_encrypted_file(inode) || fsverity_active(inode) || > > > > > > f2fs_compressed_file(inode); > > > > > > } > > > > > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > > > > > > index 83639238a1fe..234b8ed02644 100644 > > > > > > --- a/fs/f2fs/inode.c > > > > > > +++ b/fs/f2fs/inode.c > > > > > > @@ -276,8 +276,7 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page) > > > > > > } > > > > > > } > > > > > > - if (f2fs_has_inline_data(inode) && > > > > > > - (!S_ISREG(inode->i_mode) && !S_ISLNK(inode->i_mode))) { > > > > > > + if (f2fs_has_inline_data(inode) && !f2fs_may_inline_data(inode)) { > > > > > > > > > > It seems f2fs_may_inline_data() is breaking the atomic write case. Please fix. > > > > > > > > sanity_check_inode() change only affect f2fs_iget(), during inode initialization, > > > > file should not be set as atomic one, right? > > > > > > > > I didn't see any failure during 'f2fs_io write atomic_write' testcase... could you > > > > please provide me detail of the testcase? > > > > > > I just applied this into my device and was getting lots of the below error > > > messages resulting in open failures of database files. > > > > Could you please help to apply below patch and dump the log? > > > > From: Chao Yu > > Subject: [PATCH] f2fs: fix to do sanity check for inline inode > > > > Signed-off-by: Chao Yu > > --- > > fs/f2fs/f2fs.h | 7 +++++++ > > fs/f2fs/inode.c | 11 +++++++---- > > 2 files changed, 14 insertions(+), 4 deletions(-) > > > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > > index 0f8c426aed50..13a9212d6cb6 100644 > > --- a/fs/f2fs/f2fs.h > > +++ b/fs/f2fs/f2fs.h > > @@ -4159,6 +4159,13 @@ static inline void f2fs_set_encrypted_inode(struct inode *inode) > > */ > > static inline bool f2fs_post_read_required(struct inode *inode) > > { > > + /* > > + * used by sanity_check_inode(), when disk layout fields has not > > + * been synchronized to inmem fields. > > + */ > > + if (file_is_encrypt(inode) || file_is_verity(inode) || > > + F2FS_I(inode)->i_flags & F2FS_COMPR_FL) > > + return true; > > return f2fs_encrypted_file(inode) || fsverity_active(inode) || > > f2fs_compressed_file(inode); > > } > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > > index 02630c17da93..a98614a24ad0 100644 > > --- a/fs/f2fs/inode.c > > +++ b/fs/f2fs/inode.c > > @@ -276,11 +276,14 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page) > > } > > } > > > > - if (f2fs_has_inline_data(inode) && > > - (!S_ISREG(inode->i_mode) && !S_ISLNK(inode->i_mode))) { > > + if (f2fs_has_inline_data(inode) && !f2fs_may_inline_data(inode)) { > > set_sbi_flag(sbi, SBI_NEED_FSCK); > > - f2fs_warn(sbi, "%s: inode (ino=%lx, mode=%u) should not have inline_data, run fsck to fix", > > - __func__, inode->i_ino, inode->i_mode); > > + f2fs_warn(sbi, "%s: inode (ino=%lx, mode=%u) reason(%d, %llu, %ld, %d, %d, %lu) should not have inline_data, run fsck to fix", > > + __func__, inode->i_ino, inode->i_mode, > > + f2fs_is_atomic_file(inode), > > + i_size_read(inode), MAX_INLINE_DATA(inode), > > + file_is_encrypt(inode), file_is_verity(inode), > > + F2FS_I(inode)->i_flags & F2FS_COMPR_FL); > > return false; > > } > > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel