* [f2fs-dev] [PATCH] f2fs: fix error code in f2fs_ioc_start_atomic_write()
@ 2022-05-11 13:20 Dan Carpenter
2022-05-11 16:46 ` Daeho Jeong via Linux-f2fs-devel
2022-05-11 17:37 ` Jaegeuk Kim
0 siblings, 2 replies; 5+ messages in thread
From: Dan Carpenter @ 2022-05-11 13:20 UTC (permalink / raw)
To: Jaegeuk Kim, Daeho Jeong; +Cc: kernel-janitors, linux-f2fs-devel
Return an error code if f2fs_iget() fails. Currently it returns
success.
Fixes: 3d7ad9c30607 ("f2fs: change the current atomic write way")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
fs/f2fs/file.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 79d1a20fbda9..cd768fadfd67 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp)
pinode = f2fs_iget(inode->i_sb, fi->i_pino);
if (IS_ERR(pinode)) {
f2fs_up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
+ ret = PTR_ERR(pinode);
goto out;
}
--
2.35.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: fix error code in f2fs_ioc_start_atomic_write()
2022-05-11 13:20 [f2fs-dev] [PATCH] f2fs: fix error code in f2fs_ioc_start_atomic_write() Dan Carpenter
@ 2022-05-11 16:46 ` Daeho Jeong via Linux-f2fs-devel
2022-05-11 17:37 ` Jaegeuk Kim
1 sibling, 0 replies; 5+ messages in thread
From: Daeho Jeong via Linux-f2fs-devel @ 2022-05-11 16:46 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jaegeuk Kim, kernel-janitors, linux-f2fs-devel
Oh, right. Thanks~!
On Wed, May 11, 2022 at 6:20 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> Return an error code if f2fs_iget() fails. Currently it returns
> success.
>
> Fixes: 3d7ad9c30607 ("f2fs: change the current atomic write way")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> fs/f2fs/file.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 79d1a20fbda9..cd768fadfd67 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp)
> pinode = f2fs_iget(inode->i_sb, fi->i_pino);
> if (IS_ERR(pinode)) {
> f2fs_up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
> + ret = PTR_ERR(pinode);
> goto out;
> }
>
> --
> 2.35.1
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: fix error code in f2fs_ioc_start_atomic_write()
2022-05-11 13:20 [f2fs-dev] [PATCH] f2fs: fix error code in f2fs_ioc_start_atomic_write() Dan Carpenter
2022-05-11 16:46 ` Daeho Jeong via Linux-f2fs-devel
@ 2022-05-11 17:37 ` Jaegeuk Kim
2022-05-12 9:20 ` Dan Carpenter
1 sibling, 1 reply; 5+ messages in thread
From: Jaegeuk Kim @ 2022-05-11 17:37 UTC (permalink / raw)
To: Dan Carpenter; +Cc: kernel-janitors, Daeho Jeong, linux-f2fs-devel
Hi Dan,
Thank you for the fix. If you don't mind, can I integrate this fix into
the original patch which is in -next?
Thanks,
On 05/11, Dan Carpenter wrote:
> Return an error code if f2fs_iget() fails. Currently it returns
> success.
>
> Fixes: 3d7ad9c30607 ("f2fs: change the current atomic write way")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> fs/f2fs/file.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 79d1a20fbda9..cd768fadfd67 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp)
> pinode = f2fs_iget(inode->i_sb, fi->i_pino);
> if (IS_ERR(pinode)) {
> f2fs_up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
> + ret = PTR_ERR(pinode);
> goto out;
> }
>
> --
> 2.35.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: fix error code in f2fs_ioc_start_atomic_write()
2022-05-11 17:37 ` Jaegeuk Kim
@ 2022-05-12 9:20 ` Dan Carpenter
2022-05-12 16:15 ` Jaegeuk Kim
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2022-05-12 9:20 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: kernel-janitors, Daeho Jeong, linux-f2fs-devel
On Wed, May 11, 2022 at 10:37:57AM -0700, Jaegeuk Kim wrote:
> Hi Dan,
>
> Thank you for the fix. If you don't mind, can I integrate this fix into
> the original patch which is in -next?
>
Yeah, that's not a problem. Feel free.
regards,
dan carpenter
> Thanks,
>
> On 05/11, Dan Carpenter wrote:
> > Return an error code if f2fs_iget() fails. Currently it returns
> > success.
> >
> > Fixes: 3d7ad9c30607 ("f2fs: change the current atomic write way")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > fs/f2fs/file.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > index 79d1a20fbda9..cd768fadfd67 100644
> > --- a/fs/f2fs/file.c
> > +++ b/fs/f2fs/file.c
> > @@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp)
> > pinode = f2fs_iget(inode->i_sb, fi->i_pino);
> > if (IS_ERR(pinode)) {
> > f2fs_up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
> > + ret = PTR_ERR(pinode);
> > goto out;
> > }
> >
> > --
> > 2.35.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: fix error code in f2fs_ioc_start_atomic_write()
2022-05-12 9:20 ` Dan Carpenter
@ 2022-05-12 16:15 ` Jaegeuk Kim
0 siblings, 0 replies; 5+ messages in thread
From: Jaegeuk Kim @ 2022-05-12 16:15 UTC (permalink / raw)
To: Dan Carpenter; +Cc: kernel-janitors, Daeho Jeong, linux-f2fs-devel
On 05/12, Dan Carpenter wrote:
> On Wed, May 11, 2022 at 10:37:57AM -0700, Jaegeuk Kim wrote:
> > Hi Dan,
> >
> > Thank you for the fix. If you don't mind, can I integrate this fix into
> > the original patch which is in -next?
> >
>
> Yeah, that's not a problem. Feel free.
Thank you~
>
> regards,
> dan carpenter
>
> > Thanks,
> >
> > On 05/11, Dan Carpenter wrote:
> > > Return an error code if f2fs_iget() fails. Currently it returns
> > > success.
> > >
> > > Fixes: 3d7ad9c30607 ("f2fs: change the current atomic write way")
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > ---
> > > fs/f2fs/file.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > > index 79d1a20fbda9..cd768fadfd67 100644
> > > --- a/fs/f2fs/file.c
> > > +++ b/fs/f2fs/file.c
> > > @@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp)
> > > pinode = f2fs_iget(inode->i_sb, fi->i_pino);
> > > if (IS_ERR(pinode)) {
> > > f2fs_up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
> > > + ret = PTR_ERR(pinode);
> > > goto out;
> > > }
> > >
> > > --
> > > 2.35.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-05-12 16:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-11 13:20 [f2fs-dev] [PATCH] f2fs: fix error code in f2fs_ioc_start_atomic_write() Dan Carpenter
2022-05-11 16:46 ` Daeho Jeong via Linux-f2fs-devel
2022-05-11 17:37 ` Jaegeuk Kim
2022-05-12 9:20 ` Dan Carpenter
2022-05-12 16:15 ` Jaegeuk Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).