From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30FCDC433EF for ; Tue, 31 May 2022 20:15:47 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nw8HI-0001an-RK; Tue, 31 May 2022 20:15:45 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nw8HH-0001ac-Qz for linux-f2fs-devel@lists.sourceforge.net; Tue, 31 May 2022 20:15:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fUA7TJ2clMSFJ5rR8iYkdDB6a7yjJ3rXsQMdNpe/NNM=; b=Jcw+mhzQBKbgvGoTjBjt1169CG BNeXs6c/kaSR3Iah8TkRLiQilvx4VnUAarbYJ+g4EW2yVQqX9pS2Kuzl11HTzVcdYMguy4TVCZcVm 6/OZbdi3cOSdbc+LgbfyTof8qU3rUO0iphK4JIIu+KGs01e0tRXoqMJnBFFnqTqBzSMA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fUA7TJ2clMSFJ5rR8iYkdDB6a7yjJ3rXsQMdNpe/NNM=; b=SWfgK7AjqQEfErn4D4VQ6wA/hS +5ImjB20JGloPbyLf5HeUytc3XFjc2jnK1f+YYZitCLShpHgKFFeOYMdIIlQfxxxLXLzMt9xCVP/1 aVyhWS3tHflq0F1b7s1QVQpZekonaXfltxqsmraWTwcSjRJdzB8o161jvxuNBuDTVuD0=; Received: from sin.source.kernel.org ([145.40.73.55]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nw8HD-00C7QP-AI for linux-f2fs-devel@lists.sourceforge.net; Tue, 31 May 2022 20:15:44 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 4D1E9CE177F; Tue, 31 May 2022 20:15:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DB84C385A9; Tue, 31 May 2022 20:15:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654028122; bh=BFanbqOhtsJfdsE0t1WgCWXCbNVZbf6rMzjnBDejGko=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HTExhv82IFTfAX9On7K7/OBjqiJbZE6iPiLVuvD4xx82SDjLP9P74u8VjQUVFAjYl ipwq3tQzLRu4WCAoOB9JIjZvP0W8r6gnw6qcSNx7RiF1RvUBlur0Axirx9QoHRO4xQ mIa5TUL/xyxubDp51oQbQjoddfa2708yaXR7QhTbDyXUch3iGCMttd33LEyVHbjjT9 gq98XIBn/tlCG0GYwnLfHur6a6GxGG911xMwSm8K4GCtR51UsL7NzWgvbXkVlJGppV og6hGBkGa9DhTnwHtJ5GGoTvNVvSzmeqXzaqVn+W2rpE3QZ9cgjwzIA2RaKx8qJWFD Xo/D5sYinC2bg== Date: Tue, 31 May 2022 13:15:20 -0700 From: Jaegeuk Kim To: Christoph Hellwig Message-ID: References: <20220527205955.3251982-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1nw8HD-00C7QP-AI Subject: Re: [f2fs-dev] [PATCH] f2fs: add sysfs entry to avoid FUA X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Biggers , linux-block@vger.kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 05/27, Christoph Hellwig wrote: > On Fri, May 27, 2022 at 06:06:08PM -0700, Jaegeuk Kim wrote: > > I think there's still some benefit to use FUA such as small chunk writes > > for checkpoint. > > Did you measure if there is? Because some SSDs basically implemented > FUA as an implied flush after the write, in which case it would not > really help there either (but also not hurt). > > But as the previous two maintainers already said - this needs quirking > at the driver layer, not in the submitter. Thanks, I indeed measured this using UFS, and it turned out cache_flush is better than FUA all the time like this. Hence, I posted a quirk [1]. Write(us/KB) 4 64 256 1024 2048 FUA 873.792 754.604 995.624 1011.67 1067.99 CACHE_FLUSH 824.703 712.98 800.307 1019.5 1037.37 [1] https://lore.kernel.org/linux-scsi/20220531201053.3300018-1-jaegeuk@kernel.org/T/#u _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel