From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 2/2 v2] f2fs_io: add dsync option for write
Date: Sun, 19 Jun 2022 15:05:35 -0700 [thread overview]
Message-ID: <Yq+dr6tzKkPuwck5@google.com> (raw)
In-Reply-To: <20220615165610.1074259-2-jaegeuk@kernel.org>
This adds a write option having O_DIRECT | O_DSYNC.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
Change log from v1:
- update man page
man/f2fs_io.8 | 3 +++
tools/f2fs_io/f2fs_io.c | 5 ++++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/man/f2fs_io.8 b/man/f2fs_io.8
index 8a2c37489939..af7325add388 100644
--- a/man/f2fs_io.8
+++ b/man/f2fs_io.8
@@ -76,6 +76,9 @@ buffered I/O
.TP
.B dio
direct I/O
+.TP
+.B dsync
+direct I/O with O_DSYNC
.RE
.TP
\fBread\fR \fI[chunk_size in 4kb] [offset in chunk_size] [count] [IO] [print_nbytes] [file_path]\fR
diff --git a/tools/f2fs_io/f2fs_io.c b/tools/f2fs_io/f2fs_io.c
index 2f0fc7b25d41..e7359836b126 100644
--- a/tools/f2fs_io/f2fs_io.c
+++ b/tools/f2fs_io/f2fs_io.c
@@ -508,7 +508,8 @@ static void do_erase(int argc, char **argv, const struct cmd_desc *cmd)
" rand : random numbers\n" \
"IO can be\n" \
" buffered : buffered IO\n" \
-" dio : direct IO\n" \
+" dio : O_DIRECT\n" \
+" dsync : O_DIRECT | O_DSYNC\n" \
" osync : O_SYNC\n" \
" atomic_commit : atomic write & commit\n" \
" atomic_abort : atomic write & abort\n" \
@@ -552,6 +553,8 @@ static void do_write(int argc, char **argv, const struct cmd_desc *cmd)
if (!strcmp(argv[5], "dio"))
flags |= O_DIRECT;
+ else if (!strcmp(argv[5], "dsync"))
+ flags |= O_DIRECT | O_DSYNC;
else if (!strcmp(argv[5], "osync"))
flags |= O_SYNC;
else if (!strcmp(argv[5], "atomic_commit"))
--
2.36.1.476.g0c4daa206d-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-06-19 22:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 16:56 [f2fs-dev] [PATCH 1/2] android_config: add time headers Jaegeuk Kim
2022-06-15 16:56 ` [f2fs-dev] [PATCH 2/2] f2fs_io: add dsync option for write Jaegeuk Kim
2022-06-19 0:20 ` Chao Yu
2022-06-19 22:05 ` Jaegeuk Kim [this message]
2022-06-20 1:38 ` [f2fs-dev] [PATCH 2/2 v2] " Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yq+dr6tzKkPuwck5@google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).