From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F4B4C433EF for ; Thu, 16 Jun 2022 17:17:20 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1o1t7P-0004EZ-Iu; Thu, 16 Jun 2022 17:17:18 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o1t7O-0004ES-4Y for linux-f2fs-devel@lists.sourceforge.net; Thu, 16 Jun 2022 17:17:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DVdQwcUY0JDQ8cBcdIfuE++4LvonwdvjtJqLWdGizvg=; b=fV8RJmdeDvuXF3pFz14raVwtWn jAIFV61rR82m2VSB9zEFypc1nkctxEIccjUfLLOlxWWWMP72Bwn8bdjokbf5+tlTapw9aBKnwJf4d VKFQbvuPByPth40F4Y9dVr5gxOWhmoHDCoQZzU1IG0Q8JNDWOeQRRvXaALZl3RGVZAvA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DVdQwcUY0JDQ8cBcdIfuE++4LvonwdvjtJqLWdGizvg=; b=miupSFOr3YIwgY3K9rHIr1dySJ OGr9u89ydOTFKjsuVD1WF3aH4F8tLijLcSVReSyLUTfPTz22lnoTlMLCauEQx6J6nWBdw50TKrN4K qTtoo1/mDUS0YHSSrywplYTkiId8dYuEcpP14NnnBou31uSrM1mK/6JMnXrUp4zxzWno=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1o1t7M-004LjR-1m for linux-f2fs-devel@lists.sourceforge.net; Thu, 16 Jun 2022 17:17:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A342E61741; Thu, 16 Jun 2022 17:17:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F21ECC3411A; Thu, 16 Jun 2022 17:17:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655399830; bh=/j2wNePK1Xela/ahc9maWQOf8Boi5z4O1qLLoB/erZQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qtP4Rd/DGftGcqRvB2uDXrBhekVnUPl079+2ntnFvoUP/+KvxJHsknQ/CRao6qD2L Q309nF51FH9ewXFUIllr6jGPXfj85E1HJJWYLEuajdI38uRTgFT/bFACRTIFPhBdsn Ip/RcPhN+kjp23Z+4X1rAYxUdKcJjejncCfzKsqs4GILiXvI7TXX3nDzTKWnLedbGb f/3W+OV6QFPd1cYzAYztHl8LGP2mekOR/IEdRtRMSYvYNMRpQu/T9GtBu5KGxNzqYa cXcYTaMRaFKlAAutDMnn7cEPdP4hoOPmFqvteVE3Q4tW0bYhUNOEcnxljrwRxMpL4I tGDQNGWGgTCSw== Date: Thu, 16 Jun 2022 10:17:08 -0700 From: Jaegeuk Kim To: Dylan Chang Message-ID: References: <20220616035806.1663-1-dylan.chang@oneplus.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220616035806.1663-1-dylan.chang@oneplus.com> X-Headers-End: 1o1t7M-004LjR-1m Subject: Re: [f2fs-dev] [PATCH] Fix file too large causing overflow X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dylan Chang , linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 06/16, Dylan Chang wrote: > fibmap: Fix file too large causing file_pos overflow > > fibmap show file_pos with incorrectly value when passing a large file. > > Before: > > ----------------file info------------------- > /data/media/0/data1 : > -------------------------------------------- > dev [254:18] > ino [0x 4db1 : 19889] > mode [0x 81b0 : 33200] > nlink [0x 1 : 1] > uid [0x 280e : 10254] > gid [0x 3ff : 1023] > size [0x1b3dca314 : 7312548628] > blksize [0x 1000 : 4096] > blocks [0x da2530 : 14296368] > -------------------------------------------- > > file_pos start_blk end_blk blks > 0 3197602 3198463 862 > 3530752 3197509 3197509 1 > 3534848 3197557 3197578 22 > 3624960 3198464 3396701 198238 > 815607808 3396703 3632480 235778 > 1781354496 3632482 3652095 19614 > 1861693440 3396702 3396702 1 > 1861697536 3632481 3632481 1 > 1861701632 1514948 1514948 1 > 1861705728 1518774 1518774 1 > 1861709824 2543104 2543125 22 > ... > 1862111232 2457813 2457813 1 > 1862115328 3652096 3878168 226073 > -1506856960 3878170 4133725 255556 > -460099584 1510048 1510052 5 > > Patched: > ----------------file info------------------- > /data/media/0/data1 : > -------------------------------------------- > dev [254:18] > ino [0x 4db1 : 19889] > mode [0x 81b0 : 33200] > nlink [0x 1 : 1] > uid [0x 280e : 10254] > gid [0x 3ff : 1023] > size [0x1b3dca314 : 7312548628] > blksize [0x 1000 : 4096] > blocks [0x da2530 : 14296368] > -------------------------------------------- > > file_pos start_blk end_blk blks > 0 3197602 3198463 862 > 3530752 3197509 3197509 1 > 3534848 3197557 3197578 22 > 3624960 3198464 3396701 198238 > 815607808 3396703 3632480 235778 > 1781354496 3632482 3652095 19614 > 1861693440 3396702 3396702 1 > 1861697536 3632481 3632481 1 > 1861701632 1514948 1514948 1 > 1861705728 1518774 1518774 1 > 1861709824 2543104 2543125 22 > ... > 1862111232 2457813 2457813 1 > 1862115328 3652096 3878168 226073 > 2788110336 3878170 4133725 255556 > 3834867712 1510048 1510052 5 > > Change-Id: Ic2486e25ea03114d4dbf3651650c6a2399db0714 > Signed-off-by: Dylan Chang > --- > tools/fibmap.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/fibmap.c b/tools/fibmap.c > index 3238f29..3217600 100644 > --- a/tools/fibmap.c > +++ b/tools/fibmap.c > @@ -47,7 +47,7 @@ > #endif > > struct file_ext { > - __u32 f_pos; > + __u64 f_pos; > __u32 start_blk; > __u32 end_blk; > __u32 blk_count; > @@ -56,9 +56,9 @@ struct file_ext { > void print_ext(struct file_ext *ext) > { > if (ext->end_blk == 0) > - printf("%8d %8d %8d %8d\n", ext->f_pos, 0, 0, ext->blk_count); > + printf("%8llu %8lu %8lu %8lu\n", ext->f_pos, 0, 0, ext->blk_count); I had to fix unrelated changes from %8d to %8lu. Please check it https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git/commit/?h=dev-test&id=74f81f441ce24dd47cfe68e6fb336e0142bf4217 > else > - printf("%8d %8d %8d %8d\n", ext->f_pos, ext->start_blk, > + printf("%8llu %8lu %8lu %8lu\n", ext->f_pos, ext->start_blk, > ext->end_blk, ext->blk_count); > } > > @@ -209,7 +209,7 @@ int main(int argc, char *argv[]) > ext.blk_count++; > } else { > print_ext(&ext); > - ext.f_pos = i * st.st_blksize; > + ext.f_pos = (__u64)i * st.st_blksize; > ext.start_blk = blknum; > ext.end_blk = blknum; > ext.blk_count = 1; > -- > 2.17.1 > > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel