From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC9D5C43334 for ; Tue, 28 Jun 2022 18:17:47 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1o6FmR-0000Uo-4E; Tue, 28 Jun 2022 18:17:44 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o6FmQ-0000Ui-Fj for linux-f2fs-devel@lists.sourceforge.net; Tue, 28 Jun 2022 18:17:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Wlng6qnxVhsHvsfvYeUOQ0+lCu2yhgGadTMyXmAtRhg=; b=GYS/YfTbCdxvF+lkxFvg/i4rrr Sexqx/uusxpPM4m8piauqxr7yxgrAj6opHb8YK9mWflJ571hYusLkGBpe/BTnYtVAGUWbuByumodL BEihyeOPkx/nYCGiA9fubQihPFWUA/0eoBJ/HbrSAgD/+kAPB8LJEAAWhFR3Jfo7w7Mo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Wlng6qnxVhsHvsfvYeUOQ0+lCu2yhgGadTMyXmAtRhg=; b=HXRL4Wr9kHAecQNzmlG4oS8GZ+ 0CNZV7LTcVkdzPg6UxHqOZrjz8+LPGtQdq0OMTfLucXL3Tq6338n97gPatw9195QyPyoZZ1MJQl1c au+oeaX08FIbsBP4ISASd3eEtG1VoSrfRi5V7BgXVNRgkiuGK6HurY8EYE/+xomia84Y=; Received: from ams.source.kernel.org ([145.40.68.75]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1o6FmO-00HLTH-Lo for linux-f2fs-devel@lists.sourceforge.net; Tue, 28 Jun 2022 18:17:43 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 63B23B81DDC for ; Tue, 28 Jun 2022 18:17:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17DBAC3411D; Tue, 28 Jun 2022 18:17:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656440248; bh=1mYPax67Vy344sMoUjFN0Cv1OigzNgE5dciQ5Kmkfrk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ClP6eYW6A6yORbffOtc5AaToFUCpqZv0Xbmw5oSIYxYr7UM6MLmpzaEnAI6fwccdW 0JlzdmjYaKscQvfn9maXdcVfv5+PIor4050cjmuULw2eJpPb8n6pNHJxBaZVWJNqdT rEZgB6IWyQRPEHrfn3msNQQkYdarVf38v/qhaRVWIT0QfkRI4Mq70++JP0+idEs/mV axeDtE1qjCl0eEWnC6/t67Y7/g2plGOu0hEcHuIda4zluDjqUisbPrOiWwlJ6cM77i D+Ns1hvHa9IxFpkYakutlqQh2+HRXGvy1bH/VnWF52BjuMXQClsCWbw06RQmrPFQQh jMLQrI+uTJQjQ== Date: Tue, 28 Jun 2022 11:17:26 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20220617223106.3517374-1-jaegeuk@kernel.org> <20220617223106.3517374-2-jaegeuk@kernel.org> <27138a10-a6b2-edad-1985-687a95b9039b@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1o6FmO-00HLTH-Lo Subject: Re: [f2fs-dev] [PATCH 2/3] f2fs: run GCs synchronously given user requests X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 06/28, Chao Yu wrote: > On 2022/6/23 0:58, Jaegeuk Kim wrote: > > On 06/22, Chao Yu wrote: > > > On 2022/6/20 6:34, Jaegeuk Kim wrote: > > > > On 06/19, Chao Yu wrote: > > > > > On 2022/6/18 6:31, Jaegeuk Kim wrote: > > > > > > When users set GC_URGENT or GC_MID, they expected to do GCs right away. > > > > > > But, there's a condition to bypass it. Let's indicate we need to do now > > > > > > in the thread. > > > > > > > > > > .should_migrate_blocks is used to force migrating blocks in full > > > > > section, so what is the condition here? GC should not never select > > > > > a full section, right? > > > > > > > > I think it'll move a full section given .victim_segno is not NULL_SEGNO, > > > > as __get_victim will give a dirty segment all the time. wdyt? > > > > > > However, in gc_thread_fun() victim_segno is NULL_SEGNO all the time. > > > > What do you mean? The gc_thread thread sets NULL_SEGNO, which prevents > > from selecting the full section. But, f2fs_ioc_flush_device will set the > > segno to move, and f2fs_resize_fs calls do_garbage_collect directly. > > Yes, but I didn't get why this patch updates .should_migrate_blocks for > gc_thread_func() case? If this is added to avoid breaking from below condition, > I guess it's not necessary, since victim selected from gc_thread_func() will > always be dirty, so get_valid_blocks(sbi, segno, true) == BLKS_PER_SEC(sbi) > will be false anyway? or am I missing something? I lost the previous test. :( IIRC, once I set GC_URGENT_HIGH, I've seen that f2fs_gc couldn't migrate blocks quickly, even or never succeeded. And, I also suspected the below condition tho, if I give force_migrate, it simply worked. I just realized that that may be caused by large sections having non-2MB-aligned zone capacity. Will check it again, as I found some buggy flows in that case. > > /* > * stop BG_GC if there is not enough free sections. > * Or, stop GC if the segment becomes fully valid caused by > * race condition along with SSR block allocation. > */ > if ((gc_type == BG_GC && has_not_enough_free_secs(sbi, 0, 0)) || > (!force_migrate && get_valid_blocks(sbi, segno, true) == > BLKS_PER_SEC(sbi))) > return submitted; > > Thanks, > > > > > > > > > I guess .should_migrate_blocks should only be set to true for > > > F2FS_IOC_FLUSH_DEVICE/F2FS_IOC_RESIZE_FS case? rather than GC_URGENT or GC_MID > > > case? See commit 7dede88659df ("f2fs: fix to allow migrating fully valid segment"). > > > > > > Thanks, > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > > > > Signed-off-by: Jaegeuk Kim > > > > > > --- > > > > > > fs/f2fs/gc.c | 8 ++++++-- > > > > > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > > > > > > index d5fb426e0747..f4aa3c88118b 100644 > > > > > > --- a/fs/f2fs/gc.c > > > > > > +++ b/fs/f2fs/gc.c > > > > > > @@ -37,7 +37,6 @@ static int gc_thread_func(void *data) > > > > > > unsigned int wait_ms; > > > > > > struct f2fs_gc_control gc_control = { > > > > > > .victim_segno = NULL_SEGNO, > > > > > > - .should_migrate_blocks = false, > > > > > > .err_gc_skipped = false }; > > > > > > wait_ms = gc_th->min_sleep_time; > > > > > > @@ -113,7 +112,10 @@ static int gc_thread_func(void *data) > > > > > > sbi->gc_mode == GC_URGENT_MID) { > > > > > > wait_ms = gc_th->urgent_sleep_time; > > > > > > f2fs_down_write(&sbi->gc_lock); > > > > > > + gc_control.should_migrate_blocks = true; > > > > > > goto do_gc; > > > > > > + } else { > > > > > > + gc_control.should_migrate_blocks = false; > > > > > > } > > > > > > if (foreground) { > > > > > > @@ -139,7 +141,9 @@ static int gc_thread_func(void *data) > > > > > > if (!foreground) > > > > > > stat_inc_bggc_count(sbi->stat_info); > > > > > > - sync_mode = F2FS_OPTION(sbi).bggc_mode == BGGC_MODE_SYNC; > > > > > > + sync_mode = F2FS_OPTION(sbi).bggc_mode == BGGC_MODE_SYNC || > > > > > > + sbi->gc_mode == GC_URGENT_HIGH || > > > > > > + sbi->gc_mode == GC_URGENT_MID; > > > > > > /* foreground GC was been triggered via f2fs_balance_fs() */ > > > > > > if (foreground) _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel