From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Guowei Du <duguoweisz@gmail.com>
Cc: linux-kernel@vger.kernel.org, duguowei <duguowei@xiaomi.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: modify task name prefix
Date: Thu, 21 Jul 2022 19:43:17 -0700 [thread overview]
Message-ID: <YtoOxTyWPFUpw/Y0@google.com> (raw)
In-Reply-To: <20220718081038.2279-1-duguoweisz@gmail.com>
On 07/18, Guowei Du wrote:
> From: duguowei <duguowei@xiaomi.com>
>
> If there are more than one f2fs sbi, there will be more
> discard threads. But the comm is too long to show dev
> minor. So, change the default prefix of thread from
> "f2fs_discard" to "f2fs_dcd".
That looks quite unreadable. What about unmap?
>
> Before:
> $ ps -e | grep f2fs
> 1628 ? 00:00:00 f2fs_ckpt-7:10
> 1629 ? 00:00:00 f2fs_flush-7:10
> 1630 ? 00:00:00 f2fs_discard-7:
> 1631 ? 00:00:00 f2fs_gc-7:10
> 2030 ? 00:00:00 f2fs_ckpt-7:27
> 2031 ? 00:00:00 f2fs_flush-7:27
> 2032 ? 00:00:00 f2fs_discard-7:
> 2033 ? 00:00:00 f2fs_gc-7:27
>
> After:
> $ ps -e | grep f2fs
> 1628 ? 00:00:00 f2fs_ckpt-7:10
> 1629 ? 00:00:00 f2fs_flush-7:10
> 1630 ? 00:00:00 f2fs_dcd-7:10
> 1631 ? 00:00:00 f2fs_gc-7:10
> 2030 ? 00:00:00 f2fs_ckpt-7:27
> 2031 ? 00:00:00 f2fs_flush-7:27
> 2032 ? 00:00:00 f2fs_dcd-7:27
> 2033 ? 00:00:00 f2fs_gc-7:27
>
> Signed-off-by: duguowei <duguowei@xiaomi.com>
> ---
> fs/f2fs/segment.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 874c1b9c41a2..2eeefcbe62db 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -2018,7 +2018,7 @@ int f2fs_start_discard_thread(struct f2fs_sb_info *sbi)
> return 0;
>
> dcc->f2fs_issue_discard = kthread_run(issue_discard_thread, sbi,
> - "f2fs_discard-%u:%u", MAJOR(dev), MINOR(dev));
> + "f2fs_dcd-%u:%u", MAJOR(dev), MINOR(dev));
> if (IS_ERR(dcc->f2fs_issue_discard))
> err = PTR_ERR(dcc->f2fs_issue_discard);
>
> --
> 2.36.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-07-22 2:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 8:10 [f2fs-dev] [PATCH] f2fs: modify task name prefix Guowei Du
2022-07-22 2:43 ` Jaegeuk Kim [this message]
2022-07-24 15:26 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtoOxTyWPFUpw/Y0@google.com \
--to=jaegeuk@kernel.org \
--cc=duguowei@xiaomi.com \
--cc=duguoweisz@gmail.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).