From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Yufen Yu <yuyufen@huawei.com>
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: get rid of f2fs_inode_synced from f2fs_iget
Date: Thu, 21 Jul 2022 19:53:30 -0700 [thread overview]
Message-ID: <YtoRKnBpmxxGkbv2@google.com> (raw)
In-Reply-To: <20220721045329.2155449-1-yuyufen@huawei.com>
On 07/21, Yufen Yu wrote:
> If f2fs_iget cannot search inode from inode cache, it will read
> the inode from disk. The processing of read from disk and init inode
> should not dirty the inode, as the commit 530e07042002 ("f2fs:
> don't mark compressed inode dirty during f2fs_iget()").
f2fs_truncate can make this?
552 if (file_should_truncate(inode) &&
553 !is_sbi_flag_set(sbi, SBI_POR_DOING)) {
554 ret = f2fs_truncate(inode);
555 if (ret)
556 goto bad_inode;
>
> Thus, we can remove the unnecessary f2fs_inode_synced().
>
> Signed-off-by: Yufen Yu <yuyufen@huawei.com>
> ---
> fs/f2fs/inode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> index fc55f5bd1fcc..ce87b66c6dfe 100644
> --- a/fs/f2fs/inode.c
> +++ b/fs/f2fs/inode.c
> @@ -562,7 +562,6 @@ struct inode *f2fs_iget(struct super_block *sb, unsigned long ino)
> return inode;
>
> bad_inode:
> - f2fs_inode_synced(inode);
> iget_failed(inode);
> trace_f2fs_iget_exit(inode, ret);
> return ERR_PTR(ret);
> --
> 2.31.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-07-22 2:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 4:53 [f2fs-dev] [PATCH] f2fs: get rid of f2fs_inode_synced from f2fs_iget Yufen Yu via Linux-f2fs-devel
2022-07-22 2:53 ` Jaegeuk Kim [this message]
2022-07-24 13:48 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtoRKnBpmxxGkbv2@google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=yuyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).