From: Jaegeuk Kim <jaegeuk@kernel.org>
To: studentxswpy@163.com
Cc: Hacash Robot <hacashRobot@santino.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH -next] f2fs: Replace kmalloc() with f2fs_kmalloc
Date: Wed, 3 Aug 2022 20:56:35 -0700 [thread overview]
Message-ID: <YutDc6n08xw0iG+3@google.com> (raw)
In-Reply-To: <20220801092202.3134668-1-studentxswpy@163.com>
On 08/01, studentxswpy@163.com wrote:
> From: Xie Shaowen <studentxswpy@163.com>
>
> replace kmalloc with f2fs_kmalloc to keep f2fs code consistency.
>
> Reported-by: Hacash Robot <hacashRobot@santino.com>
> Signed-off-by: Xie Shaowen <studentxswpy@163.com>
> ---
> fs/f2fs/dir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
> index d5bd7932fb64..712b51f69c04 100644
> --- a/fs/f2fs/dir.c
> +++ b/fs/f2fs/dir.c
> @@ -232,7 +232,7 @@ static int f2fs_match_ci_name(const struct inode *dir, const struct qstr *name,
> if (WARN_ON_ONCE(!fscrypt_has_encryption_key(dir)))
> return -EINVAL;
>
> - decrypted_name.name = kmalloc(de_name_len, GFP_KERNEL);
> + decrypted_name.name = f2fs_kmalloc(de_name_len, GFP_KERNEL);
Please fix the build breakage.
fyi;
static inline void *f2fs_kmalloc(struct f2fs_sb_info *sbi, size_t size, gfp_t flags)
> if (!decrypted_name.name)
> return -ENOMEM;
> res = fscrypt_fname_disk_to_usr(dir, 0, 0, &encrypted_name,
> --
> 2.25.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-08-04 3:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 9:22 [f2fs-dev] [PATCH -next] f2fs: Replace kmalloc() with f2fs_kmalloc studentxswpy
2022-08-01 18:23 ` Christoph Hellwig
2022-08-02 1:42 ` Joe Perches
2022-08-04 3:54 ` Jaegeuk Kim
2022-08-04 13:50 ` Chao Yu
2022-08-04 3:56 ` Jaegeuk Kim [this message]
2022-08-07 8:29 ` kernel test robot
2022-08-07 8:29 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YutDc6n08xw0iG+3@google.com \
--to=jaegeuk@kernel.org \
--cc=hacashRobot@santino.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=studentxswpy@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).