From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A3AFC6FA83 for ; Mon, 12 Sep 2022 15:38:13 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1oXlVV-0007kF-UE; Mon, 12 Sep 2022 15:38:10 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oXlVU-0007k9-Gn for linux-f2fs-devel@lists.sourceforge.net; Mon, 12 Sep 2022 15:38:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=47uBatIjhvwSWUFeOmpYoiXfxqt/miHgc+P7ZNsv/Ow=; b=FAhrOsYWDs5I0hNmGMJuoMl9aB OX6ssKiYftvpvHQr93xqf3m85l7v+uRGgEEY2VMRA1ypYDL7y0mLsDFdTn2ZZU+CMwsggNSoOzPjO uqsPsaLhW64bCutQJnEXBU+CCFTw9hBrE/+VDY8h/OpoO2I4TiRwYDlQxM/AQew1lKE0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=47uBatIjhvwSWUFeOmpYoiXfxqt/miHgc+P7ZNsv/Ow=; b=mvgxc2SiGO/gDz/GQmrC2AvTAd 7UDEleWoxFj4KpW7sWI2Ksfvg/QtcHiGGlkwSb5qr9IfyY1//hfRMvfsyS0IpbCent/J69wl6fG+N 9Y0mVV40297xUjqCWq6/bwv7gqOysW3P2fYWuqng6JDj0h9HLLtc2uFnbCh8gYKH8ejM=; Received: from ams.source.kernel.org ([145.40.68.75]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1oXlVg-0004Hy-84 for linux-f2fs-devel@lists.sourceforge.net; Mon, 12 Sep 2022 15:38:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 03D52B80D68; Mon, 12 Sep 2022 15:38:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A234C433D6; Mon, 12 Sep 2022 15:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662997080; bh=oxqqC71whU82K+lMvDngYtKvu3gWEOvauoFnwRSlPuI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q6FnABTA5i4SLOkkHKAXSp6F7n8kO/2lwpfNaB/0kXGFyYWEq7OVQt4anSllmoc9A LnxmTDok5aY+mdK+LaovQaRACzxyahDDplVCpWqBYSm8pHozW1TgLfTg8nT2G9r2H/ PG3VbZU2PIGx5VyUSi8iiaVjvGa1cEqyfOq1cQ+mKaYASiXPT7gM+4PM2GdbSSZ93T b0irWRDf8HkXgv9gvE+3qmvmpLmFcnH276eajOE60W8SuLQ3ckB0uDMVE3cpgttcfn 0Ls63zOTnuSABq0VYuw/2prRE5ejjmmgkeh6lMyyg0VWhOImTwJRnmgjJQiRoCsqKP +w/QWGhyWAOlg== Date: Mon, 12 Sep 2022 08:37:58 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20220908105334.98572-1-chao@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220908105334.98572-1-chao@kernel.org> X-Headers-End: 1oXlVg-0004Hy-84 Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to detect obsolete inner inode during fill_super() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: syzbot+775a3440817f74fddb8c@syzkaller.appspotmail.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 09/08, Chao Yu wrote: > Sometimes we can get a cached meta_inode which has no aops yet. Let's set it > all the time to fix the below panic. > > Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 > Mem abort info: > ESR = 0x0000000086000004 > EC = 0x21: IABT (current EL), IL = 32 bits > SET = 0, FnV = 0 > EA = 0, S1PTW = 0 > FSC = 0x04: level 0 translation fault > user pgtable: 4k pages, 48-bit VAs, pgdp=0000000109ee4000 > [0000000000000000] pgd=0000000000000000, p4d=0000000000000000 > Internal error: Oops: 86000004 [#1] PREEMPT SMP > Modules linked in: > CPU: 1 PID: 3045 Comm: syz-executor330 Not tainted 6.0.0-rc2-syzkaller-16455-ga41a877bc12d #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/22/2022 > pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : 0x0 > lr : folio_mark_dirty+0xbc/0x208 mm/page-writeback.c:2748 > sp : ffff800012783970 > x29: ffff800012783970 x28: 0000000000000000 x27: ffff800012783b08 > x26: 0000000000000001 x25: 0000000000000400 x24: 0000000000000001 > x23: ffff0000c736e000 x22: 0000000000000045 x21: 05ffc00000000015 > x20: ffff0000ca7403b8 x19: fffffc00032ec600 x18: 0000000000000181 > x17: ffff80000c04d6bc x16: ffff80000dbb8658 x15: 0000000000000000 > x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 > x11: ff808000083e9814 x10: 0000000000000000 x9 : ffff8000083e9814 > x8 : 0000000000000000 x7 : 0000000000000000 x6 : 0000000000000000 > x5 : ffff0000cbb19000 x4 : ffff0000cb3d2000 x3 : ffff0000cbb18f80 > x2 : fffffffffffffff0 x1 : fffffc00032ec600 x0 : ffff0000ca7403b8 > Call trace: > 0x0 > set_page_dirty+0x38/0xbc mm/folio-compat.c:62 > f2fs_update_meta_page+0x80/0xa8 fs/f2fs/segment.c:2369 > do_checkpoint+0x794/0xea8 fs/f2fs/checkpoint.c:1522 > f2fs_write_checkpoint+0x3b8/0x568 fs/f2fs/checkpoint.c:1679 > > The root cause is, quoted from Jaegeuk: > > It turned out there is a bug in reiserfs which doesn't free the root > inode (ino=2). That leads f2fs to find an ino=2 with the previous > superblock point used by reiserfs. That stale inode has no valid > mapping that f2fs can use, result in kernel panic. > > This patch adds sanity check in f2fs_iget() to avoid finding stale > inode during inner inode initialization. > > Cc: stable@vger.kernel.org > Reported-by: syzbot+775a3440817f74fddb8c@syzkaller.appspotmail.com > Signed-off-by: Jaegeuk Kim > Signed-off-by: Chao Yu > --- > fs/f2fs/inode.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index ccb29034af59..df1a82fbfaf2 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -493,6 +493,17 @@ struct inode *f2fs_iget_inner(struct super_block *sb, unsigned long ino) > struct inode *inode; > int ret = 0; > > + if (ino == F2FS_NODE_INO(sbi) || ino == F2FS_META_INO(sbi) || > + ino == F2FS_COMPRESS_INO(sbi)) { > + inode = ilookup(sb, ino); > + if (inode) { > + iput(inode); > + f2fs_err(sbi, "there is obsoleted inner inode %lu cached in hash table", > + ino); > + return ERR_PTR(-EFSCORRUPTED); Well, this does not indicate f2fs is corrupted. I'd rather expect to fix reiserfs instead of f2fs workaround which hides the bug. > + } > + } > + > inode = iget_locked(sb, ino); > if (!inode) > return ERR_PTR(-ENOMEM); > -- > 2.25.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel