From: Christoph Hellwig <hch@infradead.org>
To: Yangtao Li <frank.li@vivo.com>
Cc: liyangtao <11127627@bbktel.com>,
hanqi@vivo.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, jaegeuk@kernel.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: compress: fix to wait page writeback in f2fs_write_raw_pages()
Date: Mon, 20 Mar 2023 06:43:24 -0700 [thread overview]
Message-ID: <ZBhi/OSEak3QPryb@infradead.org> (raw)
In-Reply-To: <20230316093632.25929-1-frank.li@vivo.com>
On Thu, Mar 16, 2023 at 05:36:32PM +0800, Yangtao Li wrote:
> + if (PageWriteback(cc->rpages[i])) {
> + if (wbc->sync_mode != WB_SYNC_NONE)
> + f2fs_wait_on_page_writeback(cc->rpages[i],
> + DATA, true, true);
> + else
> + goto continue_unlock;
Please avoid the else by doing the goto in the branch:
if (PageWriteback(cc->rpages[i])) {
if (wbc->sync_mode == WB_SYNC_NONE)
goto continue_unlock;
f2fs_wait_on_page_writeback(cc->rpages[i], DATA, true,
true);
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2023-03-20 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 9:36 [f2fs-dev] [PATCH] f2fs: compress: fix to wait page writeback in f2fs_write_raw_pages() Yangtao Li via Linux-f2fs-devel
2023-03-20 13:43 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBhi/OSEak3QPryb@infradead.org \
--to=hch@infradead.org \
--cc=11127627@bbktel.com \
--cc=frank.li@vivo.com \
--cc=hanqi@vivo.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).