From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D6E5C7618E for ; Fri, 21 Apr 2023 19:20:56 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1ppwJS-0000g7-Dw; Fri, 21 Apr 2023 19:20:54 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ppwJR-0000g1-Nu for linux-f2fs-devel@lists.sourceforge.net; Fri, 21 Apr 2023 19:20:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bpmaIptl9dDh9yAGIGoWN1o28NbeUw4gkBHBUd6D/7k=; b=Ydsg29mYdfzhhAqads9q1EV9BF zsRs4q1dhxuEieLS1Quj8KA+wmmvgGzJBaNFOHQWCUwN/urPDMoJkLUgZw1e0cvwuIZl6MsPpXdv8 ISxCVyLOBSVEZMbBZX8F95Ei0r+rhQz0ENE4hr0cuRdTXUQG9uXfiti7Ny5vvai2V1a0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=bpmaIptl9dDh9yAGIGoWN1o28NbeUw4gkBHBUd6D/7k=; b=mTfT+3P7y0k389dPfFhH2eJS+Z /Eyx5HgM1C5bnatDdcM2h2H2X2ohLjlNXoVY+q6khQDxICrlXkGpK+vNBTmI//l72uP65UDjhNr69 CQVKjOLeBycR+6JG6v6Tlu3125uFQsE8RBstkX6GLbjLWUWEAQnM1tTQmUBFkbXEZFJo=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1ppwJR-00FDtq-DX for linux-f2fs-devel@lists.sourceforge.net; Fri, 21 Apr 2023 19:20:54 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BDCDD63E0C; Fri, 21 Apr 2023 19:20:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CCA5C433D2; Fri, 21 Apr 2023 19:20:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682104844; bh=wWIVV152heDSTzGxHtKa1x8+4IzsoyUehlTc8SPXpR0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dQdgmTqgPqnhOS0oj1RMYI3mGHcsg1Hx5B4RzKQHRComC2VLxhZUhMgCuxAADdNrW 0T3S3dnz+rl77xP8U5SAGNgmOUkrzp0JtTZdjmbbRlh+zANXO2PNAADL4nuQN/4hSP UxuzdPBkFJdFDhNmGR9VEY5+RJz8Hg6VboOP9dtfXrheKVWpR51liALk1XG332pQ8l UoCow/DGF/WES57XGj9YoOBrmDfNIv4p1F7fxFDiidQ5Z4ADpGdl8Co30sZVxXUtoZ TAIGuhx9NkRM+WeM88PRcKHy/ZR3gJpGccEAcQ4B8kROiX6+GgOsP+95FRcv2N+1dQ EB52MWCrG4+Bg== Date: Fri, 21 Apr 2023 12:20:42 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20230418060954.67585-1-hanqi@vivo.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1ppwJR-00FDtq-DX Subject: Re: [f2fs-dev] [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qi Han , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 04/21, Chao Yu wrote: > On 2023/4/18 14:09, Qi Han wrote: > > This comment make no sense and is in the wrong place, so let's > > remove it. > > > > Signed-off-by: Qi Han > > --- > > fs/f2fs/extent_cache.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c > > index 28b12553f2b3..1f6d7de35794 100644 > > --- a/fs/f2fs/extent_cache.c > > +++ b/fs/f2fs/extent_cache.c > > @@ -86,7 +86,6 @@ static bool __may_age_extent_tree(struct inode *inode) > > if (!test_opt(sbi, AGE_EXTENT_CACHE)) > > return false; > > - /* don't cache block age info for cold file */ > > if (is_inode_flag_set(inode, FI_COMPRESSED_FILE)) > > return false; > > Should move it here instead of removal? > > /* don't cache block age info for cold file */ Not worth to comment this, as the code is exactly saying that. > > > if (file_is_cold(inode)) _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel