* [f2fs-dev] [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree
@ 2023-04-18 6:09 Qi Han via Linux-f2fs-devel
2023-04-21 2:27 ` Chao Yu
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Qi Han via Linux-f2fs-devel @ 2023-04-18 6:09 UTC (permalink / raw)
To: jaegeuk, chao; +Cc: Qi Han, linux-kernel, linux-f2fs-devel
This comment make no sense and is in the wrong place, so let's
remove it.
Signed-off-by: Qi Han <hanqi@vivo.com>
---
fs/f2fs/extent_cache.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
index 28b12553f2b3..1f6d7de35794 100644
--- a/fs/f2fs/extent_cache.c
+++ b/fs/f2fs/extent_cache.c
@@ -86,7 +86,6 @@ static bool __may_age_extent_tree(struct inode *inode)
if (!test_opt(sbi, AGE_EXTENT_CACHE))
return false;
- /* don't cache block age info for cold file */
if (is_inode_flag_set(inode, FI_COMPRESSED_FILE))
return false;
if (file_is_cold(inode))
--
2.39.0
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree
2023-04-18 6:09 [f2fs-dev] [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree Qi Han via Linux-f2fs-devel
@ 2023-04-21 2:27 ` Chao Yu
2023-04-21 19:20 ` Jaegeuk Kim
2023-04-21 6:51 ` [f2fs-dev] [PATCH] f2fs: move wrong comment to right place " Qi Han via Linux-f2fs-devel
2023-04-24 18:10 ` [f2fs-dev] [PATCH] f2fs: remove unnessary comment " patchwork-bot+f2fs
2 siblings, 1 reply; 6+ messages in thread
From: Chao Yu @ 2023-04-21 2:27 UTC (permalink / raw)
To: Qi Han, jaegeuk; +Cc: linux-kernel, linux-f2fs-devel
On 2023/4/18 14:09, Qi Han wrote:
> This comment make no sense and is in the wrong place, so let's
> remove it.
>
> Signed-off-by: Qi Han <hanqi@vivo.com>
> ---
> fs/f2fs/extent_cache.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
> index 28b12553f2b3..1f6d7de35794 100644
> --- a/fs/f2fs/extent_cache.c
> +++ b/fs/f2fs/extent_cache.c
> @@ -86,7 +86,6 @@ static bool __may_age_extent_tree(struct inode *inode)
>
> if (!test_opt(sbi, AGE_EXTENT_CACHE))
> return false;
> - /* don't cache block age info for cold file */
> if (is_inode_flag_set(inode, FI_COMPRESSED_FILE))
> return false;
Should move it here instead of removal?
/* don't cache block age info for cold file */
> if (file_is_cold(inode))
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree
2023-04-21 2:27 ` Chao Yu
@ 2023-04-21 19:20 ` Jaegeuk Kim
2023-04-22 12:15 ` Chao Yu
0 siblings, 1 reply; 6+ messages in thread
From: Jaegeuk Kim @ 2023-04-21 19:20 UTC (permalink / raw)
To: Chao Yu; +Cc: Qi Han, linux-kernel, linux-f2fs-devel
On 04/21, Chao Yu wrote:
> On 2023/4/18 14:09, Qi Han wrote:
> > This comment make no sense and is in the wrong place, so let's
> > remove it.
> >
> > Signed-off-by: Qi Han <hanqi@vivo.com>
> > ---
> > fs/f2fs/extent_cache.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
> > index 28b12553f2b3..1f6d7de35794 100644
> > --- a/fs/f2fs/extent_cache.c
> > +++ b/fs/f2fs/extent_cache.c
> > @@ -86,7 +86,6 @@ static bool __may_age_extent_tree(struct inode *inode)
> > if (!test_opt(sbi, AGE_EXTENT_CACHE))
> > return false;
> > - /* don't cache block age info for cold file */
> > if (is_inode_flag_set(inode, FI_COMPRESSED_FILE))
> > return false;
>
> Should move it here instead of removal?
>
> /* don't cache block age info for cold file */
Not worth to comment this, as the code is exactly saying that.
>
> > if (file_is_cold(inode))
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree
2023-04-21 19:20 ` Jaegeuk Kim
@ 2023-04-22 12:15 ` Chao Yu
0 siblings, 0 replies; 6+ messages in thread
From: Chao Yu @ 2023-04-22 12:15 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: Qi Han, linux-kernel, linux-f2fs-devel
On 2023/4/22 3:20, Jaegeuk Kim wrote:
> On 04/21, Chao Yu wrote:
>> On 2023/4/18 14:09, Qi Han wrote:
>>> This comment make no sense and is in the wrong place, so let's
>>> remove it.
>>>
>>> Signed-off-by: Qi Han <hanqi@vivo.com>
>>> ---
>>> fs/f2fs/extent_cache.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
>>> index 28b12553f2b3..1f6d7de35794 100644
>>> --- a/fs/f2fs/extent_cache.c
>>> +++ b/fs/f2fs/extent_cache.c
>>> @@ -86,7 +86,6 @@ static bool __may_age_extent_tree(struct inode *inode)
>>> if (!test_opt(sbi, AGE_EXTENT_CACHE))
>>> return false;
>>> - /* don't cache block age info for cold file */
>>> if (is_inode_flag_set(inode, FI_COMPRESSED_FILE))
>>> return false;
>>
>> Should move it here instead of removal?
>>
>> /* don't cache block age info for cold file */
>
> Not worth to comment this, as the code is exactly saying that.
Correct.
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
>
>>
>>> if (file_is_cold(inode))
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [f2fs-dev] [PATCH] f2fs: move wrong comment to right place in __may_age_extent_tree
2023-04-18 6:09 [f2fs-dev] [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree Qi Han via Linux-f2fs-devel
2023-04-21 2:27 ` Chao Yu
@ 2023-04-21 6:51 ` Qi Han via Linux-f2fs-devel
2023-04-24 18:10 ` [f2fs-dev] [PATCH] f2fs: remove unnessary comment " patchwork-bot+f2fs
2 siblings, 0 replies; 6+ messages in thread
From: Qi Han via Linux-f2fs-devel @ 2023-04-21 6:51 UTC (permalink / raw)
To: jaegeuk, chao; +Cc: Qi Han, linux-kernel, linux-f2fs-devel
This code is commented in the wrong place, let's move it to the right
place.
Signed-off-by: Qi Han <hanqi@vivo.com>
---
fs/f2fs/extent_cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
index 28b12553f2b3..0ad769a822ac 100644
--- a/fs/f2fs/extent_cache.c
+++ b/fs/f2fs/extent_cache.c
@@ -86,9 +86,9 @@ static bool __may_age_extent_tree(struct inode *inode)
if (!test_opt(sbi, AGE_EXTENT_CACHE))
return false;
- /* don't cache block age info for cold file */
if (is_inode_flag_set(inode, FI_COMPRESSED_FILE))
return false;
+ /* don't cache block age info for cold file */
if (file_is_cold(inode))
return false;
--
2.39.0
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree
2023-04-18 6:09 [f2fs-dev] [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree Qi Han via Linux-f2fs-devel
2023-04-21 2:27 ` Chao Yu
2023-04-21 6:51 ` [f2fs-dev] [PATCH] f2fs: move wrong comment to right place " Qi Han via Linux-f2fs-devel
@ 2023-04-24 18:10 ` patchwork-bot+f2fs
2 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+f2fs @ 2023-04-24 18:10 UTC (permalink / raw)
To: Qi Han; +Cc: jaegeuk, linux-kernel, linux-f2fs-devel
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <jaegeuk@kernel.org>:
On Tue, 18 Apr 2023 14:09:54 +0800 you wrote:
> This comment make no sense and is in the wrong place, so let's
> remove it.
>
> Signed-off-by: Qi Han <hanqi@vivo.com>
> ---
> fs/f2fs/extent_cache.c | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- [f2fs-dev] f2fs: remove unnessary comment in __may_age_extent_tree
https://git.kernel.org/jaegeuk/f2fs/c/8375be2b6414
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-24 18:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-18 6:09 [f2fs-dev] [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree Qi Han via Linux-f2fs-devel
2023-04-21 2:27 ` Chao Yu
2023-04-21 19:20 ` Jaegeuk Kim
2023-04-22 12:15 ` Chao Yu
2023-04-21 6:51 ` [f2fs-dev] [PATCH] f2fs: move wrong comment to right place " Qi Han via Linux-f2fs-devel
2023-04-24 18:10 ` [f2fs-dev] [PATCH] f2fs: remove unnessary comment " patchwork-bot+f2fs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).