From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1851DC77B7A for ; Thu, 25 May 2023 22:36:22 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1q2JZD-0004Rr-CD; Thu, 25 May 2023 22:36:19 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q2JZ9-0004Rk-O5 for linux-f2fs-devel@lists.sourceforge.net; Thu, 25 May 2023 22:36:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=S1jXpluJP1PmULPfySuGZnbyqWKWmdGDXnqsQshg/YI=; b=GSz4EiYyyqR+b7Qj0pMz7ium4y 6k/x610pvev7yefZw7BAt3rLi/CZf4WegK1NqoZxbK14tpMZjYmvB3y+VWZ5ZJgmySodJvLdG0QAB 4lnUVfHCdB91GQ/yHecW7tIvqHgiBS8aNKXP5CGWqWlKtREuts/kHUIyfFPAzMuvwics=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=S1jXpluJP1PmULPfySuGZnbyqWKWmdGDXnqsQshg/YI=; b=LfjLEm29Shw2wLwbeVSuvvOBUu 1FKepMYOjufKWAdn0IhSglOOr+s0FrzlFo0a6NDfhfuFTp36UaklEe//TBWG7B6qXGOMu7mqhLvu3 rOK693/p4dv0wWMNx7pgbEtPkupgsbHi93HYHizLbD5y0vakILX/uzyL9+dwGyZUaozg=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1q2JZ9-002eYO-7e for linux-f2fs-devel@lists.sourceforge.net; Thu, 25 May 2023 22:36:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CF83264BB6; Thu, 25 May 2023 22:36:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15DA8C433D2; Thu, 25 May 2023 22:36:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685054169; bh=BcSYYg73TLn+z8kwYMwcwfRgiBCpnbMeDZWwBzOl5yc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ROhmLm4rvwOqwrgtl92QOpbpEGeedPRgoXYuDKFodAOCscUNDnEDcgH69CTODHacB CeLTbSfoH4xF+eOrywfZWTWVXFVVbqxzuIav6HmdJlizGeNGXYAV88k3aVfHiTa6Q5 54vZl0iJ4sjSjmLfXXIuj4qLjnjz3p6Y8+D8iN5/nIJ8/T5hVMVDeuUEwpI/trS9bn jBSL6QZKvC6rXZ0HCDAbq+0en5EA7c+UaZQaE+W/G7w4YPrRo4jIvz2LjOP3dQqB7o s1lahVzcr67ppJwazxiXh0RM6ViQZbtYG7XKzP0ulunmqV4v4FQG5+3t7DigWqbl8s FBj5eM8TRIzUA== Date: Thu, 25 May 2023 15:36:07 -0700 From: Jaegeuk Kim To: Chunhai Guo Message-ID: References: <20230524024204.13694-1-guochunhai@vivo.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230524024204.13694-1-guochunhai@vivo.com> X-Headers-End: 1q2JZ9-002eYO-7e Subject: Re: [f2fs-dev] [PATCH v8] fsck.f2fs: Detect and fix looped node chain efficiently X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-f2fs-devel@lists.sourceforge.net, frank.li@vivo.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 05/24, Chunhai Guo wrote: > find_fsync_inode() detect the looped node chain by comparing the loop > counter with free blocks. While it may take tens of seconds to quit when > the free blocks are large enough. We can use Floyd's cycle detection > algorithm to make the detection more efficient, and fix the issue by > filling a NULL address in the last node of the chain. > > Below is the log we encounter on a 256GB UFS storage and it takes about > 25 seconds to detect looped node chain. After changing the algorithm, it > takes about 20ms to finish the same job. > > [ 10.822904] fsck.f2fs: Info: version timestamp cur: 17, prev: 430 > [ 10.822949] fsck.f2fs: [update_superblock: 762] Info: Done to > update superblock > [ 10.822953] fsck.f2fs: Info: superblock features = 1499 : > encrypt verity extra_attr project_quota quota_ino casefold > [ 10.822956] fsck.f2fs: Info: superblock encrypt level = 0, salt = > 00000000000000000000000000000000 > [ 10.822960] fsck.f2fs: Info: total FS sectors = 59249811 (231444 > MB) > [ 35.852827] fsck.f2fs: detect looped node chain, > blkaddr:1114802, next:1114803 > [ 35.852842] fsck.f2fs: [f2fs_do_mount:3846] record_fsync_data > failed > [ 35.856106] fsck.f2fs: fsck.f2fs terminated by exit(255) > > Signed-off-by: Chunhai Guo > --- > v7 -> v8 : Reformat the code to reduce indention. > v6 -> v7 : Correct logic error to handle is_detecting return by > find_node_blk_fast(). > v5 -> v6 : Simplify the code by removing unnecessary retry logic. > v4 -> v5 : Use IS_INODE() to make the code more clear. > v3 -> v4 : Set c.bug_on with ASSERT_MSG() when issue is detected and fix > it only if c.fix_on is 1. > v2 -> v3 : Write inode with write_inode() to avoid chksum being broken. > v1 -> v2 : Fix looped node chain directly after it is detected. > --- > fsck/mount.c | 127 +++++++++++++++++++++++++++++++++++++++++++++------ > 1 file changed, 112 insertions(+), 15 deletions(-) > > diff --git a/fsck/mount.c b/fsck/mount.c > index 4c7488840c7c..9d6a222a055c 100644 > --- a/fsck/mount.c > +++ b/fsck/mount.c > @@ -3518,22 +3518,90 @@ static void destroy_fsync_dnodes(struct list_head *head) > del_fsync_inode(entry); > } > > +static int find_node_blk_fast(struct f2fs_sb_info *sbi, block_t *blkaddr_fast, > + struct f2fs_node *node_blk_fast, bool *is_detecting) > +{ > + int i, err; > + > + for (i = 0; i < 2; i++) { > + if (!f2fs_is_valid_blkaddr(sbi, *blkaddr_fast, META_POR)) { > + *is_detecting = false; > + return 0; > + } > + > + err = dev_read_block(node_blk_fast, *blkaddr_fast); > + if (err) > + return err; > + > + if (!is_recoverable_dnode(sbi, node_blk_fast)) { > + *is_detecting = false; > + return 0; > + } > + > + *blkaddr_fast = next_blkaddr_of_node(node_blk_fast); > + } > + > + return 0; > +} > + > +static int loop_node_chain_fix(struct f2fs_sb_info *sbi, Applied after removing sbi pointer which is unneeded. > + block_t blkaddr_fast, struct f2fs_node *node_blk_fast, > + block_t blkaddr, struct f2fs_node *node_blk) > +{ > + block_t blkaddr_entry, blkaddr_tmp; > + int err; > + > + /* find the entry point of the looped node chain */ > + while (blkaddr_fast != blkaddr) { > + err = dev_read_block(node_blk_fast, blkaddr_fast); > + if (err) > + return err; > + blkaddr_fast = next_blkaddr_of_node(node_blk_fast); > + > + err = dev_read_block(node_blk, blkaddr); > + if (err) > + return err; > + blkaddr = next_blkaddr_of_node(node_blk); > + } > + blkaddr_entry = blkaddr; > + > + /* find the last node of the chain */ > + do { > + blkaddr_tmp = blkaddr; > + err = dev_read_block(node_blk, blkaddr); > + if (err) > + return err; > + blkaddr = next_blkaddr_of_node(node_blk); > + } while (blkaddr != blkaddr_entry); > + > + /* fix the blkaddr of last node with NULL_ADDR. */ > + node_blk->footer.next_blkaddr = NULL_ADDR; > + if (IS_INODE(node_blk)) > + err = write_inode(node_blk, blkaddr_tmp); > + else > + err = dev_write_block(node_blk, blkaddr_tmp); > + if (!err) > + FIX_MSG("Fix looped node chain on blkaddr %u\n", > + blkaddr_tmp); > + return err; > +} > + > static int find_fsync_inode(struct f2fs_sb_info *sbi, struct list_head *head) > { > struct curseg_info *curseg; > - struct f2fs_node *node_blk; > - block_t blkaddr; > - unsigned int loop_cnt = 0; > - unsigned int free_blocks = MAIN_SEGS(sbi) * sbi->blocks_per_seg - > - sbi->total_valid_block_count; > + struct f2fs_node *node_blk, *node_blk_fast; > + block_t blkaddr, blkaddr_fast; > + bool is_detecting = true; > int err = 0; > > + node_blk = calloc(F2FS_BLKSIZE, 1); > + node_blk_fast = calloc(F2FS_BLKSIZE, 1); > + ASSERT(node_blk && node_blk_fast); > + > /* get node pages in the current segment */ > curseg = CURSEG_I(sbi, CURSEG_WARM_NODE); > blkaddr = NEXT_FREE_BLKADDR(sbi, curseg); > - > - node_blk = calloc(F2FS_BLKSIZE, 1); > - ASSERT(node_blk); > + blkaddr_fast = blkaddr; > > while (1) { > struct fsync_inode_entry *entry; > @@ -3564,19 +3632,48 @@ static int find_fsync_inode(struct f2fs_sb_info *sbi, struct list_head *head) > if (IS_INODE(node_blk) && is_dent_dnode(node_blk)) > entry->last_dentry = blkaddr; > next: > - /* sanity check in order to detect looped node chain */ > - if (++loop_cnt >= free_blocks || > - blkaddr == next_blkaddr_of_node(node_blk)) { > - MSG(0, "\tdetect looped node chain, blkaddr:%u, next:%u\n", > - blkaddr, > - next_blkaddr_of_node(node_blk)); > + blkaddr = next_blkaddr_of_node(node_blk); > + > + /* Below we will detect looped node chain with Floyd's cycle > + * detection algorithm. > + */ > + if (!is_detecting) > + continue; > + > + err = find_node_blk_fast(sbi, &blkaddr_fast, > + node_blk_fast, &is_detecting); > + if (err) > + break; > + > + if (!is_detecting) > + continue; > + > + if (blkaddr_fast != blkaddr) > + continue; > + > + ASSERT_MSG("\tdetect looped node chain, blkaddr:%u\n", > + blkaddr); > + > + if (!c.fix_on) { > err = -1; > break; > } > > - blkaddr = next_blkaddr_of_node(node_blk); > + err = loop_node_chain_fix(sbi, > + NEXT_FREE_BLKADDR(sbi, curseg), > + node_blk_fast, blkaddr, node_blk); > + if (err) > + break; > + > + /* Since we call get_fsync_inode() to ensure there are no > + * duplicate inodes in the inode_list even if there are > + * duplicate blkaddr, we can continue running after fixing the > + * looped node chain. > + */ > + is_detecting = false; > } > > + free(node_blk_fast); > free(node_blk); > return err; > } > -- > 2.25.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel