From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 124F2EB64D8 for ; Thu, 22 Jun 2023 07:11:11 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qCETF-000253-4Y; Thu, 22 Jun 2023 07:11:10 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qCETE-00024x-Gb for linux-f2fs-devel@lists.sourceforge.net; Thu, 22 Jun 2023 07:11:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+f6/3HWE0d/ITyyMtT0i3Z7t/BYlndvfbpR5NV84WDs=; b=kjbsmSQDfJxJzb6r8Cc/gw3cee XkJylQn15HC5vw6jnrFmYmtaINcrPrLJcw/2cnYbX2aZ57UUdI5Pn8ZKB0fgnEyPZhy+BEgoATmGV z5N7HxL5zb5yCjEU+C06k+XQ9nfo3PQVtAEmjfH3bJIPNr8wJiAQMbpqPar44LBSCM4E=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+f6/3HWE0d/ITyyMtT0i3Z7t/BYlndvfbpR5NV84WDs=; b=Ffso31xw5VxQjcgsAX8VMhjOQ3 qLWifpd36+IVwfgLFQG3rolDdG0vqU1ImoDUlNathOlxQM0qyXccyVcLAt4c8zW760nTXSWU+5Xri o8DI34sVi18zFMUSlxmG+xpO+19Fo3yjcB0VtMd9ijhcYiMMww0LHpkbI+oNx4jxYOS4=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1qCETB-00BGOT-9U for linux-f2fs-devel@lists.sourceforge.net; Thu, 22 Jun 2023 07:11:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E068B61773 for ; Thu, 22 Jun 2023 07:10:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39E00C433C8; Thu, 22 Jun 2023 07:10:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687417859; bh=8jQouzNvFfI0w53rF3Myv7DfKU8b+aG1x+36kHMU0rw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a3NtvxXoUn5ieC5W6teQ8K3mZtFQ6EYq3bjrLZ1r2QzcKWTvbCxt2h+laL5oQtVpu tbKQFW6MJMaDG6D3A9xHUbcJKdCbyg+cnY/yvhyvAgy4it2o4t+43FeJEfVJqqHbHL cfCh72A5HGieTFCmUMzpAp4tC62b++Kmt6t8iW8Y0L/fx+ofLRsGYZuHBh2Znazu/I yGPwlYrgcwhlMmfPZiWcaJd7d/dnWQ9xguJ8RoDwGkgBzYGDDVTSbc4GzMF5VlJSHZ LcmV9V52uAaQINTDoFWqCvVPyE+TmNRZdfux0BZX39QCMgaYc1Yt3T95zqJSknlUzo NhRZONsim0+7g== Date: Thu, 22 Jun 2023 00:10:57 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20230606203645.3926651-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1qCETB-00BGOT-9U Subject: Re: [f2fs-dev] [PATCH v2] f2fs: compress tmp files given extension X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 06/20, Chao Yu wrote: > On 2023/6/14 6:14, Jaegeuk Kim wrote: > > Let's compress tmp files for the given extension list. > > > > This patch does not change the previous behavior, but allow the cases as below. > > > > Extention example: "ext" > > > > - abc.ext : allow > > - abc.ext.abc : allow > > - abc.extm : not allow > > > > Signed-off-by: Jaegeuk Kim > > --- > > > > Change log from v1: > > - refactor to allow abc.ext.dontcare only > > > > fs/f2fs/namei.c | 18 +++++++++++------- > > 1 file changed, 11 insertions(+), 7 deletions(-) > > > > diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c > > index 3e35eb7dbb8f..49573ef4115d 100644 > > --- a/fs/f2fs/namei.c > > +++ b/fs/f2fs/namei.c > > @@ -23,7 +23,7 @@ > > #include > > static inline bool is_extension_exist(const unsigned char *s, const char *sub, > > - bool tmp_ext) > > + bool tmp_ext, bool tmp_dot) > > { > > size_t slen = strlen(s); > > size_t sublen = strlen(sub); > > @@ -49,8 +49,12 @@ static inline bool is_extension_exist(const unsigned char *s, const char *sub, > > for (i = 1; i < slen - sublen; i++) { > > if (s[i] != '.') > > continue; > > - if (!strncasecmp(s + i + 1, sub, sublen)) > > - return true; > > + if (!strncasecmp(s + i + 1, sub, sublen)) { > > + if (!tmp_dot) > > + return true; > > + if (i == slen - sublen - 1 || s[i + 1 + sublen] == '.') > > Do you mean? > > if (i == slen - sublen - 1 && s[i + 1 + sublen] == '.') I don't think so. > > > + return true; > > + } > > } > > return false; > > @@ -148,7 +152,7 @@ static void set_compress_new_inode(struct f2fs_sb_info *sbi, struct inode *dir, > > cold_count = le32_to_cpu(sbi->raw_super->extension_count); > > hot_count = sbi->raw_super->hot_ext_count; > > for (i = cold_count; i < cold_count + hot_count; i++) > > - if (is_extension_exist(name, extlist[i], false)) > > + if (is_extension_exist(name, extlist[i], false, false)) > > Parameters should be consistent w/ the one in set_file_temperature()? > > if (is_extension_exist(name, extlist[i], true, false)) > > > break; > > f2fs_up_read(&sbi->sb_lock); > > if (i < (cold_count + hot_count)) > > @@ -156,12 +160,12 @@ static void set_compress_new_inode(struct f2fs_sb_info *sbi, struct inode *dir, > > /* Don't compress unallowed extension. */ > > for (i = 0; i < noext_cnt; i++) > > - if (is_extension_exist(name, noext[i], false)) > > + if (is_extension_exist(name, noext[i], false, false)) > > is_extension_exist(name, noext[i], true, true) ? > > Thanks, > > > return; > > /* Compress wanting extension. */ > > for (i = 0; i < ext_cnt; i++) { > > - if (is_extension_exist(name, ext[i], false)) { > > + if (is_extension_exist(name, ext[i], true, true)) { > > set_compress_context(inode); > > return; > > } > > @@ -189,7 +193,7 @@ static void set_file_temperature(struct f2fs_sb_info *sbi, struct inode *inode, > > cold_count = le32_to_cpu(sbi->raw_super->extension_count); > > hot_count = sbi->raw_super->hot_ext_count; > > for (i = 0; i < cold_count + hot_count; i++) > > - if (is_extension_exist(name, extlist[i], true)) > > + if (is_extension_exist(name, extlist[i], true, false)) > > break; > > f2fs_up_read(&sbi->sb_lock); _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel