From: Matthew Wilcox <willy@infradead.org>
To: Yangtao Li <frank.li@vivo.com>
Cc: Jens Axboe <axboe@kernel.dk>, Jaegeuk Kim <jaegeuk@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Lu Hongfei <luhongfei@vivo.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] f2fs async buffered write patch
Date: Mon, 26 Jun 2023 13:16:26 +0100 [thread overview]
Message-ID: <ZJmBmt3WmUpWR3+2@casper.infradead.org> (raw)
In-Reply-To: <953510c3-4bcd-1426-3527-09d5cbdcf8cc@vivo.com>
On Mon, Jun 26, 2023 at 03:31:57PM +0800, Yangtao Li wrote:
> +cc willy@infradead.org
>
>
> On 2023/6/20 4:43, Jens Axboe wrote:
>
> > Hi,
> >
> > I came across this patch in a news posting:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=d618126911829523e35a61f4a5a4ad159b1b2c8d
> >
> > which has me a bit worried. As far as I can tell, all that patch does is
> > set FMODE_BUF_WASYNC, and then just hope that the lower layers handle
> > the rest?
> >
> > What happens if iocb->ki_flags & IOCB_NOWAIT is true, and now we do:
> >
> > generic_perform_write(iocb, from)
> > ...
> > ->write_begin() <- does this block?
>
> Most file systems have not been changed to the iomap method,
That's what needs to be fixed.
> and the generic_perform_write method is still used. So it seems
>
> reasonable to make IOCB_NOWAIT be handled correctly by the
>
> generic_perform_write function. This means that we need to modify
No. Use the modern infrastructure.
> several places mentioned by Jens in the generic_perform_write function,
>
> and need to pass AOP_FLAG_xxx or iocb into write_begin.
Definitely not.
>
> I noticed that Matthew Wilcox removed the flags parameter in write_begin
>
> in a previous commit, maybe we can add it back?
No.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2023-06-26 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 20:43 [f2fs-dev] f2fs async buffered write patch Jens Axboe
2023-06-20 6:16 ` Jaegeuk Kim
2023-06-20 13:09 ` Jens Axboe
2023-06-26 7:31 ` Yangtao Li via Linux-f2fs-devel
2023-06-26 12:16 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJmBmt3WmUpWR3+2@casper.infradead.org \
--to=willy@infradead.org \
--cc=axboe@kernel.dk \
--cc=frank.li@vivo.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=luhongfei@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).