From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72715EB64D7 for ; Wed, 28 Jun 2023 18:33:52 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qEZzB-0004Ds-Kw; Wed, 28 Jun 2023 18:33:50 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qEZz7-0004Dl-U5 for linux-f2fs-devel@lists.sourceforge.net; Wed, 28 Jun 2023 18:33:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=q2bbf57Pb4pvQcTv4CjhexPfwHlIra5/EJCWklvvpbA=; b=XghFy4DQOh1bOP8KHfUlw6N6Rk wQeqG+hER+T/NUF2wawlqFSAWLEmkXKOOT1BlDseFT5HOEfaMk5q3hdGHX7mzABucv7zaYlw4uMaI YtXexBOnupE/Zq6VTU4Tiim49Avg9vrZFdouPu/x1OK3oueuX0rKmURHz1Fl9fQCNkCc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=q2bbf57Pb4pvQcTv4CjhexPfwHlIra5/EJCWklvvpbA=; b=XK0AzdCTUhK3GA1AduXCM4reSJ yJLmUCwQEq1T/26PVnE71jJokPjgMSlCYk6kOvvK7+1ezjYTjfojToNBg4aMbns20Ok6Xr2h5Wp4R HCIWFebxCzsXzW1Kw3Ghf6a1Ttn/NlJcjieOr1lkOMSEsx+i9U/jUuttwu+Zcx80nlaI=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1qEZz4-00067c-Uo for linux-f2fs-devel@lists.sourceforge.net; Wed, 28 Jun 2023 18:33:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7103761416 for ; Wed, 28 Jun 2023 18:33:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9501C433C8; Wed, 28 Jun 2023 18:33:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687977216; bh=PQylG1KdUstc1Cg/WoQUG20kCsvwqf/NgHAmIMpuUdk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R0mZTZ0RKj5JbYPa2WjnbY8Bh47st/gO0VHS3b5WH+rsBw0D7pOpXT/oaLkQxh23H skGrGU1yvdjS5oiBwPxLxDGaGjOBYaKJBw/hlwdow+V1/+EbAcEo5JMKjqoWOnSDhI 3TBG5UJR7iDP1syCoubUPXOi02b1Dk8gICHcCtLWlLIIOVh4AhZCd3faTF46mUnwZh HO2eQxW5w4e7bx6XbfpNPa1Q6xUamE0ejIVEDKDjfGdgpSxWw37AAJsh3cRCK3tHh7 l2LmUTH2juuaBKuRRPjxCCweNdps5BLbgGLPs9FsCkHx0JTIihms5JYcrTfrkCmocn r1DFGh2eMLZRQ== Date: Wed, 28 Jun 2023 11:33:35 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20230613233940.3643362-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1qEZz4-00067c-Uo Subject: Re: [f2fs-dev] [PATCH v2] f2fs: fix deadlock in i_xattr_sem and inode page lock and fix the original issue X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 06/28, Chao Yu wrote: > On 2023/6/28 16:08, Jaegeuk Kim wrote: > > Thread #1: > > > > [122554.641906][ T92] f2fs_getxattr+0xd4/0x5fc > > -> waiting for f2fs_down_read(&F2FS_I(inode)->i_xattr_sem); > > > > [122554.641927][ T92] __f2fs_get_acl+0x50/0x284 > > [122554.641948][ T92] f2fs_init_acl+0x84/0x54c > > [122554.641969][ T92] f2fs_init_inode_metadata+0x460/0x5f0 > > [122554.641990][ T92] f2fs_add_inline_entry+0x11c/0x350 > > -> Locked dir->inode_page by f2fs_get_node_page() > > > > [122554.642009][ T92] f2fs_do_add_link+0x100/0x1e4 > > [122554.642025][ T92] f2fs_create+0xf4/0x22c > > [122554.642047][ T92] vfs_create+0x130/0x1f4 > > > > Thread #2: > > > > [123996.386358][ T92] __get_node_page+0x8c/0x504 > > -> waiting for dir->inode_page lock > > > > [123996.386383][ T92] read_all_xattrs+0x11c/0x1f4 > > [123996.386405][ T92] __f2fs_setxattr+0xcc/0x528 > > [123996.386424][ T92] f2fs_setxattr+0x158/0x1f4 > > -> f2fs_down_write(&F2FS_I(inode)->i_xattr_sem); > > > > [123996.386443][ T92] __f2fs_set_acl+0x328/0x430 > > [123996.386618][ T92] f2fs_set_acl+0x38/0x50 > > [123996.386642][ T92] posix_acl_chmod+0xc8/0x1c8 > > [123996.386669][ T92] f2fs_setattr+0x5e0/0x6bc > > [123996.386689][ T92] notify_change+0x4d8/0x580 > > [123996.386717][ T92] chmod_common+0xd8/0x184 > > [123996.386748][ T92] do_fchmodat+0x60/0x124 > > [123996.386766][ T92] __arm64_sys_fchmodat+0x28/0x3c > > Back to the race condition, my question is why we can chmod on inode before > it has been created? This is touching the directory. > > Thanks, > > > > > Fixes: 27161f13e3c3 "f2fs: avoid race in between read xattr & write xattr" > > Cc: > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/dir.c | 9 ++++++++- > > fs/f2fs/xattr.c | 6 ++++-- > > 2 files changed, 12 insertions(+), 3 deletions(-) > > > > diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c > > index 887e55988450..d635c58cf5a3 100644 > > --- a/fs/f2fs/dir.c > > +++ b/fs/f2fs/dir.c > > @@ -775,8 +775,15 @@ int f2fs_add_dentry(struct inode *dir, const struct f2fs_filename *fname, > > { > > int err = -EAGAIN; > > - if (f2fs_has_inline_dentry(dir)) > > + if (f2fs_has_inline_dentry(dir)) { > > + /* > > + * Should get i_xattr_sem to keep the lock order: > > + * i_xattr_sem -> inode_page lock used by f2fs_setxattr. > > + */ > > + f2fs_down_read(&F2FS_I(dir)->i_xattr_sem); > > err = f2fs_add_inline_entry(dir, fname, inode, ino, mode); > > + f2fs_up_read(&F2FS_I(dir)->i_xattr_sem); > > + } > > if (err == -EAGAIN) > > err = f2fs_add_regular_entry(dir, fname, inode, ino, mode); > > diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c > > index 213805d3592c..476b186b90a6 100644 > > --- a/fs/f2fs/xattr.c > > +++ b/fs/f2fs/xattr.c > > @@ -528,10 +528,12 @@ int f2fs_getxattr(struct inode *inode, int index, const char *name, > > if (len > F2FS_NAME_LEN) > > return -ERANGE; > > - f2fs_down_read(&F2FS_I(inode)->i_xattr_sem); > > + if (!ipage) > > + f2fs_down_read(&F2FS_I(inode)->i_xattr_sem); > > error = lookup_all_xattrs(inode, ipage, index, len, name, > > &entry, &base_addr, &base_size, &is_inline); > > - f2fs_up_read(&F2FS_I(inode)->i_xattr_sem); > > + if (!ipage) > > + f2fs_up_read(&F2FS_I(inode)->i_xattr_sem); > > if (error) > > return error; _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel