From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB6E8EB64DC for ; Wed, 19 Jul 2023 03:30:59 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qLxtx-000529-ES; Wed, 19 Jul 2023 03:30:57 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qLxtw-000520-97 for linux-f2fs-devel@lists.sourceforge.net; Wed, 19 Jul 2023 03:30:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xZssYNKocP7SJAjxckC3wBJ507CzulE9IvrMWjf3P+k=; b=QVHUlAtIn7RIr6SR5cp/dBsUJj 8ZAnpn0mqu1oBRP5FXcoaD33ORIlnUbzFSMQzralXpwaV3b487bY1TVGOYUasofzdJhO8K40zcwwu vha9EF6GxLatgL+gAh83KyDydBxfTwhGVq8bnXpUc5W+Zx2iRVeK7SpwI+UqsnBReXlA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xZssYNKocP7SJAjxckC3wBJ507CzulE9IvrMWjf3P+k=; b=cBKohb8p4bsTAanLRtRfNDjL/n xJcHlPeTDOb61irpIPbshhZq+L8dQCjtyYHPwClLPKd+lr3Wtr0T/3Xt59d6gnRNNh1GlkLBsfQ/i 264TuGVYRw1H6O+9d0ZP53PrSkIb28jNAw70lvFTkJFdcqKkBwlFBE9H9FYKE419Irvw=; Received: from mail-qt1-f171.google.com ([209.85.160.171]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1qLxtr-0007H9-Bn for linux-f2fs-devel@lists.sourceforge.net; Wed, 19 Jul 2023 03:30:56 +0000 Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-40398ccdaeeso34418071cf.3 for ; Tue, 18 Jul 2023 20:30:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1689737443; x=1692329443; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xZssYNKocP7SJAjxckC3wBJ507CzulE9IvrMWjf3P+k=; b=FzQHMLUgPXN4rcRzb9i5yM9MvrIKVeMM8xqMuygSC6nfHDYovq3ajDRsrQ1MQgtXCi 9diDTVIjHjMH5FbkqRbtFnScTeux5i1vWLWUYE3OaxrWo8Vgu6LGJAHjhhHnh3QQEXPK SJ6UaxX5ctOecj7P1QOP+edppcjq7XBML0En0RKsCobURdNaODorUJ4wwQVddTOGgfLm MG3iKyl6gyAKy99q2Fzb3zuN1+G1hDp0c5UJqahry13Ja8e2t2EmOuyHYsT/5LqQEMDy 8mZg/czLuRcdUruENUqreJvtAsTG3eIFRdsywnUIBL2/WmAWF2Sr7+BcIswE4YIdJcGt xU4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689737443; x=1692329443; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xZssYNKocP7SJAjxckC3wBJ507CzulE9IvrMWjf3P+k=; b=JzX/9Y/pNxfsByvKCN8bby8IuqhqZKD/Xz3exq1yPM+eR7hdMnsfLl6DnJwjC+kFB2 0RDufxi50px1vKlZfFpeXwblZRsw0mkbm5c1/fb9IMQWMMo9bJYFcJjUXQUlJwbpRyPm rPcU0z8ezauy/mAIRVFxY0IM1kpV8/DgItGnQuccXmGvjoiG1kbnaF73nI5QQpLazb75 jk6hKPe71o5ErUiFqUSn6R4ApjDdfElFX54vE759wISlvxlP7uGPtEp3uN8jndWRHser sae9z1U4GzgFMG05wTvaDEt9XjqK5y36xB7eriib9Rrr3d98YwcYiDr3Ng8lAPZh0uuT VIxg== X-Gm-Message-State: ABy/qLbMFEF1szfIrV4fs6ClGmgEqOe+OF5v2NeRXFNkyJyPZVDK74sk nfQ7HR64ECANPnzXqslInXK0oILyE88z+TgX4woGJw== X-Google-Smtp-Source: APBJJlHb4gEwJfD+TL2icCrXL1rPSO1/If2sqk52+FC1gSV2ztjdma15fYoDbEqUpP5c7bsoFPcHEw== X-Received: by 2002:a05:6870:96a6:b0:1b3:8d35:c85f with SMTP id o38-20020a05687096a600b001b38d35c85fmr1011777oaq.1.1689730541592; Tue, 18 Jul 2023 18:35:41 -0700 (PDT) Received: from dread.disaster.area (pa49-186-119-116.pa.vic.optusnet.com.au. [49.186.119.116]) by smtp.gmail.com with ESMTPSA id 201-20020a6301d2000000b005633311c70dsm2343100pgb.32.2023.07.18.18.35.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 18:35:40 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1qLw6L-007mcz-1V; Wed, 19 Jul 2023 11:35:37 +1000 Date: Wed, 19 Jul 2023 11:35:37 +1000 To: Jeff Layton Message-ID: References: <20230713-mgctime-v5-0-9eb795d2ae37@kernel.org> <20230713-mgctime-v5-6-9eb795d2ae37@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230713-mgctime-v5-6-9eb795d2ae37@kernel.org> X-Headers-End: 1qLxtr-0007H9-Bn Subject: Re: [f2fs-dev] [PATCH v5 6/8] xfs: switch to multigrain timestamps X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Dave Chinner via Linux-f2fs-devel Reply-To: Dave Chinner Cc: Latchesar Ionkov , Martin Brandenburg , Konstantin Komarov , linux-xfs@vger.kernel.org, "Darrick J. Wong" , Dominique Martinet , Christian Schoenebeck , David Howells , Chris Mason , Andreas Dilger , Hans de Goede , Marc Dionne , codalist@coda.cs.cmu.edu, linux-afs@lists.infradead.org, Mike Marshall , Paulo Alcantara , linux-cifs@vger.kernel.org, Eric Van Hensbergen , Andreas Gruenbacher , Miklos Szeredi , Richard Weinberger , Mark Fasheh , Hugh Dickins , Tyler Hicks , cluster-devel@redhat.com, coda@cs.cmu.edu, linux-mm@kvack.org, linux-f2fs-devel@lists.sourceforge.net, Ilya Dryomov , Iurii Zaikin , Namjae Jeon , Trond Myklebust , Shyam Prasad N , ecryptfs@vger.kernel.org, Kees Cook , ocfs2-devel@lists.linux.dev, Josef Bacik , Tom Talpey , Tejun Heo , Yue Hu , Alexander Viro , linux-mtd@lists.infradead.org, David Sterba , Jaegeuk Kim , ceph-devel@vger.kernel.org, Xiubo Li , Gao Xiang , OGAWA Hirofumi , Jan Harkes , Christian Brauner , linux-ext4@vger.kernel.org, Theodore Ts'o , Joseph Qi , Greg Kroah-Hartman , v9fs@lists.linux.dev, ntfs3@lists.linux.dev, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, Ronnie Sahlberg , Steve French , Sergey Senozhatsky , Luis Chamberlain , Jeffle Xu , devel@lists.orangefs.org, Anna Schumaker , Jan Kara , Bob Peterson , linux-fsdevel@vger.kernel.org, Andrew Morton , Sungjong Seo , linux-erofs@lists.ozlabs.org, linux-nfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Joel Becker Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, Jul 13, 2023 at 07:00:55PM -0400, Jeff Layton wrote: > Enable multigrain timestamps, which should ensure that there is an > apparent change to the timestamp whenever it has been written after > being actively observed via getattr. > > Also, anytime the mtime changes, the ctime must also change, and those > are now the only two options for xfs_trans_ichgtime. Have that function > unconditionally bump the ctime, and warn if XFS_ICHGTIME_CHG is ever not > set. > > Signed-off-by: Jeff Layton > --- > fs/xfs/libxfs/xfs_trans_inode.c | 6 +++--- > fs/xfs/xfs_iops.c | 4 ++-- > fs/xfs/xfs_super.c | 2 +- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_trans_inode.c b/fs/xfs/libxfs/xfs_trans_inode.c > index 0c9df8df6d4a..86f5ffce2d89 100644 > --- a/fs/xfs/libxfs/xfs_trans_inode.c > +++ b/fs/xfs/libxfs/xfs_trans_inode.c > @@ -62,12 +62,12 @@ xfs_trans_ichgtime( > ASSERT(tp); > ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL)); > > - tv = current_time(inode); > + /* If the mtime changes, then ctime must also change */ > + WARN_ON_ONCE(!(flags & XFS_ICHGTIME_CHG)); Make that an ASSERT(flags & XFS_ICHGTIME_CHG), please. There's no need to verify this at runtime on production kernels. -Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel