linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: doc: fix description of max_small_discards
Date: Fri, 18 Aug 2023 14:29:17 -0700	[thread overview]
Message-ID: <ZN/ira/IW3Qm6NvY@google.com> (raw)
In-Reply-To: <90ccff97-5c2e-3dd0-8f96-05c6f3402334@kernel.org>

Let me apply this and see what'll happen later, since no luck to reproduce.

On 08/17, Chao Yu wrote:
> Ping,
> 
> On 2023/7/30 22:25, Chao Yu wrote:
> > The description of max_small_discards is out-of-update in below two
> > aspects, fix it.
> > - it is disabled by default
> > - small discards will be issued during checkpoint
> > 
> > Signed-off-by: Chao Yu <chao@kernel.org>
> > ---
> >   Documentation/ABI/testing/sysfs-fs-f2fs | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs
> > index ad3d76d37c8b..36c3cb547901 100644
> > --- a/Documentation/ABI/testing/sysfs-fs-f2fs
> > +++ b/Documentation/ABI/testing/sysfs-fs-f2fs
> > @@ -102,9 +102,9 @@ What:		/sys/fs/f2fs/<disk>/max_small_discards
> >   Date:		November 2013
> >   Contact:	"Jaegeuk Kim" <jaegeuk.kim@samsung.com>
> >   Description:	Controls the issue rate of discard commands that consist of small
> > -		blocks less than 2MB. The candidates to be discarded are cached until
> > -		checkpoint is triggered, and issued during the checkpoint.
> > -		By default, it is disabled with 0.
> > +		blocks less than 2MB. The candidates to be discarded are cached during
> > +		checkpoint, and issued by issue_discard thread after checkpoint.
> > +		It is enabled by default.
> >   What:		/sys/fs/f2fs/<disk>/max_ordered_discard
> >   Date:		October 2022


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2023-08-18 21:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-30 14:25 [f2fs-dev] [PATCH 1/2] f2fs: doc: fix description of max_small_discards Chao Yu
2023-07-30 14:25 ` [f2fs-dev] [PATCH 2/2] Revert "f2fs: do not issue small discard commands during checkpoint" Chao Yu
2023-08-17 15:21 ` [f2fs-dev] [PATCH 1/2] f2fs: doc: fix description of max_small_discards Chao Yu
2023-08-18 21:29   ` Jaegeuk Kim [this message]
2023-08-21 19:50 ` patchwork-bot+f2fs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZN/ira/IW3Qm6NvY@google.com \
    --to=jaegeuk@kernel.org \
    --cc=chao@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).