From: Matthew Wilcox <willy@infradead.org>
To: Kairui Song <kasong@tencent.com>
Cc: Ryan Roberts <ryan.roberts@arm.com>, Chris Li <chrisl@kernel.org>,
Neil Brown <neilb@suse.de>, Minchan Kim <minchan@kernel.org>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Yosry Ahmed <yosryahmed@google.com>,
linux-mm@kvack.org, Barry Song <v-songbaohua@oppo.com>,
"Huang, Ying" <ying.huang@intel.com>,
linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>
Subject: Re: [f2fs-dev] [PATCH v2 3/8] f2fs: drop usage of page_index
Date: Tue, 23 Apr 2024 23:58:44 +0100 [thread overview]
Message-ID: <Zig9JCrhky9JieRS@casper.infradead.org> (raw)
In-Reply-To: <20240423170339.54131-4-ryncsn@gmail.com>
On Wed, Apr 24, 2024 at 01:03:34AM +0800, Kairui Song wrote:
> @@ -4086,8 +4086,7 @@ void f2fs_clear_page_cache_dirty_tag(struct page *page)
> unsigned long flags;
>
> xa_lock_irqsave(&mapping->i_pages, flags);
> - __xa_clear_mark(&mapping->i_pages, page_index(page),
> - PAGECACHE_TAG_DIRTY);
> + __xa_clear_mark(&mapping->i_pages, page->index, PAGECACHE_TAG_DIRTY);
> xa_unlock_irqrestore(&mapping->i_pages, flags);
> }
I just sent a patch which is going to conflict with this:
https://lore.kernel.org/linux-mm/20240423225552.4113447-3-willy@infradead.org/
Chao Yu, Jaegeuk Kim; what are your plans for converting f2fs to use
folios? This is getting quite urgent.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2024-04-23 22:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240423170339.54131-1-ryncsn@gmail.com>
2024-04-23 17:03 ` [f2fs-dev] [PATCH v2 3/8] f2fs: drop usage of page_index Kairui Song
2024-04-23 22:58 ` Matthew Wilcox [this message]
2024-04-28 3:17 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zig9JCrhky9JieRS@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=chrisl@kernel.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jaegeuk@kernel.org \
--cc=kasong@tencent.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=neilb@suse.de \
--cc=ryan.roberts@arm.com \
--cc=v-songbaohua@oppo.com \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).