From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D435DC3DA49 for ; Thu, 25 Jul 2024 20:54:32 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sX5Tr-000669-6O; Thu, 25 Jul 2024 20:54:31 +0000 Received: from [172.30.29.67] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sX5Tp-00065r-IC for linux-f2fs-devel@lists.sourceforge.net; Thu, 25 Jul 2024 20:54:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/QYT0rzPLuApfQeI6j5NFgV7WR4KNyqVVfH6646Ngvs=; b=Sr7qFP1WJSjjwKkHhKIKewpQX8 W1XvG2vXjt/ET84FUQBM5P5wtDefdnaytqYM1b9OyuvIHOg9K9ZJFvVoh56BoObHzRfYJvEqfr+n9 0LgGzWNyJS3saV2us9RHYIW3GmXviRDMO9XCF9Pp4BS6Ke8fePrwl7rTK1hYL6wc+3+A=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/QYT0rzPLuApfQeI6j5NFgV7WR4KNyqVVfH6646Ngvs=; b=OAAk6I+Bx2rDoCwvyfr08ZG6vs t37YBS3/5CBqunVRqRfqREkv0r6ufQwcvxYyic8/dDYzX3QbV15kL6pIjlinr703h7a7sqBiNdSGd b5Af0/+jEKUuuo5CgvTNvbtZKSazbbi+U2ZosGAs1B+MoLa8gpDQTPkHvBhKL5jj0DWg=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1sX5To-0001qo-TH for linux-f2fs-devel@lists.sourceforge.net; Thu, 25 Jul 2024 20:54:29 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 512F96123C for ; Thu, 25 Jul 2024 20:54:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8D80C116B1; Thu, 25 Jul 2024 20:54:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721940858; bh=k5XgKfZKuQaShbPcQ6ThZs8P3ZYbgS7XfbQSn8nih/M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rLgvLDDj/jasD2/pDtM49kkJ73pgckmTKb+fEsomssWcydRi7ggyWe8W/aipUNKO+ J5F8Gmt2d7PLHw/6elTZEG8kU6W3QDAE/TV4sp0VxN1LWbcIuIn+TES/IhTmNza0yw x6AcKKCui7WnsXGMe2d0kQzF+3BmdmE4s0cmJy/AVVv012YJp1+PRaT1f2JJ/4SqZT 72BVaur7u7PpesAI1oMYHku9zbf7Mvqs65VP0AN51oH83+fFkkNVwoa9KnjlSZFKOz EOOi05ETs9X82PYug+aOE2q76RAie1OOXjLttCt4QV4qsOUiPr4kx6wczrG2+rFkkR 9L3ftWZG+6niw== Date: Thu, 25 Jul 2024 20:54:16 +0000 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20240625031351.3586955-1-chao@kernel.org> <20240625031351.3586955-3-chao@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240625031351.3586955-3-chao@kernel.org> X-Headers-End: 1sX5To-0001qo-TH Subject: Re: [f2fs-dev] [PATCH 3/4] f2fs: atomic: fix to truncate pagecache before on-disk metadata truncation X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 06/25, Chao Yu wrote: > We should always truncate pagecache while truncating on-disk data. > > Fixes: a46bebd502fe ("f2fs: synchronize atomic write aborts") > Signed-off-by: Chao Yu > --- > fs/f2fs/file.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index 2203904383a6..0355cb054521 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -2185,6 +2185,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp, bool truncate) > clear_inode_flag(fi->cow_inode, FI_INLINE_DATA); > } else { > /* Reuse the already created COW inode */ > + truncate_setsize(inode, 0); fi->cow_inode? > ret = f2fs_do_truncate_blocks(fi->cow_inode, 0, true); > if (ret) { > f2fs_up_write(&fi->i_gc_rwsem[WRITE]); > -- > 2.40.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel