From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1F2DC3DA61 for ; Mon, 29 Jul 2024 18:57:59 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sYVZF-0002ZV-6T; Mon, 29 Jul 2024 18:57:57 +0000 Received: from [172.30.29.67] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sYVZD-0002ZM-2f for linux-f2fs-devel@lists.sourceforge.net; Mon, 29 Jul 2024 18:57:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bI98vnr4STfnlezdFEzg4Ja3ISFYbT1ZwioxbeX8MKA=; b=JynX1OL8DPZXaeorpKQSHQv9Po UracLfg5am3zqSxPePigRIIXnz1nwyeq1GUves4aYS/jtcZByW/IgBvsvHbdyGKX5CFMqebsyXMsN oDrvMi36xrePn+uOmkYePb5CFcZ/xw2ZuRFfxjnvZnEF9MS4McV/82d898syPjk5e7Ig=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=bI98vnr4STfnlezdFEzg4Ja3ISFYbT1ZwioxbeX8MKA=; b=S/3CHcciemNsPnJ063XKHViKnk U91zaE83W8t4JLWaKoQLz3iMaI4lskpd0rgcDFUGOfwduDVQG2rkVBoqw6p/7JZ7UKcubTSWo3kgl 7xbrhBTnXWAq77kBaOXmnJ3NsOF3nq/eyD3RP67THIOi/rVKbgptjaVE3SI0L7a+xiWs=; Received: from bombadil.infradead.org ([198.137.202.133]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1sYVZC-0005YK-FW for linux-f2fs-devel@lists.sourceforge.net; Mon, 29 Jul 2024 18:57:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bI98vnr4STfnlezdFEzg4Ja3ISFYbT1ZwioxbeX8MKA=; b=ej0EAM7w2vW2zx7IVBK5UWb6kj wN1ljrPR09MnAd97P+fTuB/kR5lUi1RXb/2QVebNH54cfJkcVdn1DRLq3wIEF0L6HoO11Wpaq31KH b3HS8xuAqVh03lWz/yE/u/Ow4kdwDfTmmKIn1lYNQAiHIsSLGMaD6CF3yGFFxC5Vu9WtjGlQ60UOy Q4BgloNHbkwvChMYnO+355i5pha1GxRbPUdTrd6mvYaBUccsoS/rnsx/t69CMPNmh+bDgQ7LKqIkf Sjd3SluVefNGGxsPirSouasiVgrHnm6V+d9KUEa831qxQ9pkwr7Uw7PFflXMznzSAxHEHWl7Kshw0 rtNYHKgA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYVYt-0000000CPTa-3gro; Mon, 29 Jul 2024 18:57:35 +0000 Date: Mon, 29 Jul 2024 11:57:35 -0700 From: Christoph Hellwig To: Theodore Ts'o Message-ID: References: <68584887-3dec-4ce5-8892-86af50651c41@libero.it> <91bfea9b-ad7e-4f35-a2c1-8cd41499b0c0@linux.dev> <20240726152237.GH17473@twin.jikos.cz> <20240726175800.GC131596@mit.edu> <20240727145232.GA377174@mit.edu> <23862652-a702-4a5d-b804-db9ee9f6f539@linux.dev> <20240729024412.GD377174@mit.edu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240729024412.GD377174@mit.edu> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Headers-End: 1sYVZC-0005YK-FW Subject: Re: [f2fs-dev] [PATCH 1/4] module: Add module_subinit{_noexit} and module_subeixt helper macros X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-Arch , Youling Tang , linux-f2fs-devel@lists.sourceforge.net, Arnd Bergmann , linux-kernel@vger.kernel.org, kreijack@inwind.it, David Sterba , Josef Bacik , Christoph Hellwig , Chris Mason , Luis Chamberlain , Andreas Dilger , linux-btrfs@vger.kernel.org, Youling Tang , David Sterba , Jaegeuk Kim , linux-ext4@vger.kernel.org, linux-modules@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Sun, Jul 28, 2024 at 10:44:12PM -0400, Theodore Ts'o wrote: > > > > Personally, I prefer the implementation of method two. > > But there's also method zero --- keep things the way they are, and > don't try to add a new astraction. > > Advantage: > > -- Code has worked for decades, so it is very well tested > -- Very easy to understand and maintain > > Disadvantage > > --- A few extra lines of C code. > > which we need to weigh against the other choices. I think option zero is the right option for you and David and anyone scared of link order issues. But I know for XFS or the nvme code having multiple initcalls per module would be extremely helpfu. I don't really want to drag Youling into implementing something he is not behind, but I plan to try that out myself once I find a little time. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel