From: Matthew Wilcox <willy@infradead.org>
To: Li Zetao <lizetao1@huawei.com>
Cc: josef@toxicpanda.com, linux-f2fs-devel@lists.sourceforge.net,
clm@fb.com, terrelln@fb.com, dsterba@suse.com,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 05/14] btrfs: convert read_key_bytes() to take a folio
Date: Thu, 22 Aug 2024 04:28:17 +0100 [thread overview]
Message-ID: <ZsawUY25UW07__4G@casper.infradead.org> (raw)
In-Reply-To: <20240822013714.3278193-6-lizetao1@huawei.com>
On Thu, Aug 22, 2024 at 09:37:05AM +0800, Li Zetao wrote:
> @@ -762,7 +762,7 @@ static struct page *btrfs_read_merkle_tree_page(struct inode *inode,
> * [ inode objectid, BTRFS_MERKLE_ITEM_KEY, offset in bytes ]
> */
> ret = read_key_bytes(BTRFS_I(inode), BTRFS_VERITY_MERKLE_ITEM_KEY, off,
> - folio_address(folio), PAGE_SIZE, &folio->page);
> + folio_address(folio), PAGE_SIZE, folio);
So how are we going to read into folios larger than PAGE_SIZE?
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2024-08-22 3:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 1:37 [f2fs-dev] [PATCH -next 00/14] btrfs: Cleaned up folio->page conversion Li Zetao via Linux-f2fs-devel
2024-08-22 1:37 ` [f2fs-dev] [PATCH 01/14] btrfs: convert clear_page_extent_mapped() to take a folio Li Zetao via Linux-f2fs-devel
2024-08-22 3:02 ` Matthew Wilcox
2024-08-22 1:37 ` [f2fs-dev] [PATCH 02/14] btrfs: convert get_next_extent_buffer() " Li Zetao via Linux-f2fs-devel
2024-08-22 3:05 ` Matthew Wilcox
2024-08-22 10:58 ` Qu Wenruo via Linux-f2fs-devel
2024-08-22 12:07 ` Matthew Wilcox
2024-08-22 22:25 ` Qu Wenruo via Linux-f2fs-devel
2024-08-23 2:13 ` Qu Wenruo via Linux-f2fs-devel
2024-08-23 15:38 ` Matthew Wilcox
2024-08-23 21:32 ` Qu Wenruo via Linux-f2fs-devel
2024-08-26 14:13 ` Josef Bacik
2024-08-26 16:56 ` Matthew Wilcox
2024-08-26 21:32 ` Josef Bacik
2024-08-23 15:17 ` Josef Bacik
2024-08-22 11:01 ` Qu Wenruo via Linux-f2fs-devel
2024-08-22 1:37 ` [f2fs-dev] [PATCH 03/14] btrfs: convert try_release_subpage_extent_buffer() " Li Zetao via Linux-f2fs-devel
2024-08-22 1:37 ` [f2fs-dev] [PATCH 04/14] btrfs: convert try_release_extent_buffer() " Li Zetao via Linux-f2fs-devel
2024-08-22 1:37 ` [f2fs-dev] [PATCH 05/14] btrfs: convert read_key_bytes() " Li Zetao via Linux-f2fs-devel
2024-08-22 3:28 ` Matthew Wilcox [this message]
2024-08-22 1:37 ` [f2fs-dev] [PATCH 06/14] btrfs: convert submit_eb_subpage() " Li Zetao via Linux-f2fs-devel
2024-08-22 1:37 ` [f2fs-dev] [PATCH 07/14] btrfs: convert submit_eb_page() " Li Zetao via Linux-f2fs-devel
2024-08-22 1:37 ` [f2fs-dev] [PATCH 08/14] btrfs: convert try_release_extent_state() " Li Zetao via Linux-f2fs-devel
2024-08-22 1:37 ` [f2fs-dev] [PATCH 09/14] btrfs: convert try_release_extent_mapping() " Li Zetao via Linux-f2fs-devel
2024-08-22 1:37 ` [f2fs-dev] [PATCH 10/14] btrfs: convert zlib_decompress() " Li Zetao via Linux-f2fs-devel
2024-08-22 1:37 ` [f2fs-dev] [PATCH 11/14] btrfs: convert lzo_decompress() " Li Zetao via Linux-f2fs-devel
2024-08-22 1:37 ` [f2fs-dev] [PATCH 12/14] btrfs: convert zstd_decompress() " Li Zetao via Linux-f2fs-devel
2024-08-22 1:37 ` [f2fs-dev] [PATCH 13/14] btrfs: convert btrfs_decompress() " Li Zetao via Linux-f2fs-devel
2024-08-22 1:37 ` [f2fs-dev] [PATCH 14/14] btrfs: convert copy_inline_to_page() to use folio Li Zetao via Linux-f2fs-devel
2024-08-23 19:50 ` [f2fs-dev] [PATCH -next 00/14] btrfs: Cleaned up folio->page conversion Josef Bacik
2024-08-23 21:15 ` Josef Bacik
2024-08-26 14:08 ` Josef Bacik
2024-08-28 13:08 ` Li Zetao via Linux-f2fs-devel
2024-09-25 3:41 ` patchwork-bot+f2fs--- via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsawUY25UW07__4G@casper.infradead.org \
--to=willy@infradead.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=lizetao1@huawei.com \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).