From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48584C43334 for ; Thu, 9 Jun 2022 10:24:21 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nzFKt-00015Q-Hh; Thu, 09 Jun 2022 10:24:18 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nzFKs-00015K-Dq for linux-f2fs-devel@lists.sourceforge.net; Thu, 09 Jun 2022 10:24:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6a5SsgsnTuFo9sIZWQwmUlikCgiuGiGF/De3NllGDd0=; b=MuVaRryG29M4+pqHdklYfuM5CG SYXwKq06uN+iZUalqMWJzSW2v0Gg9YhfjsEf/tGgewl3ilt+8Lx1d9BuuvrimQy+3njoSyqiBlgp4 b3dXndghBzRzeElV2/TBlvcyIuQKYb3ZuzlVu09J38LtWznZWqBT+4u+4M2YQeTdGt8w=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6a5SsgsnTuFo9sIZWQwmUlikCgiuGiGF/De3NllGDd0=; b=ccdHdrYuU8NNHK8VVSVQdH1ZOA 9h6etW4QAra17wlRVndQ8kh5Zk/whmfuA9HmHuNcWe5y03m0i0gBQD8kZczqPakG1C8kJ/aSRrt8J gWLdOsVP8Inj2DJUY5dzAY2lDbha7/+Gyzd0Pw30n7doS62op18gKATncwXBGBAmh0/M=; Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nzFKj-00C0s0-P6 for linux-f2fs-devel@lists.sourceforge.net; Thu, 09 Jun 2022 10:24:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654770243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6a5SsgsnTuFo9sIZWQwmUlikCgiuGiGF/De3NllGDd0=; b=O1xC9fxZOMxaqC6rSRf/wp7oRubAOdtuQF660ZO5XT5/cyF74PDWeE2QN9m27mc+BMztdJ 4cTCEIEgzKecWwUfZ7+HFqcmlsf3bRPqSVsgzJFiymh+8vAQB/cUacDsI0Qr52taSElHs3 mqthmRsXI3hdg1HfHwjn9aCD07YEUwY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-240-DEUjcACyP-us08-bNIyEtA-1; Thu, 09 Jun 2022 06:24:02 -0400 X-MC-Unique: DEUjcACyP-us08-bNIyEtA-1 Received: by mail-wm1-f71.google.com with SMTP id ay28-20020a05600c1e1c00b0039c5cbe76c1so3394388wmb.1 for ; Thu, 09 Jun 2022 03:24:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=6a5SsgsnTuFo9sIZWQwmUlikCgiuGiGF/De3NllGDd0=; b=EibwI6pWfqjqB6O3Nrje6NXzrPIKktKgVmhjPMYLsWfBo2O5WnDXigNKxwfJQfUYgR zXZuk6w8Hm0Kwf8NqYmFUZ53/MVDDdHhR7BY75Ji10xiwSxtw1H6UQqjoEs5XeMIxEhk x8uzwVetljw7WxYiXeME3k3KHIsgX8NealQ8JyzZKZaaKh8YhfNykDzep9z0ATS6/TMu nvkuyEWLaHxZz967uKskJ2p2rrG/pAEfZIywqxYGF2DDPi003hUnk3Kuiw5EON8KZegp VEdlu0OE2oVCcwy/6M9rapeMyArxVRI98V33YpjhKCSrZsD5E4BY5nYmZ4XhLMGdA4xf pgtw== X-Gm-Message-State: AOAM533QE+FgpvQsF8QS9+3+1gcV+vuFyHzXoXFtibEzSgZP//z1+7HI RPVrfV1q2BjRHj7CBcA8j5w2QeEAHgcJjQHV6yBNTHf8N+Zxh6DM8nB5Jy2PxRJyYNqkMaUBD/Y KAV7kRxuvKlV5IrdKWgWagU+yUdSpLykqJOVKaw== X-Received: by 2002:a1c:a301:0:b0:392:9bc5:203c with SMTP id m1-20020a1ca301000000b003929bc5203cmr2594370wme.67.1654770241336; Thu, 09 Jun 2022 03:24:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy58rh3fuuccVM2J0IS1QrE1vJ3CH41QyKYHa1IrWm/Rvain2xs2JDw35eE5SOSwtsykjkKLA== X-Received: by 2002:a1c:a301:0:b0:392:9bc5:203c with SMTP id m1-20020a1ca301000000b003929bc5203cmr2594345wme.67.1654770240948; Thu, 09 Jun 2022 03:24:00 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:20af:34be:985b:b6c8? ([2a09:80c0:192:0:20af:34be:985b:b6c8]) by smtp.gmail.com with ESMTPSA id t10-20020a5d460a000000b0021552eebde6sm17782568wrq.32.2022.06.09.03.23.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jun 2022 03:23:59 -0700 (PDT) Message-ID: Date: Thu, 9 Jun 2022 12:23:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 To: "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org References: <20220608150249.3033815-1-willy@infradead.org> <20220608150249.3033815-3-willy@infradead.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220608150249.3033815-3-willy@infradead.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-Headers-End: 1nzFKj-00C0s0-P6 Subject: Re: [f2fs-dev] [PATCH v2 02/19] mm: Convert all PageMovable users to movable_operations X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aio@kvack.org, linux-nfs@vger.kernel.org, cluster-devel@redhat.com, linux-ntfs-dev@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-mtd@lists.infradead.org, ocfs2-devel@oss.oracle.com, linux-ext4@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote: > These drivers are rather uncomfortably hammered into the > address_space_operations hole. They aren't filesystems and don't behave > like filesystems. They just need their own movable_operations structure, > which we can point to directly from page->mapping. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > arch/powerpc/platforms/pseries/cmm.c | 60 +--------------- > drivers/misc/vmw_balloon.c | 61 +--------------- > drivers/virtio/virtio_balloon.c | 47 +----------- > include/linux/balloon_compaction.h | 6 +- > include/linux/fs.h | 2 - > include/linux/migrate.h | 26 +++++-- > include/linux/page-flags.h | 2 +- > include/uapi/linux/magic.h | 4 -- > mm/balloon_compaction.c | 10 ++- > mm/compaction.c | 29 ++++---- > mm/migrate.c | 24 +++---- > mm/util.c | 4 +- > mm/z3fold.c | 82 +++------------------ > mm/zsmalloc.c | 102 ++++++--------------------- > 14 files changed, 94 insertions(+), 365 deletions(-) You probably should have cc'ed the relevant maintainers (including me :P ). For everything except z3fold.c and zsmalloc.c, Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel