From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Yu Subject: Re: [PATCH 1/2] f2fs: enable to gc page whose inode already atomic commit Date: Sun, 4 Feb 2018 22:56:37 +0800 Message-ID: References: <1517626068-49739-1-git-send-email-yunlong.song@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sfi-mx-4.v28.ch3.sourceforge.com ([172.29.28.194] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eiLj9-0000u6-GX for linux-f2fs-devel@lists.sourceforge.net; Sun, 04 Feb 2018 14:57:07 +0000 Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-4.v28.ch3.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) id 1eiLj7-00034e-Je for linux-f2fs-devel@lists.sourceforge.net; Sun, 04 Feb 2018 14:57:07 +0000 In-Reply-To: <1517626068-49739-1-git-send-email-yunlong.song@huawei.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Yunlong Song , jaegeuk@kernel.org, yuchao0@huawei.com, yunlong.song@icloud.com Cc: shengyong1@huawei.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, heyunlei@huawei.com, miaoxie@huawei.com On 2018/2/3 10:47, Yunlong Song wrote: > If inode has already started to atomic commit, then set_page_dirty will > not mix the gc pages with the inmem atomic pages, so the page can be > gced safely. Let's avoid Ccing fs mailing list if the patch didn't change vfs common codes. As you know, the problem here is mixed dnode block flushing w/o writebacking gced data block, result in making transaction unintegrated. So how about just using dio_rwsem[WRITE] during atomic committing to exclude GCing data block of atomic opened file? Thanks, > > Signed-off-by: Yunlong Song > --- > fs/f2fs/data.c | 5 ++--- > fs/f2fs/gc.c | 6 ++++-- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index 7435830..edafcb6 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -1580,14 +1580,13 @@ bool should_update_outplace(struct inode *inode, struct f2fs_io_info *fio) > return true; > if (S_ISDIR(inode->i_mode)) > return true; > - if (f2fs_is_atomic_file(inode)) > - return true; > if (fio) { > if (is_cold_data(fio->page)) > return true; > if (IS_ATOMIC_WRITTEN_PAGE(fio->page)) > return true; > - } > + } else if (f2fs_is_atomic_file(inode)) > + return true; > return false; > } > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index b9d93fd..84ab3ff 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -622,7 +622,8 @@ static void move_data_block(struct inode *inode, block_t bidx, > if (!check_valid_map(F2FS_I_SB(inode), segno, off)) > goto out; > > - if (f2fs_is_atomic_file(inode)) > + if (f2fs_is_atomic_file(inode) && > + !f2fs_is_commit_atomic_write(inode)) > goto out; > > if (f2fs_is_pinned_file(inode)) { > @@ -729,7 +730,8 @@ static void move_data_page(struct inode *inode, block_t bidx, int gc_type, > if (!check_valid_map(F2FS_I_SB(inode), segno, off)) > goto out; > > - if (f2fs_is_atomic_file(inode)) > + if (f2fs_is_atomic_file(inode) && > + !f2fs_is_commit_atomic_write(inode)) > goto out; > if (f2fs_is_pinned_file(inode)) { > if (gc_type == FG_GC) > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot