From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E108C77B7A for ; Wed, 7 Jun 2023 13:04:58 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1q6sqP-0007J5-BV; Wed, 07 Jun 2023 13:04:57 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q6sqO-0007Iw-0I for linux-f2fs-devel@lists.sourceforge.net; Wed, 07 Jun 2023 13:04:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6ru0thZ8nfvt46gXzu50pUmIMhJ4YjfHGU0S7NDPXJc=; b=FpSwVRNd4feQ3XRjCln+tK/HE/ cM56BzNz2rbZ/6dC7QgcK4LTKVnDYB8eqfc3E60Fjtm9wuuTTEWPxySrlsSnyoiRkXvo7MiBWCt/w hYeFF5BKXy1r9QVIXBEiRoVOBttteLKxlViQg66p+JEgBC2OijMU4ZJrPjAwX5gu//sA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6ru0thZ8nfvt46gXzu50pUmIMhJ4YjfHGU0S7NDPXJc=; b=FXCliX2uEFtP+8G6npv8Ufp/ii jJC2I3iZ8QxAVRfs3YXxQCiOhX8NVsF3GSB/vQShYsQRamhVLdzIrcS2IQJgP7Z2AXeusmCYhabIM g/e2AokV0/11SxuH88JPmRxtaG+AXAEQvzvRgyVX6VwjuEE39K0QizGfmsnFerCtIwo8=; Received: from smtp-out1.suse.de ([195.135.220.28]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1q6sqN-00DhoI-QL for linux-f2fs-devel@lists.sourceforge.net; Wed, 07 Jun 2023 13:04:56 +0000 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 826B9219F8; Wed, 7 Jun 2023 13:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686143089; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6ru0thZ8nfvt46gXzu50pUmIMhJ4YjfHGU0S7NDPXJc=; b=LDzG/FZX8+A749MhkfcbaO0/pSl5XzJ9kizkc2BlHr+CJ0OvB7HA+RE7WXn85KrExl92Os IzQkcBtxo9jxjym01y9CCeiH3S0xsnZG08hq3s27jGEDDyzfepQigu3EzmnUJttRWq9Q0r gLAzr1Smr57HQC2DT6141ezeh6kWY2Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686143089; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6ru0thZ8nfvt46gXzu50pUmIMhJ4YjfHGU0S7NDPXJc=; b=aPV7dc8iqJjc6zRUQ4+/5tAxmJb5wPICstK1ajAOs5PwpnlIv8obvFxDXAQKxOl16Ptol8 uk8KJ6nLnB0CvoCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 429DE1346D; Wed, 7 Jun 2023 13:04:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4Da0D3GAgGTxWgAAMHmgww (envelope-from ); Wed, 07 Jun 2023 13:04:49 +0000 Message-ID: Date: Wed, 7 Jun 2023 15:04:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Christoph Hellwig , Jens Axboe References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-21-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230606073950.225178-21-hch@lst.de> X-Headers-End: 1q6sqN-00DhoI-QL Subject: Re: [f2fs-dev] [PATCH 20/31] scsi: replace the fmode_t argument to scsi_ioctl with a simple bool X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , "Rafael J. Wysocki" , linux-nvme@lists.infradead.org, Phillip Potter , Chris Mason , dm-devel@redhat.com, "Md. Haris Iqbal" , Pavel Machek , Miquel Raynal , Jack Wang , linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , linux-pm@vger.kernel.org, linux-um@lists.infradead.org, Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, Alexander Viro , David Sterba , Christian Brauner , "Martin K. Petersen" , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-btrfs@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 6/6/23 09:39, Christoph Hellwig wrote: > Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass > a bool open_for_write to prepare for callers that won't have the fmode_t. > > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/ch.c | 3 ++- > drivers/scsi/scsi_ioctl.c | 34 +++++++++++++++++----------------- > drivers/scsi/sd.c | 2 +- > drivers/scsi/sg.c | 5 +++-- > drivers/scsi/sr.c | 2 +- > drivers/scsi/st.c | 2 +- > include/scsi/scsi_ioctl.h | 2 +- > 7 files changed, 26 insertions(+), 24 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel