Re: [PATCH 1/1] f2fs: simplify the calculation of fggc_threshold

[Chao Yu <chao@kernel.org>]

On 2017/10/17 20:42, sunqiuyang wrote:
> From: Qiuyang Sun <sunqiuyang@huawei.com>
> 
> Do not need to convert segment counts to blocks for this calculation.
> 
> Signed-off-by: Qiuyang Sun <sunqiuyang@huawei.com> 

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

> ---
>  fs/f2fs/gc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index 197ebf4..9df8cae 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -1073,16 +1073,16 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync,
>  
>  void build_gc_manager(struct f2fs_sb_info *sbi)
>  {
> -	u64 main_count, resv_count, ovp_count;
> +	unsigned int main_count, resv_count, ovp_count;
>  
>  	DIRTY_I(sbi)->v_ops = &default_v_ops;
>  
>  	/* threshold of # of valid blocks in a section for victims of FG_GC */
> -	main_count = SM_I(sbi)->main_segments << sbi->log_blocks_per_seg;
> -	resv_count = SM_I(sbi)->reserved_segments << sbi->log_blocks_per_seg;
> -	ovp_count = SM_I(sbi)->ovp_segments << sbi->log_blocks_per_seg;
> +	main_count = SM_I(sbi)->main_segments;
> +	resv_count = SM_I(sbi)->reserved_segments;
> +	ovp_count = SM_I(sbi)->ovp_segments;
>  
> -	sbi->fggc_threshold = div64_u64((main_count - ovp_count) *
> +	sbi->fggc_threshold = div_u64((u64)(main_count - ovp_count) *
>  				BLKS_PER_SEC(sbi), (main_count - resv_count));
>  
>  	/* give warm/cold data area from slower device */
> 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot