From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Nanzhe Zhao <nzzhao@126.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v2 2/2] f2fs: advance index and offset after zeroing in large folio read
Date: Mon, 12 Jan 2026 09:03:03 +0800 [thread overview]
Message-ID: <a1e52b25-ca95-4698-b36d-c67b65a227c9@kernel.org> (raw)
In-Reply-To: <20260111100941.119765-3-nzzhao@126.com>
On 1/11/2026 6:09 PM, Nanzhe Zhao wrote:
> In f2fs_read_data_large_folio(), the block zeroing path calls
> folio_zero_range() and then continues the loop. However, it fails to
> advance index and offset before continuing.
>
> This can cause the loop to repeatedly process the same subpage of the
> folio, leading to stalls/hangs and incorrect progress when reading large
> folios with holes/zeroed blocks.
>
> Fix it by advancing index and offset unconditionally in the loop
> iteration, so they are updated even when the zeroing path continues.
>
> Signed-off-by: Nanzhe Zhao <nzzhao@126.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2026-01-12 1:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-11 10:09 [f2fs-dev] [PATCH v2 0/2] f2fs: fix large folio read corner cases for immutable files Nanzhe Zhao
2026-01-11 10:09 ` [f2fs-dev] [PATCH v2 1/2] f2fs: add 'folio_in_bio' to handle readahead folios with no BIO submission Nanzhe Zhao
2026-01-12 1:02 ` Chao Yu via Linux-f2fs-devel
2026-01-12 8:52 ` Nanzhe Zhao
2026-01-12 9:24 ` Chao Yu via Linux-f2fs-devel
2026-01-13 17:05 ` Jaegeuk Kim via Linux-f2fs-devel
2026-01-16 3:31 ` Nanzhe Zhao
2026-01-16 8:53 ` Chao Yu via Linux-f2fs-devel
2026-01-13 18:32 ` Matthew Wilcox
2026-01-16 4:33 ` Jaegeuk Kim via Linux-f2fs-devel
2026-01-11 10:09 ` [f2fs-dev] [PATCH v2 2/2] f2fs: advance index and offset after zeroing in large folio read Nanzhe Zhao
2026-01-12 1:03 ` Chao Yu via Linux-f2fs-devel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1e52b25-ca95-4698-b36d-c67b65a227c9@kernel.org \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nzzhao@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox