From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14FE3C433EF for ; Wed, 17 Nov 2021 15:20:51 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF07561BF5; Wed, 17 Nov 2021 15:20:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BF07561BF5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mnMjw-00068Y-FA; Wed, 17 Nov 2021 15:20:48 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mnMjr-00067A-9I for linux-f2fs-devel@lists.sourceforge.net; Wed, 17 Nov 2021 15:20:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0IbP6jxY0BxsEhxXj2hOoRlsDEXWeZa+BTrlHPNYAIo=; b=SXsktaVKwCojzMgnwCKlZ05en7 lLNQUSKlKpcA7ZX6HdmQ+NFUzWJNdwruq9MsOb/bcDcb9y20WX6aX/eCNZQujkPgRdSGNTAyrSY3y BMJiqI3GoSmIeGTh9tcdpvXZfezl2X0Zp/g8emxg/cnfAROz68V9qMG1gKx1/iEn2H3E=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0IbP6jxY0BxsEhxXj2hOoRlsDEXWeZa+BTrlHPNYAIo=; b=NzWrbTIRhwsIojwjH2bdh9Q/dV Y4eQJdwVjbEADd6mB1fIxeTS4pOAxCfXa1Ph8Y4eZ2cyOpk68+5LlU/FTsnS1YEi7lNTpcQPK3SaA gSjFP0OpVADUpaMRgDg2kykLEarufLdPaNC5JFhpRRAcznu8dsuL+6A6sraeli9YdgUc=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mnMgJ-0001Fn-V8 for linux-f2fs-devel@lists.sourceforge.net; Wed, 17 Nov 2021 15:17:05 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 710E96187F; Wed, 17 Nov 2021 15:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637162218; bh=pB4lqAVRZNRN8LRv8NoZj6l+hjrOltxbzFUUVGLwVHM=; h=Date:Subject:To:References:From:In-Reply-To:From; b=MTv2p4kqocm87m2JKh2hfvl5D93Bqgl53WOhUadPuzNbOXCM21BATp6Np4+qMDgx7 n8bizARoMEx77vlUUjssiYNeKLYFStBZ2e/WhX9V6vuE/KMbZakVifhqlzKpeHIrOd 5r6dAcfDpQ6FjTWgZVoYM4Q5MeIDo4Y823IV/skp4T1htTeQQLOLDwmzn1NXvYkVPo 76AC08BM78Otf3l0WoCiik4hrVBlVKPwSpAfg7o7bCLBjC1uyVXzOX824GvN4uJkWR 6kpw8rq9krXPInOwstx6hgyW4X74qdAr2W6lGPXsD5BqR1g9scCULLrfyTdQp93KS3 uGa3c4dFFf8vg== Message-ID: Date: Wed, 17 Nov 2021 23:16:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Content-Language: en-US To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20211116214510.2934905-1-jaegeuk@kernel.org> <20211116214510.2934905-2-jaegeuk@kernel.org> From: Chao Yu In-Reply-To: <20211116214510.2934905-2-jaegeuk@kernel.org> X-Headers-End: 1mnMgJ-0001Fn-V8 Subject: Re: [f2fs-dev] [PATCH 2/6] f2fs: do not expose unwritten blocks to user by DIO X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/11/17 5:45, Jaegeuk Kim wrote: > DIO preallocates physical blocks before writing data, but if an error occurrs > or power-cut happens, we can see block contents from the disk. This patch tries > to fix it by 1) turning to buffered writes for DIO into holes, 2) truncating > unwritten blocks from error or power-cut. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/data.c | 5 ++++- > fs/f2fs/f2fs.h | 5 +++++ > fs/f2fs/file.c | 24 +++++++++++++++++++++++- > 3 files changed, 32 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index 3b27fb7daa8b..7ac1a39fcad2 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -1543,8 +1543,11 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, > flag != F2FS_GET_BLOCK_DIO); > err = __allocate_data_block(&dn, > map->m_seg_type); > - if (!err) > + if (!err) { > + if (flag == F2FS_GET_BLOCK_PRE_DIO) > + file_need_truncate(inode); We will leave FADVISE_TRUNC_BIT flag in below call path, is this as expected? - fallocate - expand_inode_data - f2fs_map_blocks(F2FS_GET_BLOCK_PRE_DIO) Thanks, > set_inode_flag(inode, FI_APPEND_WRITE); > + } > } > if (err) > goto sync_out; > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index be871a79c634..14bea669f87e 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -654,6 +654,7 @@ enum { > #define FADVISE_KEEP_SIZE_BIT 0x10 > #define FADVISE_HOT_BIT 0x20 > #define FADVISE_VERITY_BIT 0x40 > +#define FADVISE_TRUNC_BIT 0x80 > > #define FADVISE_MODIFIABLE_BITS (FADVISE_COLD_BIT | FADVISE_HOT_BIT) > > @@ -681,6 +682,10 @@ enum { > #define file_is_verity(inode) is_file(inode, FADVISE_VERITY_BIT) > #define file_set_verity(inode) set_file(inode, FADVISE_VERITY_BIT) > > +#define file_should_truncate(inode) is_file(inode, FADVISE_TRUNC_BIT) > +#define file_need_truncate(inode) set_file(inode, FADVISE_TRUNC_BIT) > +#define file_dont_truncate(inode) clear_file(inode, FADVISE_TRUNC_BIT) > + > #define DEF_DIR_LEVEL 0 > > enum { > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index 4bf77a5bf998..ec8de0662437 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -960,10 +960,21 @@ int f2fs_setattr(struct user_namespace *mnt_userns, struct dentry *dentry, > down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); > filemap_invalidate_lock(inode->i_mapping); > > + /* > + * Truncate stale preallocated blocks used by the previous DIO. > + */ > + if (file_should_truncate(inode)) { > + err = f2fs_truncate(inode); > + if (err) > + goto out_unlock; > + file_dont_truncate(inode); > + } > + > truncate_setsize(inode, attr->ia_size); > > if (attr->ia_size <= old_size) > err = f2fs_truncate(inode); > +out_unlock: > /* > * do not trim all blocks after i_size if target size is > * larger than i_size. > @@ -4257,6 +4268,13 @@ static int f2fs_preallocate_blocks(struct kiocb *iocb, struct iov_iter *iter) > /* If it will be an out-of-place direct write, don't bother. */ > if (dio && f2fs_lfs_mode(sbi)) > return 0; > + /* > + * Don't preallocate holes aligned to DIO_SKIP_HOLES which turns into > + * buffered IO, if DIO meets any holes. > + */ > + if (dio && i_size_read(inode) && > + (F2FS_BYTES_TO_BLK(pos) < F2FS_BLK_ALIGN(i_size_read(inode)))) > + return 0; > > /* No-wait I/O can't allocate blocks. */ > if (iocb->ki_flags & IOCB_NOWAIT) > @@ -4366,10 +4384,14 @@ static ssize_t f2fs_file_write_iter(struct kiocb *iocb, struct iov_iter *from) > if (preallocated > 0 && i_size_read(inode) < target_size) { > down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); > filemap_invalidate_lock(inode->i_mapping); > - f2fs_truncate(inode); > + if (!f2fs_truncate(inode)) > + file_dont_truncate(inode); > filemap_invalidate_unlock(inode->i_mapping); > up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); > + } else { > + file_dont_truncate(inode); > } > + > clear_inode_flag(inode, FI_PREALLOCATED_ALL); > > if (ret > 0) > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel