* [f2fs-dev] [PATCH v2] f2fs: fix to use WHINT_MODE [not found] <CGME20210930005939epcms2p7303bf6f96c824720f824989746491cba@epcms2p7> @ 2021-09-30 0:59 ` Keoseong Park 2021-10-09 4:24 ` Chao Yu [not found] ` <CGME20210930005939epcms2p7303bf6f96c824720f824989746491cba@epcms2p8> 0 siblings, 2 replies; 3+ messages in thread From: Keoseong Park @ 2021-09-30 0:59 UTC (permalink / raw) To: jaegeuk@kernel.org, chao@kernel.org Cc: changfengnan@vivo.com, Sung-Jun Park, Jinyoung CHOI, linux-kernel@vger.kernel.org, tanghuan@vivo.com, linux-f2fs-devel@lists.sourceforge.net Since active_logs can be set to 2 or 4 or NR_CURSEG_PERSIST_TYPE(6), it cannot be set to NR_CURSEG_TYPE(8). That is, whint_mode is always off. Therefore, the condition is changed from NR_CURSEG_TYPE to NR_CURSEG_PERSIST_TYPE. Cc: Chao Yu <chao@kernel.org> Reported-by: Huan Tang <tanghuan@vivo.com> Signed-off-by: Fengnan Chang <changfengnan@vivo.com> Signed-off-by: Keoseong Park <keosung.park@samsung.com> --- v1 -> v2: * Merge Signed-off and Reported tags for the same fix patch. fs/f2fs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 78ebc306ee2b..86eeb019cc52 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -1292,7 +1292,7 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount) /* Not pass down write hints if the number of active logs is lesser * than NR_CURSEG_PERSIST_TYPE. */ - if (F2FS_OPTION(sbi).active_logs != NR_CURSEG_TYPE) + if (F2FS_OPTION(sbi).active_logs != NR_CURSEG_PERSIST_TYPE) F2FS_OPTION(sbi).whint_mode = WHINT_MODE_OFF; if (f2fs_sb_has_readonly(sbi) && !f2fs_readonly(sbi->sb)) { -- 2.17.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [f2fs-dev] [PATCH v2] f2fs: fix to use WHINT_MODE 2021-09-30 0:59 ` [f2fs-dev] [PATCH v2] f2fs: fix to use WHINT_MODE Keoseong Park @ 2021-10-09 4:24 ` Chao Yu [not found] ` <CGME20210930005939epcms2p7303bf6f96c824720f824989746491cba@epcms2p8> 1 sibling, 0 replies; 3+ messages in thread From: Chao Yu @ 2021-10-09 4:24 UTC (permalink / raw) To: keosung.park, jaegeuk@kernel.org Cc: changfengnan@vivo.com, Sung-Jun Park, Jinyoung CHOI, linux-kernel@vger.kernel.org, tanghuan@vivo.com, linux-f2fs-devel@lists.sourceforge.net On 2021/9/30 8:59, Keoseong Park wrote: > Since active_logs can be set to 2 or 4 or NR_CURSEG_PERSIST_TYPE(6), > it cannot be set to NR_CURSEG_TYPE(8). > That is, whint_mode is always off. > > Therefore, the condition is changed from NR_CURSEG_TYPE to NR_CURSEG_PERSIST_TYPE. > Fixes: d0b9e42ab615 (f2fs: introduce inmem curseg) > Cc: Chao Yu <chao@kernel.org> > Reported-by: Huan Tang <tanghuan@vivo.com> > Signed-off-by: Fengnan Chang <changfengnan@vivo.com> > Signed-off-by: Keoseong Park <keosung.park@samsung.com> Reviewed-by: Chao Yu <chao@kernel.org> Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <CGME20210930005939epcms2p7303bf6f96c824720f824989746491cba@epcms2p8>]
* Re: [f2fs-dev] [PATCH v2] f2fs: fix to use WHINT_MODE [not found] ` <CGME20210930005939epcms2p7303bf6f96c824720f824989746491cba@epcms2p8> @ 2021-10-12 2:16 ` Keoseong Park 0 siblings, 0 replies; 3+ messages in thread From: Keoseong Park @ 2021-10-12 2:16 UTC (permalink / raw) To: Chao Yu, Keoseong Park, jaegeuk@kernel.org Cc: changfengnan@vivo.com, Sung-Jun Park, Jinyoung CHOI, linux-kernel@vger.kernel.org, tanghuan@vivo.com, linux-f2fs-devel@lists.sourceforge.net Hi Chao, >On 2021/9/30 8:59, Keoseong Park wrote: >> Since active_logs can be set to 2 or 4 or NR_CURSEG_PERSIST_TYPE(6), >> it cannot be set to NR_CURSEG_TYPE(8). >> That is, whint_mode is always off. >> >> Therefore, the condition is changed from NR_CURSEG_TYPE to NR_CURSEG_PERSIST_TYPE. >> > >Fixes: d0b9e42ab615 (f2fs: introduce inmem curseg) > >> Cc: Chao Yu <chao@kernel.org> >> Reported-by: Huan Tang <tanghuan@vivo.com> >> Signed-off-by: Fengnan Chang <changfengnan@vivo.com> >> Signed-off-by: Keoseong Park <keosung.park@samsung.com> > >Reviewed-by: Chao Yu <chao@kernel.org> Thank you for your review. Best Regards, Keoseong > >Thanks, > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-12 2:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20210930005939epcms2p7303bf6f96c824720f824989746491cba@epcms2p7>
2021-09-30 0:59 ` [f2fs-dev] [PATCH v2] f2fs: fix to use WHINT_MODE Keoseong Park
2021-10-09 4:24 ` Chao Yu
[not found] ` <CGME20210930005939epcms2p7303bf6f96c824720f824989746491cba@epcms2p8>
2021-10-12 2:16 ` Keoseong Park
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).