* [f2fs-dev] [PATCH] f2fs: remove unneeded page uptodate check/set
@ 2023-06-19 15:13 Yunlei He via Linux-f2fs-devel
2023-06-20 9:20 ` Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: Yunlei He via Linux-f2fs-devel @ 2023-06-19 15:13 UTC (permalink / raw)
To: jaegeuk, chao; +Cc: linux-kernel, linux-f2fs-devel
This patch remove unneeded page uptodate check/set in
f2fs_vm_page_mkwrite, which already done in set_page_dirty.
Signed-off-by: Yunlei He <heyunlei@oppo.com>
---
fs/f2fs/file.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 147ab24ae579..b3e96bceaef2 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -149,8 +149,6 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
zero_user_segment(page, offset, PAGE_SIZE);
}
set_page_dirty(page);
- if (!PageUptodate(page))
- SetPageUptodate(page);
out_sem:
f2fs_update_iostat(sbi, inode, APP_MAPPED_IO, F2FS_BLKSIZE);
--
2.40.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: remove unneeded page uptodate check/set
2023-06-19 15:13 [f2fs-dev] [PATCH] f2fs: remove unneeded page uptodate check/set Yunlei He via Linux-f2fs-devel
@ 2023-06-20 9:20 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2023-06-20 9:20 UTC (permalink / raw)
To: Yunlei He, jaegeuk; +Cc: linux-kernel, linux-f2fs-devel
On 2023/6/19 23:13, Yunlei He wrote:
> This patch remove unneeded page uptodate check/set in
> f2fs_vm_page_mkwrite, which already done in set_page_dirty.
>
> Signed-off-by: Yunlei He <heyunlei@oppo.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-20 9:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-19 15:13 [f2fs-dev] [PATCH] f2fs: remove unneeded page uptodate check/set Yunlei He via Linux-f2fs-devel
2023-06-20 9:20 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).