From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Joe Perches <joe@perches.com>
Cc: Christoph Hellwig <hch@infradead.org>,
studentxswpy@163.com, linux-kernel@vger.kernel.org,
Hacash Robot <hacashRobot@santino.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH -next] f2fs: Replace kmalloc() with f2fs_kmalloc
Date: Thu, 4 Aug 2022 21:50:39 +0800 [thread overview]
Message-ID: <a6c31e43-76eb-fefb-b197-c44537cb45af@kernel.org> (raw)
In-Reply-To: <YutC7yUo/mTfty9q@google.com>
On 2022/8/4 11:54, Jaegeuk Kim wrote:
> On 08/01, Joe Perches wrote:
>> On Mon, 2022-08-01 at 11:23 -0700, Christoph Hellwig wrote:
>>> On Mon, Aug 01, 2022 at 05:22:02PM +0800, studentxswpy@163.com wrote:
>>>> From: Xie Shaowen <studentxswpy@163.com>
>>>>
>>>> replace kmalloc with f2fs_kmalloc to keep f2fs code consistency.
>>>
>>> For that removing f2fs_kmalloc entirely would be way better.
>>
>> Dunno, maybe doubtful as there's a specific "fault injector" test
>> built around f2fs_<foo>alloc. (CONFIG_F2FS_FAULT_INJECTION)
>
> Yes, it's very useful to run the test checking the ENOMEM case.
It's useful to cover more error paths for xxx_alloc functions in f2fs
with common testcases.
>
>>
>> For a student lesson, it would significantly better to compile any
>> patch, especially to avoid broken patches, before submitting them.
>>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-08-04 13:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 9:22 [f2fs-dev] [PATCH -next] f2fs: Replace kmalloc() with f2fs_kmalloc studentxswpy
2022-08-01 18:23 ` Christoph Hellwig
2022-08-02 1:42 ` Joe Perches
2022-08-04 3:54 ` Jaegeuk Kim
2022-08-04 13:50 ` Chao Yu [this message]
2022-08-04 3:56 ` Jaegeuk Kim
2022-08-07 8:29 ` kernel test robot
2022-08-07 8:29 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6c31e43-76eb-fefb-b197-c44537cb45af@kernel.org \
--to=chao@kernel.org \
--cc=hacashRobot@santino.com \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=joe@perches.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=studentxswpy@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).