From: Christoph Hellwig <hch@infradead.org>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
drbd-dev@lists.linbit.com
Subject: Re: [f2fs-dev] [PATCH 4/4] bio: use bio_io_error more often
Date: Thu, 5 Mar 2026 06:14:50 -0800 [thread overview]
Message-ID: <aamP2qNKEmiyXQQH@infradead.org> (raw)
In-Reply-To: <20260304190424.291743-5-agruenba@redhat.com>
On Wed, Mar 04, 2026 at 08:04:09PM +0100, Andreas Gruenbacher wrote:
> Instead of setting bio->bi_status to BLK_STS_IOERR and calling
> bio_endio(bio), use the shorthand bio_io_error(bio).
I'm a little torn how good these helpers actually are, as
hard coding one specific type of error seems to create weird
code and lead to bugs like the xfs one you fixed yesterday.
Maybe we just need a bio_endio_status() that allows passing the
satatus?
Also you really need to send one patch per subsystem.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-03-05 14:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 19:04 [f2fs-dev] [PATCH 0/4] simple bio cleanups Andreas Gruenbacher via Linux-f2fs-devel
2026-03-04 19:04 ` [f2fs-dev] [PATCH 1/4] block: consecutive blk_status_t error codes Andreas Gruenbacher via Linux-f2fs-devel
2026-03-05 14:12 ` Christoph Hellwig
2026-03-05 22:36 ` John Garry via Linux-f2fs-devel
2026-03-04 19:04 ` [f2fs-dev] [PATCH 2/4] block: get rid of blk_status_to_{errno, str} inconsistency Andreas Gruenbacher via Linux-f2fs-devel
2026-03-05 14:13 ` Christoph Hellwig
2026-03-06 15:51 ` John Garry via Linux-f2fs-devel
2026-03-04 19:04 ` [f2fs-dev] [PATCH 3/4] bio: rename bio_chain arguments Andreas Gruenbacher via Linux-f2fs-devel
2026-03-04 19:04 ` [f2fs-dev] [PATCH 4/4] bio: use bio_io_error more often Andreas Gruenbacher via Linux-f2fs-devel
2026-03-05 14:14 ` Christoph Hellwig [this message]
2026-03-05 18:37 ` Andreas Gruenbacher via Linux-f2fs-devel
2026-03-05 14:32 ` Coly Li
2026-03-13 12:53 ` [f2fs-dev] [PATCH 0/4] simple bio cleanups Shinichiro Kawasaki via Linux-f2fs-devel
2026-03-13 14:35 ` Andreas Gruenbacher via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aamP2qNKEmiyXQQH@infradead.org \
--to=hch@infradead.org \
--cc=agruenba@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@lst.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox