From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFFE2C4338F for ; Sun, 8 Aug 2021 06:45:36 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BAD160F4B; Sun, 8 Aug 2021 06:45:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9BAD160F4B Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=lists.sourceforge.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:Date:Message-ID: References:To:Sender:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XTkau/vwmF0AhveFnYJgeKUBIUvz0Oc1m8wB8cm0Ufs=; b=I+2GXvGabhM+fzOu1y4SDwnUj ///7FpiaDBg2VauxkdCd9BtInSwx8lpSRKgwzlHgVoiQ+IhW/pTJadHIoVgzBcBVp2fjvj+NfkWrZ mbfGceo9OhnsKIEZJLjhLvJ4K50LGdhk/0U+B3juUqcqlOlbx/VuUEY3ZaPI4GZ62Y0+k=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1mCcYv-0003xQ-TZ; Sun, 08 Aug 2021 06:45:34 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1mCcYu-0003xI-Ds for linux-f2fs-devel@lists.sourceforge.net; Sun, 08 Aug 2021 06:45:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=J86qP9it+nkm99YgHGRVh0Z718ief8bV+tR4GtFtH3M=; b=RFGYYmiwdMkdOtk69ATqEX2rZk KICnrMmNLi3NSodbGGFJaC+FeJUOqC9/Mu0K5aJui5GmusarlmfcI4V5hwGQ4tPVp84YYB3aaVrbR hpTavzlUFRFIOOW+9EGcaR0sEdI/pINMf6DQBIHR1Y520MSi1dyElTqDg4WW1wqGkiAM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=J86qP9it+nkm99YgHGRVh0Z718ief8bV+tR4GtFtH3M=; b=JWGpTQ681+SSd/qLkRh5rFxCi3 ZYOO0JN5lYNRg9ZKYpuz3HHK/1rp1yi7j1iBWWwhTnuR2BjIM73zdgJ+3wjW1RaWaucdcsRZ07h5E O2BFIhFh9j3FQbMhGFumM73510+F6UP1bl5Yb9BLGOd9Vfupzcr/VCE/v1EHQpZjeJkE=; Received: from esa4.hgst.iphmx.com ([216.71.154.42]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mCcYl-00GYcS-0T for linux-f2fs-devel@lists.sourceforge.net; Sun, 08 Aug 2021 06:45:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1628405122; x=1659941122; h=subject:to:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding; bh=UJc/Hvuwn3lsRk9fHecnmjRpT7KEQJhsFR+AONwK1es=; b=ctDnmjeUlg6kBu5Xu8hxwf+2NKD8zH4/4Ngn/Q2Z9RPIFxlUeL0nrC7J /k9KfH77vQulAoGb317nCACbuPGdOJ4/dPCbTvl1WtwnbKdrkOhxjGK/i 4KQ0j8mRvbRXlOHq3LIhk1myQO4EVv5mW5uaHXDf2T8s/cJev7DBeoCOd 2KU5CEoXnslVe/Cxvk2AcysjrwpE7JPxiJhhcx5/OIbtNFWN7KlkcYNaS XDvH+7ugTdxfzDYQX1Pb04SHROSKHvZo/9yMLNCc5WwFJfytNBRXcQ/KS hGdH1K+KyCLlKQ/M46XnzqL7gctR/Bt3/SXFCzJXYvJrcm9QusT9F4s+u A==; X-IronPort-AV: E=Sophos;i="5.84,304,1620662400"; d="scan'208";a="175810982" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 08 Aug 2021 14:29:44 +0800 IronPort-SDR: 7ENM7Ctsyzbxbs9Whfex8J+DbPU4fwzTVvbqicchLxOZ6MVZPwls9S9tRnkQG8Jk5oUdpwv7lA 4nPOUH9zR0R7+b6X3QTlZGShpFCuEyb7wmk/S2D/QhtEBw6Cmr7/jBZm5LDn32qwUKhnzM+AbK Vhv5TPBIHKQUcuLaa1MiFLrhke6ah8a2d5SONcCMz705MIt9vR/jiBsu5xDKPBLvXpCANADwFV dkgkdhlO4Igiz+zuB7wJcKEDot6etYbbxUB5WrnXnJPfBUbhnLb13zYzHWgiOybcEMkvjzr/yz PokYfDCYOKV8YTBKLzR2Zj6T Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2021 23:05:18 -0700 IronPort-SDR: YhEFQpny3zKYw6P8tmRvwLmd7OXuud8ehKUe56rQjcwxePNXXqCT3wHHuc0a9x2ykmYRnufnAz moWkS+Z5bTkA0koCNGzteqSGYZcVSPNNQZMvfXHMSAnqpiyYWbT1gF97t8hHtaPCqKEhOeQMDF 9/Yh2HOlLlZUPgnNfggY76e2aPa/XDNPWFk7TC4PcPw5fDAcuSnRMr52h6gPJACVBxRNFzpVqi uNr6TesLXhkpquRYAKe0qXyXR5la7wbKWZkZ6A3oV3eKf1XqFHyUcRWYv9vrWFn359O2pWKkLk X00= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2021 23:29:45 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Gj8T41bzyz1RvlM for ; Sat, 7 Aug 2021 23:29:44 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-language :content-type:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:to:subject; s=dkim; t= 1628404183; x=1630996184; bh=UJc/Hvuwn3lsRk9fHecnmjRpT7KEQJhsFR+ AONwK1es=; b=Y5YfW8nIddnMzU+ouRnx840tMtKW/nOcMoaJRtItG0ajKAP9qxF PG758L9aw3q3S1NCXP2qWKXvAly/Gh7BC/dVS7zqDMu48nydiQ/ENdFdpYLOtz/O 0yWjP0wGawZnWHC5lBTLukZ8/NiKWt/URaA61InU9IlLVl0S4b8Jheh0JxaL3JCg pzUnJmu2c7HgoUSKZgF02m6JSrL85yiXHgl8I9P3qmXet1Sh0NRi+ayUmV/nU7K3 kLnd3z94F4PUAH7sI+R7T1Kkbdjm5BKautGRE5YLbAgzwl1f5Bl5LFr9tisU0WbN j7kcw3oBDDE/8eZ80kYj0vFH57kHUMPbwQw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Wx_xPF9atyXe for ; Sat, 7 Aug 2021 23:29:43 -0700 (PDT) Received: from [10.225.48.54] (unknown [10.225.48.54]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Gj8T25ShMz1RvlC; Sat, 7 Aug 2021 23:29:42 -0700 (PDT) To: Jens Axboe , Damien Le Moal , linux-block@vger.kernel.org, Paolo Valente , linux-f2fs-devel@lists.sourceforge.net, Jaegeuk Kim , Chao Yu References: <20210806111857.488705-1-damien.lemoal@wdc.com> <20210806111857.488705-3-damien.lemoal@wdc.com> <0141fb21-c0dc-d743-6af9-c2b26d34c4ba@kernel.dk> Organization: Western Digital Message-ID: Date: Sun, 8 Aug 2021 15:29:41 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <0141fb21-c0dc-d743-6af9-c2b26d34c4ba@kernel.dk> Content-Language: en-US X-Headers-End: 1mCcYl-00GYcS-0T Subject: Re: [f2fs-dev] [PATCH v3 2/4] block: fix ioprio interface X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Damien Le Moal via Linux-f2fs-devel Reply-To: Damien Le Moal Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/08/08 1:18, Jens Axboe wrote: > On 8/6/21 5:18 AM, Damien Le Moal wrote: >> An iocb aio_reqprio field is 16-bits (u16) but often handled as an int >> in the block layer. E.g. ioprio_check_cap() takes an int as argument. > > I'd just reference kiocb->ki_ioprio, that's transport agnostic. > > Apart from that, this one looks fine to me. A better commit title > would do wonders too, though, it's very non-descript. OK. Will cleanup commit title and message. -- Damien Le Moal Western Digital Research _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel