From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACB74C43334 for ; Sun, 19 Jun 2022 00:21:17 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1o2igm-00079e-JI; Sun, 19 Jun 2022 00:21:15 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o2igl-00079Y-Lw for linux-f2fs-devel@lists.sourceforge.net; Sun, 19 Jun 2022 00:21:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=h7BbjoMMGvIqkHcYsuwF8s0lnu5U/ZdWplHMYrTmhtY=; b=X/6UMyBWna8o0oe6IYMf5Zo57n 4SoEUnMjoISvnntO96vgyMr/OD53dNwp15HKVaeNYywqhlZkqjeR4K+rXTJZKLXfj1vuVG/y8arIk a1Np991Mc73mUN7+a6mR3XINJsbsN5gBM2YHlcG47gf0hrnhM7qh10ZnPaYvbg1rDhsM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=h7BbjoMMGvIqkHcYsuwF8s0lnu5U/ZdWplHMYrTmhtY=; b=NXG6QftNuIDxzB0HJFD27YFoqC V6gQ1zFwTZ+m3IXCCIoZngjUq2uaLPY/Gjuvh7IUMIlVSuoaiky+FO93MP+E0xTEavPmduZfftTYD 6oU6xHyUxaJIQ5a6YAwpx/aKLq04N5xFsn03xubAmt61wS8WBebMMcT6FiCT+aQaOhRw=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1o2igf-0003kl-5g for linux-f2fs-devel@lists.sourceforge.net; Sun, 19 Jun 2022 00:21:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 52EFB60DEB for ; Sun, 19 Jun 2022 00:21:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36E92C3411A; Sun, 19 Jun 2022 00:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655598059; bh=09d9MnSyiwLCv++b2rqR06abAhRiHJhBnmH9L7iGKpA=; h=Date:Subject:To:References:From:In-Reply-To:From; b=u/R5pG6SSNEqLBRU796YUyI7IizLhntu5RIUIfzhsxWyAX6LTy44ex23Vg17crKaz YZwzxKzUhaQOs4AMc587w+tGEG228OVt7tR97XhiyrpoFlb78P2dcvkaSv5czEo31s g+exwN5SjXrSCcuLwUJMZfAASmw0k4RLtpp9feF28dPapd+hZ1AQm2v9twlC73bjWn 88MXfW7kCAojHDJBqlcFAcacqvDb23JkDraWuxRWl4twOzOgozc+nOrzrvgRzIPnvA 62w4O5FGrkmUq4EySOy0EkwwGGDwkGXtmBh2qifumDpo2Gyu/RSKul6MQ3C0wtGff3 3vU2QtiFiiOuQ== Message-ID: Date: Sun, 19 Jun 2022 08:20:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Content-Language: en-US To: Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net References: <20220615165610.1074259-1-jaegeuk@kernel.org> <20220615165610.1074259-2-jaegeuk@kernel.org> From: Chao Yu In-Reply-To: <20220615165610.1074259-2-jaegeuk@kernel.org> X-Headers-End: 1o2igf-0003kl-5g Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs_io: add dsync option for write X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2022/6/16 0:56, Jaegeuk Kim wrote: > Signed-off-by: Jaegeuk Kim > --- > tools/f2fs_io/f2fs_io.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/f2fs_io/f2fs_io.c b/tools/f2fs_io/f2fs_io.c > index 2f0fc7b25d41..e7359836b126 100644 > --- a/tools/f2fs_io/f2fs_io.c > +++ b/tools/f2fs_io/f2fs_io.c > @@ -508,7 +508,8 @@ static void do_erase(int argc, char **argv, const struct cmd_desc *cmd) > " rand : random numbers\n" \ > "IO can be\n" \ > " buffered : buffered IO\n" \ > -" dio : direct IO\n" \ > +" dio : O_DIRECT\n" \ > +" dsync : O_DIRECT | O_DSYNC\n" \ Should update manual as well. Thanks, > " osync : O_SYNC\n" \ > " atomic_commit : atomic write & commit\n" \ > " atomic_abort : atomic write & abort\n" \ > @@ -552,6 +553,8 @@ static void do_write(int argc, char **argv, const struct cmd_desc *cmd) > > if (!strcmp(argv[5], "dio")) > flags |= O_DIRECT; > + else if (!strcmp(argv[5], "dsync")) > + flags |= O_DIRECT | O_DSYNC; > else if (!strcmp(argv[5], "osync")) > flags |= O_SYNC; > else if (!strcmp(argv[5], "atomic_commit")) _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel