* [f2fs-dev] [PATCH 1/2] android_config: add time headers @ 2022-06-15 16:56 Jaegeuk Kim 2022-06-15 16:56 ` [f2fs-dev] [PATCH 2/2] f2fs_io: add dsync option for write Jaegeuk Kim 0 siblings, 1 reply; 5+ messages in thread From: Jaegeuk Kim @ 2022-06-15 16:56 UTC (permalink / raw) To: linux-f2fs-devel; +Cc: Jaegeuk Kim This allows f2fs_io report latency. Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> --- include/android_config.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/android_config.h b/include/android_config.h index 21eed28669e1..67e5d5871bf8 100644 --- a/include/android_config.h +++ b/include/android_config.h @@ -22,6 +22,8 @@ #define HAVE_SYS_XATTR_H 1 #define HAVE_UNISTD_H 1 #define HAVE_UUID_UUID_H 1 +#define HAVE_CLOCK_GETTIME 1 +#define HAVE_CLOCK_BOOTTIME 1 #define HAVE_FALLOCATE 1 #define HAVE_FSETXATTR 1 -- 2.36.1.476.g0c4daa206d-goog _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [f2fs-dev] [PATCH 2/2] f2fs_io: add dsync option for write 2022-06-15 16:56 [f2fs-dev] [PATCH 1/2] android_config: add time headers Jaegeuk Kim @ 2022-06-15 16:56 ` Jaegeuk Kim 2022-06-19 0:20 ` Chao Yu 2022-06-19 22:05 ` [f2fs-dev] [PATCH 2/2 v2] " Jaegeuk Kim 0 siblings, 2 replies; 5+ messages in thread From: Jaegeuk Kim @ 2022-06-15 16:56 UTC (permalink / raw) To: linux-f2fs-devel; +Cc: Jaegeuk Kim Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> --- tools/f2fs_io/f2fs_io.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/f2fs_io/f2fs_io.c b/tools/f2fs_io/f2fs_io.c index 2f0fc7b25d41..e7359836b126 100644 --- a/tools/f2fs_io/f2fs_io.c +++ b/tools/f2fs_io/f2fs_io.c @@ -508,7 +508,8 @@ static void do_erase(int argc, char **argv, const struct cmd_desc *cmd) " rand : random numbers\n" \ "IO can be\n" \ " buffered : buffered IO\n" \ -" dio : direct IO\n" \ +" dio : O_DIRECT\n" \ +" dsync : O_DIRECT | O_DSYNC\n" \ " osync : O_SYNC\n" \ " atomic_commit : atomic write & commit\n" \ " atomic_abort : atomic write & abort\n" \ @@ -552,6 +553,8 @@ static void do_write(int argc, char **argv, const struct cmd_desc *cmd) if (!strcmp(argv[5], "dio")) flags |= O_DIRECT; + else if (!strcmp(argv[5], "dsync")) + flags |= O_DIRECT | O_DSYNC; else if (!strcmp(argv[5], "osync")) flags |= O_SYNC; else if (!strcmp(argv[5], "atomic_commit")) -- 2.36.1.476.g0c4daa206d-goog _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [f2fs-dev] [PATCH 2/2] f2fs_io: add dsync option for write 2022-06-15 16:56 ` [f2fs-dev] [PATCH 2/2] f2fs_io: add dsync option for write Jaegeuk Kim @ 2022-06-19 0:20 ` Chao Yu 2022-06-19 22:05 ` [f2fs-dev] [PATCH 2/2 v2] " Jaegeuk Kim 1 sibling, 0 replies; 5+ messages in thread From: Chao Yu @ 2022-06-19 0:20 UTC (permalink / raw) To: Jaegeuk Kim, linux-f2fs-devel On 2022/6/16 0:56, Jaegeuk Kim wrote: > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > --- > tools/f2fs_io/f2fs_io.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/f2fs_io/f2fs_io.c b/tools/f2fs_io/f2fs_io.c > index 2f0fc7b25d41..e7359836b126 100644 > --- a/tools/f2fs_io/f2fs_io.c > +++ b/tools/f2fs_io/f2fs_io.c > @@ -508,7 +508,8 @@ static void do_erase(int argc, char **argv, const struct cmd_desc *cmd) > " rand : random numbers\n" \ > "IO can be\n" \ > " buffered : buffered IO\n" \ > -" dio : direct IO\n" \ > +" dio : O_DIRECT\n" \ > +" dsync : O_DIRECT | O_DSYNC\n" \ Should update manual as well. Thanks, > " osync : O_SYNC\n" \ > " atomic_commit : atomic write & commit\n" \ > " atomic_abort : atomic write & abort\n" \ > @@ -552,6 +553,8 @@ static void do_write(int argc, char **argv, const struct cmd_desc *cmd) > > if (!strcmp(argv[5], "dio")) > flags |= O_DIRECT; > + else if (!strcmp(argv[5], "dsync")) > + flags |= O_DIRECT | O_DSYNC; > else if (!strcmp(argv[5], "osync")) > flags |= O_SYNC; > else if (!strcmp(argv[5], "atomic_commit")) _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [f2fs-dev] [PATCH 2/2 v2] f2fs_io: add dsync option for write 2022-06-15 16:56 ` [f2fs-dev] [PATCH 2/2] f2fs_io: add dsync option for write Jaegeuk Kim 2022-06-19 0:20 ` Chao Yu @ 2022-06-19 22:05 ` Jaegeuk Kim 2022-06-20 1:38 ` Chao Yu 1 sibling, 1 reply; 5+ messages in thread From: Jaegeuk Kim @ 2022-06-19 22:05 UTC (permalink / raw) To: linux-f2fs-devel This adds a write option having O_DIRECT | O_DSYNC. Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> --- Change log from v1: - update man page man/f2fs_io.8 | 3 +++ tools/f2fs_io/f2fs_io.c | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/man/f2fs_io.8 b/man/f2fs_io.8 index 8a2c37489939..af7325add388 100644 --- a/man/f2fs_io.8 +++ b/man/f2fs_io.8 @@ -76,6 +76,9 @@ buffered I/O .TP .B dio direct I/O +.TP +.B dsync +direct I/O with O_DSYNC .RE .TP \fBread\fR \fI[chunk_size in 4kb] [offset in chunk_size] [count] [IO] [print_nbytes] [file_path]\fR diff --git a/tools/f2fs_io/f2fs_io.c b/tools/f2fs_io/f2fs_io.c index 2f0fc7b25d41..e7359836b126 100644 --- a/tools/f2fs_io/f2fs_io.c +++ b/tools/f2fs_io/f2fs_io.c @@ -508,7 +508,8 @@ static void do_erase(int argc, char **argv, const struct cmd_desc *cmd) " rand : random numbers\n" \ "IO can be\n" \ " buffered : buffered IO\n" \ -" dio : direct IO\n" \ +" dio : O_DIRECT\n" \ +" dsync : O_DIRECT | O_DSYNC\n" \ " osync : O_SYNC\n" \ " atomic_commit : atomic write & commit\n" \ " atomic_abort : atomic write & abort\n" \ @@ -552,6 +553,8 @@ static void do_write(int argc, char **argv, const struct cmd_desc *cmd) if (!strcmp(argv[5], "dio")) flags |= O_DIRECT; + else if (!strcmp(argv[5], "dsync")) + flags |= O_DIRECT | O_DSYNC; else if (!strcmp(argv[5], "osync")) flags |= O_SYNC; else if (!strcmp(argv[5], "atomic_commit")) -- 2.36.1.476.g0c4daa206d-goog _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [f2fs-dev] [PATCH 2/2 v2] f2fs_io: add dsync option for write 2022-06-19 22:05 ` [f2fs-dev] [PATCH 2/2 v2] " Jaegeuk Kim @ 2022-06-20 1:38 ` Chao Yu 0 siblings, 0 replies; 5+ messages in thread From: Chao Yu @ 2022-06-20 1:38 UTC (permalink / raw) To: Jaegeuk Kim, linux-f2fs-devel On 2022/6/20 6:05, Jaegeuk Kim wrote: > This adds a write option having O_DIRECT | O_DSYNC. > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> Reviewed-by: Chao Yu <chao@kernel.org> Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-20 1:38 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-06-15 16:56 [f2fs-dev] [PATCH 1/2] android_config: add time headers Jaegeuk Kim 2022-06-15 16:56 ` [f2fs-dev] [PATCH 2/2] f2fs_io: add dsync option for write Jaegeuk Kim 2022-06-19 0:20 ` Chao Yu 2022-06-19 22:05 ` [f2fs-dev] [PATCH 2/2 v2] " Jaegeuk Kim 2022-06-20 1:38 ` Chao Yu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).