From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFFCBED7B84 for ; Tue, 14 Apr 2026 07:57:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5CxDRJGQq5GR0PVh180hetB0M7CNlPtoaQGO/AjW5VE=; b=e4kALu2cJm6uM9NS55JoX80qgv qah1OsQBGKIhwH1S+n8US+LAYabOM8VfZ/R00QfVXmetyhmfKpIlAHue2NJDy+okMh24UWskM7Nf/ n2irVFGPEbNm0qlyf2RoNGX5z8Pr8MsZ0kiuKgKAUBXRjObtMoMi2nLH7xy0RumPyKY4=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wCYdy-0000JT-TI; Tue, 14 Apr 2026 07:57:10 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wCYdx-0000JL-9u for linux-f2fs-devel@lists.sourceforge.net; Tue, 14 Apr 2026 07:57:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=F3K7FttOvq8iXxufEoa5R9Agqd7XYyOWbVVEycm3fGI=; b=F1h5Cee9KMPN9XD+a3hOkXpFUO xueaG+KQxxnm1DLy3u7RzoHEasYRD6EPzoX5PJ07LG0IRFtd3V/NFDT+rdFqu1cL99Ge3kfJflfJ6 bvJ6CghW6KZIKBgyC4Kv5C1f480g0sDhh+hePQxwShh8I4TjbrXiNpLRtr/aajyBPYq8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=F3K7FttOvq8iXxufEoa5R9Agqd7XYyOWbVVEycm3fGI=; b=QF4Q8z3XWv7g3eVpmvrSJTxHGW WYTc71gCh+eLu0spxeVJIRtJMCApZAPVFoNyIVF3pkXDxjUYUBxTf4s7XGUdNtQQj6JvpJeg89CrT d3yj/5W725xHMkQ+czCCOL1YO1MAp8yzJZB2GGtpig/MTEKdASf7bXwcwFRdz6BU0elU=; Received: from bombadil.infradead.org ([198.137.202.133]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wCYdw-00029t-8s for linux-f2fs-devel@lists.sourceforge.net; Tue, 14 Apr 2026 07:57:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=F3K7FttOvq8iXxufEoa5R9Agqd7XYyOWbVVEycm3fGI=; b=vbCctZ39PPVVgUPC8arCrwuVoB T+V1r5AQpU/xk0QwQB/NmGZC0H0W3YW1Mc1vEiivmGxacR3doZXOiZBxF2B3kUz4+acPZumNK6bXb D1cLfDAinsfGLBCCmzv38NcuB3xADnlCAThmAcrYKd5gamw2g0q2CGJ2iXJRBLHgQ3IUmPF4pnz3Y GqS0Uxuo5dlXDEM03O0aY4cmRvEFHQpMzqg5iuARTQYsW8y8a9sO4//exZDULxuTOet3FGuvrZkAR 1rrdZir74g+oW0eJ5NJ3VA5TzW0jp9re6q6jBa6Iq6tEy0cZnDOxJyD8nsziRcLYWI8VezJAtl/qQ /Z1T3QrQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1wCYdq-0000000Gvhm-1Tus; Tue, 14 Apr 2026 07:57:02 +0000 Date: Tue, 14 Apr 2026 00:57:02 -0700 From: Christoph Hellwig To: Jan Prusakowski Message-ID: References: <20260410131821.991005-1-jprusakowski@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260410131821.991005-1-jprusakowski@google.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Headers-End: 1wCYdw-00029t-8s Subject: Re: [f2fs-dev] [PATCH] generic/050: handle f2fs as nojournal filesystem X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wqu@suse.com, anand.jain@oracle.com, zlang@kernel.org, fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Fri, Apr 10, 2026 at 01:18:20PM +0000, Jan Prusakowski wrote: > F2FS uses a checkpoint mechanism for metadata consistency rather than a > traditional journal. Roll-forward recovery is only needed if there are > fsync'd files since the last checkpoint. > > In this test case, files are created without fsync, so there is no > roll-forward data to replay during mount. > > Therefore, F2FS does not need to write to the device to recover, and > successfully mounts on the read-only block device. Thus, it should be > treated as nojournal in this case. This looks ok, but I always wonder if we want an opt-in for this "journaling" behavior and/or define it clear in common/. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel