From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F8DBE99071 for ; Fri, 10 Apr 2026 10:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:Message-ID:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=uAHTciYVf8HFvouUJBHSzFA+qxDdGe7Icd4J/cWMV7k=; b=QOTljRgV56a5IqeWNXdq//M+QY 6ZYTBvlPQFr+7O8yAzeIQsQF/Jk1OASs2rT85c0IM4xjvmP/T21anjeHJC8Iy9Cd8FbslRiRWf3Vn GGVlxPf9lfPMbfGMWBhy5LLtVvMkk2q1WVLQ6p5pB2GMAOejoh6Mad+96jm/W+Oyl0rU=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wB8tq-0001V3-76; Fri, 10 Apr 2026 10:15:42 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wB8tc-0001U7-3P for linux-f2fs-devel@lists.sourceforge.net; Fri, 10 Apr 2026 10:15:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZfgI2pXUOHZS6ZdVdKu3ZMeMeuPIis+Wn+AZheOGMYQ=; b=lZeWh/a/g36jViQZMmNtv4Cv4C 9qnHbAYCOBshi0cm9ChZhvRWIrdCXgZyGxWwOQ9N6rRxYjwxm+pdwobeR6Co9+pswG/DhaLgGn2T9 5gpX/o3533FlTiUqBe3A0wzcd57wlwv8D+HrY5/n/LCgtiv7ZOYXNflCVLZZnjGAf7NE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:MIME-Version:Message-ID:Subject:Cc:To:From:Date:Sender: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=ZfgI2pXUOHZS6ZdVdKu3ZMeMeuPIis+Wn+AZheOGMYQ=; b=h TdrzCUEsyPtQcpAG4JSf1ptP/ePq1rJKFkP+yA4rEhdyfXmW7yQM6gd5LPUWgEp32RFJ0m8OCiPcS h0H/hCK/i3oZYanj57Ag3T36ijWW9WIr+HsadNdX68au1OiWCZiRAs16TDxzPgstkuAbqX1U8C05X BHWhV2TB0sBOff5s=; Received: from mail-wr1-f49.google.com ([209.85.221.49]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1wB8tb-0002Ki-Lp for linux-f2fs-devel@lists.sourceforge.net; Fri, 10 Apr 2026 10:15:28 +0000 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-43cfb723698so1386954f8f.3 for ; Fri, 10 Apr 2026 03:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775816116; x=1776420916; darn=lists.sourceforge.net; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=ZfgI2pXUOHZS6ZdVdKu3ZMeMeuPIis+Wn+AZheOGMYQ=; b=QVraV+piZERnnnr/NPU2mx4T5baqrLwbbLlqWMgDmv9nseflwiegZ7bTFLVvxRuXES TUXIFgcMjDTaUwG/0uOD1CTmQIIejAfQG/YFvBT548ZWUOGFvQTcVk2ZDT24oCfIyfIX MVrWkhLfs2oHDuMA94fDAjjlq5GPBJqEPMFFcb+/eX08FbFeS8fwd328RZvnVTdHzzPO ygjx++pviRQe/QM6ECDkdX3hivaVDI5weyA9dskILpOVW+Q/34PkKequc/7nfdDr8je5 HuQnLl3lYqVoHTYyUEHWbAUvCbTPH4FRl3HWKOi7SDS/d2L8H0KSVUxdst5XQg5Diy6W zakQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775816116; x=1776420916; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZfgI2pXUOHZS6ZdVdKu3ZMeMeuPIis+Wn+AZheOGMYQ=; b=AoChYacqebf5dWGwbLabAEjAOFHcLzXrexqooOdtdMjlhdnsMI2VkbfZL+tafA4JzG xad+X9nkBdcOqOU6157i9p56fAd9MyTi6f9iM2fjV44JcCT+nksyzTV2UF/rGwY5syJG EmwFpfQ1cG5fNEjDys6ls8Ad3D6uQFKCgPw1c+IC7mSO295WbkroBWkBbMvLZlNvxLZ5 mqrWvL0d8y6waJf8sMWEBDNjZyFLuoqVarR2TYEdGmND8EtzOUX66BHzBX551slpZIE2 P2hGO6Ikor96xFOVWKQjCjzl2wOQPwkxvNKW5/41hu0NTgnskjvQ0VvHrXEUrzkRA4Ce 4QTQ== X-Gm-Message-State: AOJu0YxH32k92SOPFs6L/zZEdgsbfSiNajfQK2kSrMyRNqZaE7HzuWDV adQkAW/JxVvKq3PWJk9HYBfSRiBF/iDKCsBxEGcGx+oaW42axASulLtI X-Gm-Gg: AeBDietsOZTv/+6YQqj+gWIieqTV9vxfL6YVWKbPPhdB9oxC69CoBUe7S1gfX6u0Hvd tAw9nBapaavC4JOte5BCws8FNYZ/I+nfBUJtiRYq33LfsSAfVQXh3rx8VwK8JAvDIbCuTX4/CWY yqxFN+6zUGcgLwWlHWYX0c6T5GJ3ztszNzKqqKSpdpVzS1e8OpQVAgw5VIl5mt23Bhs6FM+IonE zc3vM32aDBQaWizpfYbUI9fEUlkzEQuQQlgQaq+QYRsSrBdT5oPqYwDPGdcttUlYtFuO4VHL8zN ifgSiuHOIFyiFRfpL0JGeR2dEhHUGX1v8ZcBRGzscOGfSDJoVJbBHK0xS1Hqr0sfEl15+ENUr7F F2M3fDNmSuQLkqwfRXO4exuUYcQ1qKHzv6I6HPRrJlS0G4xUyMYErH+Bt3dqUrmNgoSzZL8egkX jPvpC+idBVjH9YGgS2usw= X-Received: by 2002:a5d:584c:0:b0:43d:394a:476d with SMTP id ffacd0b85a97d-43d642979a1mr3956182f8f.2.1775816115989; Fri, 10 Apr 2026 03:15:15 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e46881sm6676099f8f.23.2026.04.10.03.15.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 03:15:15 -0700 (PDT) Date: Fri, 10 Apr 2026 13:15:12 +0300 From: Dan Carpenter To: Jianan Huang Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Headers-End: 1wB8tb-0002Ki-Lp Subject: [f2fs-dev] [bug report] f2fs: avoid reading already updated pages during GC X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Hello Jianan Huang, Commit 570e2ccc7cb3 ("f2fs: avoid reading already updated pages during GC") from Mar 5, 2026 (linux-next), leads to the following Smatch static checker warning: fs/f2fs/gc.c:1291 ra_data_block() warn: missing error code 'err' fs/f2fs/gc.c 1220 static int ra_data_block(struct inode *inode, pgoff_t index) 1221 { 1222 struct f2fs_sb_info *sbi = F2FS_I_SB(inode); 1223 struct address_space *mapping = f2fs_is_cow_file(inode) ? 1224 F2FS_I(inode)->atomic_inode->i_mapping : inode->i_mapping; 1225 struct dnode_of_data dn; 1226 struct folio *folio, *efolio; 1227 struct f2fs_io_info fio = { 1228 .sbi = sbi, 1229 .ino = inode->i_ino, 1230 .type = DATA, 1231 .temp = COLD, 1232 .op = REQ_OP_READ, 1233 .op_flags = 0, 1234 .encrypted_page = NULL, 1235 .in_list = 0, 1236 }; 1237 int err = 0; 1238 1239 folio = f2fs_grab_cache_folio(mapping, index, true); 1240 if (IS_ERR(folio)) 1241 return PTR_ERR(folio); 1242 1243 if (f2fs_lookup_read_extent_cache_block(inode, index, 1244 &dn.data_blkaddr)) { 1245 if (unlikely(!f2fs_is_valid_blkaddr(sbi, dn.data_blkaddr, 1246 DATA_GENERIC_ENHANCE_READ))) { 1247 err = -EFSCORRUPTED; 1248 goto put_folio; 1249 } 1250 goto got_it; 1251 } 1252 1253 set_new_dnode(&dn, inode, NULL, NULL, 0); 1254 err = f2fs_get_dnode_of_data(&dn, index, LOOKUP_NODE); 1255 if (err) 1256 goto put_folio; 1257 f2fs_put_dnode(&dn); 1258 1259 if (!__is_valid_data_blkaddr(dn.data_blkaddr)) { 1260 err = -ENOENT; 1261 goto put_folio; 1262 } 1263 if (unlikely(!f2fs_is_valid_blkaddr(sbi, dn.data_blkaddr, 1264 DATA_GENERIC_ENHANCE))) { 1265 err = -EFSCORRUPTED; 1266 goto put_folio; 1267 } 1268 got_it: 1269 /* read folio */ 1270 fio.folio = folio; 1271 fio.new_blkaddr = fio.old_blkaddr = dn.data_blkaddr; 1272 1273 /* 1274 * don't cache encrypted data into meta inode until previous dirty 1275 * data were writebacked to avoid racing between GC and flush. 1276 */ 1277 f2fs_folio_wait_writeback(folio, DATA, true, true); 1278 1279 f2fs_wait_on_block_writeback(inode, dn.data_blkaddr); 1280 1281 efolio = f2fs_filemap_get_folio(META_MAPPING(sbi), dn.data_blkaddr, 1282 FGP_LOCK | FGP_CREAT, GFP_NOFS); 1283 if (IS_ERR(efolio)) { 1284 err = PTR_ERR(efolio); 1285 goto put_folio; 1286 } 1287 1288 fio.encrypted_page = &efolio->page; 1289 1290 if (folio_test_uptodate(efolio)) --> 1291 goto put_encrypted_page; Should we set an error code here? 1292 1293 err = f2fs_submit_page_bio(&fio); 1294 if (err) 1295 goto put_encrypted_page; 1296 f2fs_put_page(fio.encrypted_page, false); 1297 f2fs_folio_put(folio, true); 1298 1299 f2fs_update_iostat(sbi, inode, FS_DATA_READ_IO, F2FS_BLKSIZE); 1300 f2fs_update_iostat(sbi, NULL, FS_GDATA_READ_IO, F2FS_BLKSIZE); 1301 1302 return 0; 1303 put_encrypted_page: 1304 f2fs_put_page(fio.encrypted_page, true); 1305 put_folio: 1306 f2fs_folio_put(folio, true); 1307 return err; 1308 } This email is a free service from the Smatch-CI project [smatch.sf.net]. regards, dan carpenter _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel