From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D32E3CD5BB4 for ; Fri, 22 May 2026 14:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y24U76ocv8tjgsmVvqDiTMsHeR8yuUusTC8TjnrGAv0=; b=jb+Cu161RGA64F8XsG/fapdNqH ylrMAbZU3baTjbJw5KVJjlOQfljxJi+z4spyTD6J5CF2zeuM2jrBL33nR58LJioxXX+Pi8A26WIax EM80B+lyCcLcHBphbB4Xj+PprITpNmchfDMF69jj8Kr3osAK/bzG5nKHjUs9S38pimNk=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wQQV0-0006f3-TB; Fri, 22 May 2026 14:05:15 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wQQUz-0006eq-QV for linux-f2fs-devel@lists.sourceforge.net; Fri, 22 May 2026 14:05:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6Ie8d2ZAmeBfN3v2/FX4Pbrv/H8u5AdvngzMgJa2Mf8=; b=hWYd5pxAy3AO93jDEDkioIMR0A X5xQsrcemrm1ipVAqnxvOQJ2vP8+Xf6LYkT963ckfBbwd42xS5DM51p54DRwXz1HHPh3nxkqqALO2 0YwtdX4zkPX11SJnjwKhpG7mpNXz6RsFAr31/Q/O7tPhbelFHjW3O45kJeSwTUNslkOE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6Ie8d2ZAmeBfN3v2/FX4Pbrv/H8u5AdvngzMgJa2Mf8=; b=hP1jiM7ZLd3eLELpVnkDTzM71a w39X+3VFkKW/48DtDv+BiEujBDhmsGbTDb0R3cHaiKQxuctiV6RKKJjYm6nQMxDp8EPtowSVt7NBj PSqyFMqy/vwOXFonD2hAXkPqoHiXJMRmqXeOfSt/q8mVs17PsotgsZ/yw10GPw3MOVQ0=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wQQUx-0001ow-HI for linux-f2fs-devel@lists.sourceforge.net; Fri, 22 May 2026 14:05:14 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id B66A5403FF; Fri, 22 May 2026 14:05:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 490CD1F000E9; Fri, 22 May 2026 14:05:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779458701; bh=6Ie8d2ZAmeBfN3v2/FX4Pbrv/H8u5AdvngzMgJa2Mf8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=mxNBYUYpnAWw8vEEAYBoOy4sKcHYDEtI47yZ4w+/tWMhgmVlXSO42ghF4ocDrA/Aa qEOD7hdtIQYl+6j50auuLdIOl4bUcsbtT55PmICGuXR7SyMh2ebncRH9j18harNy5s qlg/hCMCHbwEcgsALFwbKABqFNiMuxZd3EMh9xh0gVby+C5KXSKR84QkV32rnI8LT2 0bJ3nVYCp8E/zU5w0An8h/WG1g338+A/m44oNUI74RvF777xYt+qVpBF6hWgaauV0t 7bt0Lz1+iQNY/540jiITxZLdfliZjCalbs6kr6IUzf0TtDKSgYbup6xFpsqphGMUf0 SoRh5hhyPT4Fw== Date: Fri, 22 May 2026 14:04:59 +0000 To: Matthew Wilcox Message-ID: References: <20260409134538.3692605-1-jaegeuk@kernel.org> <20260521155748.GA79343@macsyma-wired.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1wQQUx-0001ow-HI Subject: Re: [f2fs-dev] [PATCH v2] f2fs: another way to set large folio by remembering inode number X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jaegeuk Kim via Linux-f2fs-devel Reply-To: Jaegeuk Kim Cc: Theodore Tso , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Christoph Hellwig , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Akilesh Kailash , Christian Brauner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 05/22, Matthew Wilcox wrote: > On Fri, May 22, 2026 at 03:59:45AM +0000, Jaegeuk Kim wrote: > > On 05/21, Matthew Wilcox wrote: > > > On Thu, May 21, 2026 at 11:57:48AM -0400, Theodore Tso wrote: > > > > So let me get this straight. This is a magic xattr interface which is > > > > not even persisted in the file system, but instead sets a 32-bit > > > > bitmask in the struct inode which disappears once the inode gets > > > > flushed from the inode stack. And it uses a generic xattr name, > > > > "user.fadvise". > > > > > > > > There's no way in *hell* any other file system is likely to adopt such > > > > a broken interface, so why didn't you just use an ioctl to set this > > > > magic f2fs-specific flag? > > > > > > I mean, yes, this API is horrendous. But it's just another example of > > > f2fs thinking it's somehow special and not just enabling large folios > > > like other filesystems do. This hurts everyone, not just people who use > > > f2fs. > > > > >From the production viewpoint, I raised a concern on setting large folio by > > default, since that exhausts lots of high-order pages, which were needed for > > essential system services and critical apps. > > Random fears or actual data? This was a quick buddyinfo right after booting the device. Before: Node 0, zone Normal 22684 42284 28704 16901 9515 4566 1854 673 181 36 758 After disabling EROFS large folio: Node 0, zone Normal 8486 4732 2175 1161 697 272 82 19 3 1 856 > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel