From: Jaegeuk Kim via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Christian Brauner <brauner@kernel.org>
Cc: linux-fsdevel@vger.kernel.org,
Rochan Avlur <rochan.avlur@gmail.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: use the mount idmap for the owner check in f2fs_xattr_advise_set()
Date: Mon, 3 Aug 2026 23:33:19 +0000 [thread overview]
Message-ID: <anElP9djtLESAgWF@google.com> (raw)
In-Reply-To: <20260730-jargon-tauchen-angehalten-d4e97dde0ebe@brauner>
On 07/30, Christian Brauner via Linux-f2fs-devel wrote:
> Hi Rochan,
>
> > f2fs_xattr_advise_set() calls inode_owner_or_capable() with
> > &nop_mnt_idmap before allowing the advise xattr to be set, instead of
> > the idmap that was passed into the handler.
> >
> > Since f2fs supports idmapped mounts, this compares the caller's fsuid
> > against the unmapped on-disk owner rather than the mapped owner; resulting
> > in the actual owner to be wrongly denied with -EPERM. Use the idmap
> > argument that was already passed to the xattr handler instead.
> >
> > Fixes: 984fc4e76d63 ("f2fs: support idmapped mounts")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Rochan Avlur <rochan.avlur@gmail.com>
>
> Seems generally fine to me,
> Acked-by: Christian Brauner (Amutable) <braurg>
Thanks, let me applied Acked-by: to the first submitted patch, which is same.
>
> --
>
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-08-03 23:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 4:16 [f2fs-dev] [PATCH] f2fs: use the mount idmap for the owner check in f2fs_xattr_advise_set() Rochan Avlur
2026-07-30 10:23 ` Christian Brauner via Linux-f2fs-devel
2026-08-03 23:33 ` Jaegeuk Kim via Linux-f2fs-devel [this message]
2026-08-03 8:40 ` Chao Yu via Linux-f2fs-devel
2026-08-03 13:43 ` Rochan Avlur
2026-08-05 21:20 ` patchwork-bot+f2fs--- via Linux-f2fs-devel
-- strict thread matches above, loose matches on Subject: below --
2026-07-16 2:59 Zhan Xusheng
2026-08-03 6:34 ` Chao Yu via Linux-f2fs-devel
2026-08-05 21:20 ` patchwork-bot+f2fs--- via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anElP9djtLESAgWF@google.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=brauner@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rochan.avlur@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox