From: Christoph Hellwig <hch@infradead.org>
To: Jan Prusakowski <jprusakowski@google.com>
Cc: jaegeuk@kernel.org, Zorro Lang <zlang@kernel.org>,
fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] generic/622: increase sleep time for lazytime expiration on compressed f2fs
Date: Thu, 8 Oct 2026 02:37:16 -0700 [thread overview]
Message-ID: <asdkTCwh9hW5gkEJ@infradead.org> (raw)
In-Reply-To: <20261008093317.2792726-1-jprusakowski@google.com>
> Increase the sleep duration in expire_timestamps() from 2 to 4 seconds
> when running on F2FS in compress mode to give sufficient margin for the
> flusher thread to reliably expire the lazytime inode and dirty the inode
> page before shutdown.
Please just increase the timeout unconditionally and add a comment
explaining it. While there are some historic hacks like this, generic
tests really should not have file system specific conditionals.
> Change-Id: I208bf14c189b54cc209059b0fd2de9e403a073f2
And please don't add useless not-standard patch trailers.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-10-08 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 9:33 [f2fs-dev] [PATCH] generic/622: increase sleep time for lazytime expiration on compressed f2fs Jan Prusakowski via Linux-f2fs-devel
2026-10-08 9:37 ` Christoph Hellwig [this message]
2026-10-08 9:53 ` Jan Prusakowski via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asdkTCwh9hW5gkEJ@infradead.org \
--to=hch@infradead.org \
--cc=fstests@vger.kernel.org \
--cc=jaegeuk@kernel.org \
--cc=jprusakowski@google.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox