From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 568F0ECAAD8 for ; Tue, 20 Sep 2022 15:44:14 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1oafPx-00053c-Hn; Tue, 20 Sep 2022 15:44:13 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oafPi-00052B-Q8 for linux-f2fs-devel@lists.sourceforge.net; Tue, 20 Sep 2022 15:43:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qd0DKju5t4W8TinRrnflgvakASixa7EdHGubE0AG4SA=; b=J+/yMUlmjuGzuA46jbabk5+NlB cGXe2CMOnolGLJ7NVFE0/FaIY3NPZglFLvSpgalC3zXqI/E0vvoIIctATbA9STzDiE0md8yoK5GAa T2X1rGm22uWILNloyyrnsWoQVWvs1I7LSOd1MhQd8ICrpqgDAad6MJZBpDs0fuhqr8g8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qd0DKju5t4W8TinRrnflgvakASixa7EdHGubE0AG4SA=; b=Lqb+MwFnAtcE20Bmldj/13bYpE 627lUB270RUyfHhDp6L1sO5drq+AdGF4px7GWcVtMZoOgqCiPgUQPdJRbPuJfEohg0+BQ6R42shEg cBHCFIolXXCPnsMiHSR1kUYgiEBOOvgU4THQkINyREWFlY5QBDIZSTL6mGQN1+8ZLtLk=; Received: from ams.source.kernel.org ([145.40.68.75]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1oafPh-0006U2-SV for linux-f2fs-devel@lists.sourceforge.net; Tue, 20 Sep 2022 15:43:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8E86FB82ACF for ; Tue, 20 Sep 2022 15:43:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8C66C433D6; Tue, 20 Sep 2022 15:43:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663688625; bh=PFeHKUWcPvwy22Jq4szgPP8OXgzETyMzB2Jnk5fW8og=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hC99t0npwAV6QO4/MiR2h5zGbZhrFsBoZLJYXEAxowZ+kCdJRprW5sD3Qm3z5HxNz LO4+S037ZBZd43NapyFnLaFxXjSg/P5+11l13v24Ugo88PipAuXs9XLDO/5MIEW+Wv egoISRYYUMvxdXNQLlq3rN2oyI+Hh+MeWXHZIIE5ccPJXQ9CHePyuLbg6WC0NOxQch k6T6dwD/C48KzLtt+Ri+Gf/h3naWWWtXmzTfX1VgvGRL+q8uf66jvnZrJpoyExloAP I3UbOkMT8g82cL47eOUQr5Tvzx6gnAFc2/N8MCoIiBzLf6dq6VqU/EyfSkH697CMIS vH8Q+UAzJKnbQ== Message-ID: Date: Tue, 20 Sep 2022 23:43:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Content-Language: en-US To: Jaegeuk Kim References: <20220913135919.2445544-1-chao@kernel.org> From: Chao Yu In-Reply-To: X-Headers-End: 1oafPh-0006U2-SV Subject: Re: [f2fs-dev] [RFC PATCH v2] f2fs: record need_fsck in super_block X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2022/9/20 8:56, Jaegeuk Kim wrote: > On 09/13, Chao Yu wrote: >> Once CP_ERROR_FLAG is set, checkpoint is disallowed to be triggered to >> persist CP_FSCK_FLAG, fsck won't repair the image due to lack of >> CP_FSCK_FLAG. >> >> This patch proposes to persist newly introduced SB_NEED_FSCK flag into >> super block if CP_ERROR_FLAG and SBI_NEED_FSCK is set, later, once fsck >> detect this flag, it can check and repair corrupted image in time. >> >> Signed-off-by: Chao Yu >> --- >> v2: >> - remove unneeded codes. >> fs/f2fs/checkpoint.c | 6 +++++- >> fs/f2fs/f2fs.h | 1 + >> fs/f2fs/super.c | 26 ++++++++++++++++++++++++++ >> include/linux/f2fs_fs.h | 5 ++++- >> 4 files changed, 36 insertions(+), 2 deletions(-) >> >> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c >> index c3119e4c890c..0836fce40394 100644 >> --- a/fs/f2fs/checkpoint.c >> +++ b/fs/f2fs/checkpoint.c >> @@ -30,8 +30,12 @@ void f2fs_stop_checkpoint(struct f2fs_sb_info *sbi, bool end_io) >> { >> f2fs_build_fault_attr(sbi, 0, 0); >> set_ckpt_flags(sbi, CP_ERROR_FLAG); >> - if (!end_io) >> + if (!end_io) { >> f2fs_flush_merged_writes(sbi); >> + >> + if (is_sbi_flag_set(sbi, SBI_NEED_FSCK)) >> + f2fs_update_sb_flags(sbi, SB_NEED_FSCK); > > Let's think of putting some more context in superblock, if we want to overwrite > it. E.g., a reason to stop checkpoint? Good idea, maybe: Bit Value max number of type [0] need fsck flag 1 [1-5] reason to stop checkpoint 32 [6-13] reason to fsck 256 Thanks > >> + } >> } >> >> /* >> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h >> index dee7b67a17a6..1960a98c7555 100644 >> --- a/fs/f2fs/f2fs.h >> +++ b/fs/f2fs/f2fs.h >> @@ -3556,6 +3556,7 @@ int f2fs_enable_quota_files(struct f2fs_sb_info *sbi, bool rdonly); >> int f2fs_quota_sync(struct super_block *sb, int type); >> loff_t max_file_blocks(struct inode *inode); >> void f2fs_quota_off_umount(struct super_block *sb); >> +void f2fs_update_sb_flags(struct f2fs_sb_info *sbi, unsigned int flag); >> int f2fs_commit_super(struct f2fs_sb_info *sbi, bool recover); >> int f2fs_sync_fs(struct super_block *sb, int sync); >> int f2fs_sanity_check_ckpt(struct f2fs_sb_info *sbi); >> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c >> index b8e5fe244596..c99ba840593d 100644 >> --- a/fs/f2fs/super.c >> +++ b/fs/f2fs/super.c >> @@ -3846,6 +3846,32 @@ int f2fs_commit_super(struct f2fs_sb_info *sbi, bool recover) >> return err; >> } >> >> +void f2fs_update_sb_flags(struct f2fs_sb_info *sbi, unsigned int flag) >> +{ >> + unsigned short s_flags; >> + int err; >> + >> + if (le16_to_cpu(F2FS_RAW_SUPER(sbi)->s_flags) & SB_NEED_FSCK) >> + return; >> + >> + f2fs_down_write(&sbi->sb_lock); >> + >> + s_flags = le16_to_cpu(F2FS_RAW_SUPER(sbi)->s_flags); >> + >> + if (s_flags & SB_NEED_FSCK) >> + goto out_unlock; >> + >> + F2FS_RAW_SUPER(sbi)->s_flags = cpu_to_le16(s_flags | SB_NEED_FSCK); >> + >> + err = f2fs_commit_super(sbi, false); >> + if (err) { >> + f2fs_warn(sbi, "f2fs_commit_super fails to persist flag: %u, err:%d", flag, err); >> + F2FS_RAW_SUPER(sbi)->s_flags = s_flags; >> + } >> +out_unlock: >> + f2fs_up_write(&sbi->sb_lock); >> +} >> + >> static int f2fs_scan_devices(struct f2fs_sb_info *sbi) >> { >> struct f2fs_super_block *raw_super = F2FS_RAW_SUPER(sbi); >> diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h >> index d445150c5350..124176e2a42c 100644 >> --- a/include/linux/f2fs_fs.h >> +++ b/include/linux/f2fs_fs.h >> @@ -73,6 +73,8 @@ struct f2fs_device { >> __le32 total_segments; >> } __packed; >> >> +#define SB_NEED_FSCK 0x00000001 /* need fsck */ >> + >> struct f2fs_super_block { >> __le32 magic; /* Magic Number */ >> __le16 major_ver; /* Major Version */ >> @@ -116,7 +118,8 @@ struct f2fs_super_block { >> __u8 hot_ext_count; /* # of hot file extension */ >> __le16 s_encoding; /* Filename charset encoding */ >> __le16 s_encoding_flags; /* Filename charset encoding flags */ >> - __u8 reserved[306]; /* valid reserved region */ >> + __le16 s_flags; /* super block flags */ >> + __u8 reserved[304]; /* valid reserved region */ >> __le32 crc; /* checksum of superblock */ >> } __packed; >> >> -- >> 2.25.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel