From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C566C433B4 for ; Tue, 11 May 2021 01:38:03 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E452061458 for ; Tue, 11 May 2021 01:38:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E452061458 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1lgHLV-00088X-6p; Tue, 11 May 2021 01:38:01 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1lgHLN-00088F-9d for linux-f2fs-devel@lists.sourceforge.net; Tue, 11 May 2021 01:37:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mTlS6wzB48ygGytPTuR4mKmz2k/kwt1DQudb8KCmOV8=; b=KQWvOvdlJ95n7Owh1/NLGK0ABD 9xwsNHJqI5rS5L3atSVkO7ZMOMZGsMxyE7p7eoobzcdfLI8YQf3jWFvk6OkBY6o6qRCMxXr8FOOb6 ZpOU4wxp0q+m1x+JUUGm3XoBp4cl2HYAlGnkrAIOziwQwIRQzFpAW9g99qr7EHj8sCLM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mTlS6wzB48ygGytPTuR4mKmz2k/kwt1DQudb8KCmOV8=; b=L7yXdPHopNAGHHf9Mzco26IVoM WzdkTPK0EwS380Gn32PhGQ503xu8YZe0FgpTTcZWkFrFa6XQms2DGvGbv15yHm5Xp/BwabTp0YYzN s0DzXjGcwtxq/rjKSBkHnssmKCgniO/c2VzkmIQtpBdBrORfT0lHNQ57854sJx8mdbng=; Received: from szxga04-in.huawei.com ([45.249.212.190]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1lgHLD-00026X-T2 for linux-f2fs-devel@lists.sourceforge.net; Tue, 11 May 2021 01:37:53 +0000 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FfL7F0tbgzmftL; Tue, 11 May 2021 09:34:17 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by smtp.huawei.com (10.3.19.211) with Microsoft SMTP Server (TLS) id 14.3.498.0; Tue, 11 May 2021 09:37:35 +0800 To: Jaegeuk Kim References: <20210510093032.35466-1-yuchao0@huawei.com> From: Chao Yu Message-ID: Date: Tue, 11 May 2021 09:37:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.136.110.154] X-CFilter-Loop: Reflected X-Headers-End: 1lgHLD-00026X-T2 Subject: Re: [f2fs-dev] [PATCH 1/3] f2fs: compress: fix to call f2fs_put_dnode() paired with f2fs_get_block() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/5/10 23:51, Jaegeuk Kim wrote: > On 05/10, Chao Yu wrote: >> f2fs_get_block() and f2fs_put_dnode() should be called as a pair, >> add missing f2fs_put_dnode() in prepare_compress_overwrite(). >> >> Fixes: 4c8ff7095bef ("f2fs: support data compression") >> Signed-off-by: Chao Yu >> --- >> fs/f2fs/compress.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c >> index c208563eac28..d5cb0ba9a0e1 100644 >> --- a/fs/f2fs/compress.c >> +++ b/fs/f2fs/compress.c >> @@ -1088,6 +1088,7 @@ static int prepare_compress_overwrite(struct compress_ctx *cc, >> >> for (i = cc->cluster_size - 1; i > 0; i--) { >> ret = f2fs_get_block(&dn, start_idx + i); >> + f2fs_put_dnode(&dn); > > f2fs_reserve_block() > -> need_put = true; > -> f2fs_put_dnode(); Correct, it looks f2fs_vm_page_mkwrite() doesn't need to call f2fs_put_dnode() as well. Thanks, > >> if (ret) { >> i = cc->cluster_size; >> break; >> -- >> 2.29.2 > . > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel