From: Chao Yu <chao@kernel.org>
To: Daeho Jeong <daeho43@gmail.com>, Chao Yu <yuchao0@huawei.com>
Cc: Sungjong Seo <sj1557.seo@samsung.com>,
kernel-team@android.com, Daeho Jeong <daehojeong@google.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v2 1/2] f2fs: introduce checkpoint=merge mount option
Date: Fri, 15 Jan 2021 22:33:37 +0800 [thread overview]
Message-ID: <b64dc9dd-9f22-cb91-c633-d7bbc74abf72@kernel.org> (raw)
In-Reply-To: <CACOAw_x4R+rWZbi4TQym_sWuyqOGRR5w3iOs1A+e+g=ZT5k7FQ@mail.gmail.com>
On 2021/1/15 22:00, Daeho Jeong wrote:
>> ktime_get() returns time based ns unit, in extreme scenario, average
>> time cp cost will overflow 32-bit variable, I doubt.
>>
> sum_diff is already turned into msec using ktime_ms_delta() above.
Yup, I missed ktime_ms_delta().
On 2021/1/15 22:23, Daeho Jeong wrote:
>>> How about updating queued_ckpt and total_ckpt in batch, update atomic
>>> variable one by one is low efficient.
>>>
>> You mean like using spin_lock()?
>>
> Ah, you mean like updating these values as much as the count of the
> loop at once?
Correct. :)
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2021-01-15 14:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 6:23 [f2fs-dev] [PATCH v2 1/2] f2fs: introduce checkpoint=merge mount option Daeho Jeong
2021-01-14 6:23 ` [f2fs-dev] [PATCH v2 2/2] f2fs: add ckpt_thread_ioprio sysfs node Daeho Jeong
2021-01-21 10:30 ` Chao Yu
2021-01-21 10:57 ` Daeho Jeong
2021-01-15 9:22 ` [f2fs-dev] [PATCH v2 1/2] f2fs: introduce checkpoint=merge mount option Chao Yu
2021-01-15 14:00 ` Daeho Jeong
2021-01-15 14:23 ` Daeho Jeong
2021-01-15 14:33 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b64dc9dd-9f22-cb91-c633-d7bbc74abf72@kernel.org \
--to=chao@kernel.org \
--cc=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).